From: Tom Rini Date: Mon, 11 Sep 2017 12:06:53 -0400 Subject: [U-Boot] [PATCH] fdt: call fdt_fixup_ethernet after board/system fixups In-Reply-To: <20170908173649.31333-1-icenowy@aosc.io> References: <20170908173649.31333-1-icenowy@aosc.io> Message-ID: <20170911160653.GH17058@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, Sep 09, 2017 at 01:36:49AM +0800, Icenowy Zheng wrote: > In commit 26d61195f870 we added fdt_fixup_ethernet to a common code > path, which executes before board/system fixups. > > However, on sunxi platform board-specific fixup will create ethaddr for > ethernet aliases not present in U-Boot FDT, which won't be used in this > situation. > > Move the call of fdt_fixup_ethernet after board/system fixups, so that > board/system fixups can create ethaddr. > > Signed-off-by: Icenowy Zheng OK, this is, sadly, approximately the 10th patch in this area. Your patch specifically brings us back to the state that 3f66149d9fb41527ed70a8e0613489e95391b0ff changed us from, and that was fixing another board (and that in turn "fixed" a change from 13d06981a982). So, as is, no, I'm not going to take this patch. But I am going to put together an email, and some re-reading of the code areas in question, to see what we need to do so that everyone is on the same page and functioning. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: