From: Tom Rini <trini@konsulko.com>
Date: Fri, 15 Sep 2017 12:13:07 -0400
Subject: [U-Boot] [PATCH v3 11/14] dtbo: make dtbos special
In-Reply-To: <d6826614-8037-f5dc-e4b6-27e62f879f2e@wwwdotorg.org>
References: <1504555943-12893-1-git-send-email-pantelis.antoniou@konsulko.com>
 <1504555943-12893-12-git-send-email-pantelis.antoniou@konsulko.com>
 <573fe6ec-227e-9756-66a1-0aeac6251ad3@wwwdotorg.org>
 <d6826614-8037-f5dc-e4b6-27e62f879f2e@wwwdotorg.org>
Message-ID: <20170915161307.GG4560@bill-the-cat>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Sep 15, 2017 at 09:52:41AM -0600, Stephen Warren wrote:
> On 09/15/2017 09:50 AM, Stephen Warren wrote:
> >On 09/04/2017 02:12 PM, Pantelis Antoniou wrote:
> >>Special rule for dtbo generation
> >
> >>diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> >
> >>+quiet_cmd_dtco = DTCO    $@
> >>+# Rule for objects only; does not put specific u-boot include at the end
> >>+# No generation of assembly file either
> >>+# Modified for U-Boot
> >>+cmd_dtco = mkdir -p $(dir ${dtc-tmp}) ; \
> >>+    $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) - ; \
> >>+    $(DTC) -@ -O dtb -o $@ -b 0 \
> >>+        -i $(dir $<) $(DTC_FLAGS) \
> >>+        -d $(depfile).dtc.tmp $(dtc-tmp) ; \
> >
> >As of u-boot-fdt/master commit 503afc3ca1e5 "test: overlay: Add
> >unit test for stacked overlay", the U-Boot build fails for sandbox
> >with the error below. I guess it's due to this commit. Does U-Boot
> >now intentionally rely on a newer dtc or is this an accident?
> >
> >   DTC     test/overlay/test-fdt-base.dtb
> >   LD      lib/libfdt/built-in.o
> >   CC      lib/charset.o
> >   CC      lib/rsa/rsa-verify.o
> >dtc: invalid option -- '@'
> >Usage: dtc [options] <input file>
> >
> >Options: -[qI:O:o:V:d:R:S:p:fb:i:H:sW:E:hv]
> >   -q, --quiet
> >     Quiet: -q suppress warnings, -qq errors, -qqq all
> >...
> 
> Related, the following check in Makefile doesn't trigger:
> 
> checkdtc:
> 	@if test $(call dtc-version) -lt 0104; then \
> 		echo '*** Your dtc is too old, please upgrade to dtc 1.4 or newer'; \
> 		false; \
> 	fi
> 
> ... because I have dtc 1.4.0. If U-Boot requires a new version now,
> that Makefile chunk should be updated.

Ah, this is what needs updating, yes, it needs to cehck for 1.4.3 or
newer.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170915/734f733b/attachment.sig>