From: Martin Jansa <martin.jansa@gmail.com>
Date: Fri, 22 Sep 2017 14:55:27 +0200
To: Mike Crowe <mac@mcrowe.com>
Message-ID: <20170922125527.GB3815@jama>
References: <20170908134802.13519-1-mac@mcrowe.com>
	<20170922113415.5zum55yffbyzci7d@mcrowe.com>
MIME-Version: 1.0
In-Reply-To: <20170922113415.5zum55yffbyzci7d@mcrowe.com>
User-Agent: Mutt/1.9.0 (2017-09-02)
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-qt5][PATCH] qtbase-native: Force use of built-in pcre
Precedence: list
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Fba/0zbH8Xs+Fj9o"
Content-Disposition: inline

--Fba/0zbH8Xs+Fj9o
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 22, 2017 at 12:34:15PM +0100, Mike Crowe wrote:
> On Friday 08 September 2017 at 14:48:02 +0100, Mike Crowe wrote:
> > If we specify neither -system-pcre nor -qt-pcre then qtbase will first =
see
> > if it can find the pcre library in the system and fall back to compiling
> > its own if that's not possible.
> >=20
> > Unfortunately, this means that if qtbase-native happens to be built on a
> > machine with system pcre available then the resulting binaries such as
> > bin/qt5/uic in sstate files won't work correctly on machines that don't
> > have pcre available. Even ignoring that, it doesn't help for packages to
> > build differently depending on how the build system is configured.
> >=20
> > We could depend on pcre-native and pass -system-pcre, but this doesn't =
work
> > by default because qtbase actually requires pcre16 which is an optional
> > (via PACKAGECONFIG) feature of pcre so the default there would need to =
be
> > changed too.
> >=20
> > So, let's make qtbase-native match the default of qtbase by passing
> > -qt-pcre in order to ensure that qtbase-native is always built with its
> > own pcre implementation.
> >=20
> > Signed-off-by: Mike Crowe <mac@mcrowe.com>
> > ---
> >  recipes-qt/qt5/qtbase-native_git.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/recipes-qt/qt5/qtbase-native_git.bb b/recipes-qt/qt5/qtbas=
e-native_git.bb
> > index 54a0b78..0951ede 100644
> > --- a/recipes-qt/qt5/qtbase-native_git.bb
> > +++ b/recipes-qt/qt5/qtbase-native_git.bb
> > @@ -46,6 +46,7 @@ PACKAGECONFIG_CONFARGS =3D " \
> >      -sysroot ${STAGING_DIR_NATIVE} \
> >      -no-gcc-sysroot \
> >      -system-zlib \
> > +    -qt-pcre \
> >      -no-libjpeg \
> >      -no-libpng \
> >      -no-gif \
>=20
> Does anyone have any objections to this?
>=20
> We've been using it for several weeks now and it's not caused any observed
> problems.

It's already merged:
https://github.com/meta-qt5/meta-qt5/commit/743b3b93e17f5382fd1f9f4e0d29325=
01c8a3c78

>=20
> Thanks.
>=20
> Mike.
> --=20
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--=20
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

--Fba/0zbH8Xs+Fj9o
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQRU+ejDffEzV2Je2oc3VSO3ZXaAHAUCWcUIPgAKCRA3VSO3ZXaA
HAUWAKCaSMkYCrHJ0nBg++F8qL7wBLt+wQCfR4cEm/8gzQG7t9mp1GUK0BFDcTk=
=VTS0
-----END PGP SIGNATURE-----

--Fba/0zbH8Xs+Fj9o--