Received-SPF: pass (google.com: domain of keerthigd4990@gmail.com designates 2607:f8b0:400e:c00::241 as permitted sender) client-ip=2607:f8b0:400e:c00::241;
Date: Thu, 28 Sep 2017 20:28:40 +0530
From: Keerthi Reddy <keerthigd4990@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: eric@anholt.net, stefan.wahren@i2se.com
Subject: [PATCH v2] Staging: vc04_services: remove unused variables
Message-ID: <20170928145840.GA16783@manoharreddy>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.24 (2015-08-30)

the volatile fields of bcm2835_alsa_stream -
control and status are not used.

$ grep bcm2835_alsa_stream
From the above command all instances we see that
all variables of 'bcm2835_alsa_stream' are declared as
'alsa_stream'

So search for 'control' wherever we have 'alsa_stream'

$ grep -l 'alsa_stream' | xargs grep "control"
The above command returns where we don't any usage of
'control' field. which means that there is no usage of
these fields.

similarly for 'status' we see no usages.

Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>
---
 changes in v2:
 more discriptive commit message.

 drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
index 379604d..f1e43e4 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
@@ -123,8 +123,6 @@ struct bcm2835_alsa_stream {
 	struct snd_pcm_indirect pcm_indirect;
 
 	spinlock_t lock;
-	volatile unsigned int control;
-	volatile unsigned int status;
 
 	int open;
 	int running;
-- 
2.7.4