From: Wolfgang Denk <wd@denx.de>
Date: Fri, 29 Sep 2017 16:03:47 +0200
Subject: [U-Boot] [PATCH 002/080] mpc83xx: spd_sdram: Fix whitespace
	style violations
In-Reply-To: <20170929125238.26226-2-mario.six@gdsys.cc>
References: <20170929125238.26226-1-mario.six@gdsys.cc>
 <20170929125238.26226-2-mario.six@gdsys.cc>
Message-ID: <20170929140347.72BAD1202D7@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Mario,

In message <20170929125238.26226-2-mario.six@gdsys.cc> you wrote:
> Fix whitespace style violations in the MPC83xx SPD-SDRAM code.
...

> -		ddr->csbnds[1].csbnds = ( (banksize(spd.row_dens) >> 8)
> -				  | ((banksize(spd.row_dens) >> 23) - 1) );
>  		ddr->cs_config[1] = ( 1<<31
> +		ddr->csbnds[1].csbnds = ((banksize(spd.row_dens) >> 8)
> +				  | ((banksize(spd.row_dens) >> 23) - 1));
>  				    | (odt_rd_cfg << 20)
>  				    | (odt_wr_cfg << 16)
>  				    | ((spd.nbanks == 8 ? 1 : 0) << 14)
>  				    | ((spd.nrow_addr - 12) << 8)

This looks as if you were changing the code, and not only whitespace ?

I would expect that this does not even compile!

Which sort of testing did you give to this patch series?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
A witty saying proves nothing, but saying  something  pointless  gets
people's attention.