From: Stephen Hemminger Subject: [PATCH] checkpatch: re-enable warnings about split long strings Date: Fri, 29 Sep 2017 08:37:49 -0700 Message-ID: <20170929153749.9806-1-stephen@networkplumber.org> Cc: Stephen Hemminger , Stephen Hemminger To: dev@dpdk.org Return-path: Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by dpdk.org (Postfix) with ESMTP id 4D5E39FE for ; Fri, 29 Sep 2017 17:38:05 +0200 (CEST) Received: by mail-pg0-f43.google.com with SMTP id k193so3637pgc.8 for ; Fri, 29 Sep 2017 08:38:05 -0700 (PDT) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The Linux kernel style policy about strings is that strings should be always put on one line. This makes sense since a typical use case is for a user to type the error message into a search engine or grep, and it won't be found if split across lines. This patch just re-enables that check. Yes, lots of DPDK code now splits strings, that doesn't make it right. Signed-off-by: Stephen Hemminger --- devtools/checkpatches.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index a56c41a301c0..3e6081dd673e 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -44,7 +44,6 @@ options="$options --show-types" options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ -SPLIT_STRING,LONG_LINE_STRING,\ LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ NEW_TYPEDEFS,COMPARISON_TO_NULL" -- 2.11.0