Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:47593 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbdJAIW6 (ORCPT ); Sun, 1 Oct 2017 04:22:58 -0400 Date: Sun, 1 Oct 2017 01:22:53 -0700 From: Christoph Hellwig To: Josef Bacik Cc: viro@ZenIV.linux.org.uk, kernel-team@fb.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fs: make fiemap work from compat_ioctl Message-ID: <20171001082253.GC9299@infradead.org> References: <1506713046-19299-1-git-send-email-jbacik@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506713046-19299-1-git-send-email-jbacik@fb.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Sep 29, 2017 at 03:24:06PM -0400, Josef Bacik wrote: > We don't need to do anything special with fiemap to make it work with a > 64bit kernel from 32bit userspace, so just go down to do_vfs_ioctl(). > Without this patch we were incorrectly failing to do fiemap with a 32bit > userspace on a 64bit kernel. > > Signed-off-by: Josef Bacik Looks fine, Reviewed-by: Christoph Hellwig