From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915: Fix DDI PHY init if it was already on Date: Mon, 2 Oct 2017 13:09:57 -0700 Message-ID: <20171002200957.l46qdyybqvlxdan6@intel.com> References: <20171002135307.26117-1-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E4E16E0FC for ; Mon, 2 Oct 2017 20:10:00 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171002135307.26117-1-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMDIsIDIwMTcgYXQgMDE6NTM6MDdQTSArMDAwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IFRoZSBjb21tb24gbGFuZSBwb3dlciBkb3duIGZsYWcgb2YgYSBEUElPIFBIWSBoYXMgYSBm dW5reSBzZW1hbnRpYzoKPiBhZnRlciB0aGUgaW5pdGlhbCBlbmFibGluZyBvZiB0aGUgUEhZIChz byBmcm9tIGEgZGlzYWJsZWQgc3RhdGUpIHRoaXMKPiBmbGFnIHdpbGwgYmUgY2xlYXIuIEl0IHdp bGwgYmUgc2V0IG9ubHkgYWZ0ZXIgdGhlIFBIWSB3aWxsIGJlIHVzZWQgZm9yCj4gdGhlIGZpcnN0 IHRpbWUgKGZvciBpbnN0YW5jZSBkdWUgdG8gZW5hYmxpbmcgdGhlIGNvcnJlc3BvbmRpbmcgcGlw ZSkgYW5kCj4gdGhlbiBiZWNvbWUgdW51c2VkIChkdWUgdG8gZGlzYWJsaW5nIHRoZSBwaXBlKS4g RHVyaW5nIHRoZSBpbml0aWFsIFBIWQo+IGVuYWJsZW1lbnQgd2UgZG9uJ3Qga25vdyB3aGljaCBv ZiB0aGUgYWJvdmUgcGhhc2VzIHdlIGFyZSBpbiwgc28gbW92ZQo+IHRoZSBjaGVjayBmb3IgdGhl IGZsYWcgd2hlcmUgdGhpcyBpcyBrbm93biwgdGhlIEhXIHJlYWRvdXQgY29kZS4gVGhpcyBpcwo+ IHdoZXJlIHRoZSByZXN0IG9mIGxhbmUgcG93ZXIgZG93biBzdGF0dXMgY2hlY2tzIGFyZSBkb25l IGFueXdheS4KClRoaXMgbWFrZXMgc2Vuc2UuIEkganVzdCB3b25kZXIgd2h5IGF0IGZpcnN0IHBs YWNlIHdlIHdlcmUgZG9pbmcgdGhhdApleHRyYSBjaGVjayB0byBzZWUgaWYgdGhhdCB3YXMgZGlz YWJsZWQuCkkgY291bGRuJ3QgZmluZCBhbnl0aGluZyBvbiBzcGVjIHRvIGp1c3RpZnkgdGhlIHBy ZXZpb3VzIHVzZSBvZiBpdCBhbmQKbmV3IG9uZSBpcyBjb25zaXN0ZW50IHdpdGggYml0IDkgdGhh dCBpcyB2ZXJ5IHNpbWlsYXIsIHNvOgoKUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmln by52aXZpQGludGVsLmNvbT4KCj4gCj4gVGhpcyBmaXhlcyBhdCBsZWFzdCBhIHByb2JsZW0gb24g R0xLIHdoZXJlIGFmdGVyIG1vZHVsZSByZWxvYWRpbmcsIHRoZQo+IGNvbW1vbiBsYW5lIHBvd2Vy IGRvd24gZmxhZyBvZiBQSFkxIGlzIHNldCwgYnV0IHRoZSBQSFkgaXMgYWN0dWFsbHkKPiBwb3dl cmVkLW9uIGFuZCBwcm9wZXJseSBzZXQgdXAuIFRoZSBHUkMgcmVhZG91dCBjb2RlIGZvciBvdGhl ciBQSFlzIHdpbGwKPiBoZW5jZSB0aGluayB0aGF0IFBIWTEgaXMgbm90IHBvd2VyZWQgaW5pdGlh bGx5IGFuZCBkaXNhYmxlIGl0IGFmdGVyIHRoZQo+IEdSQyByZWFkb3V0LiBUaGlzIHdpbGwgY2F1 c2UgdGhlIEFVWCBwb3dlciB3ZWxsIHJlbGF0ZWQgdG8gUEhZMSB0byBnZXQKPiBkaXNhYmxlZCBp biBhIHN0dWNrIHN0YXRlLCB0aW1pbmcgb3V0IHdoZW4gd2UgdHJ5IHRvIGVuYWJsZSBpdCBsYXRl ci4KPiAKPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gRml4ZXM6IGU5M2RhMGEwMTM3YiAoImRybS9pOTE1L2J4dDogU2FuaXRpeSBjaGVjayB0aGUg UEhZIGxhbmUgcG93ZXIgZG93biBzdGF0dXMiKQo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJl ZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI3NzcKPiBTaWduZWQtb2ZmLWJ5OiBJbXJl IERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RkaS5jICAgICAgfCAgMyArKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHBpb19waHkuYyB8IDIwIC0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwg MiBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k ZGkuYwo+IGluZGV4IDkzY2JiY2JiYzE5My4uNjVmNGI2Nzg2NzkxIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGRpLmMKPiBAQCAtMTcxMyw3ICsxNzEzLDggQEAgYm9vbCBpbnRlbF9kZGlfZ2V0 X2h3X3N0YXRlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICBvdXQ6Cj4gIAlpZiAo cmV0ICYmIElTX0dFTjlfTFAoZGV2X3ByaXYpKSB7Cj4gIAkJdG1wID0gSTkxNV9SRUFEKEJYVF9Q SFlfQ1RMKHBvcnQpKTsKPiAtCQlpZiAoKHRtcCAmIChCWFRfUEhZX0xBTkVfUE9XRVJET1dOX0FD SyB8Cj4gKwkJaWYgKCh0bXAgJiAoQlhUX1BIWV9DTU5MQU5FX1BPV0VSRE9XTl9BQ0sgfAo+ICsJ CQkgICAgQlhUX1BIWV9MQU5FX1BPV0VSRE9XTl9BQ0sgfAo+ICAJCQkgICAgQlhUX1BIWV9MQU5F X0VOQUJMRUQpKSAhPSBCWFRfUEhZX0xBTkVfRU5BQkxFRCkKPiAgCQkJRFJNX0VSUk9SKCJQb3J0 ICVjIGVuYWJsZWQgYnV0IFBIWSBwb3dlcmVkIGRvd24/ICIKPiAgCQkJCSAgIihQSFlfQ1RMICUw OHgpXG4iLCBwb3J0X25hbWUocG9ydCksIHRtcCk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwaW9fcGh5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cGlvX3BoeS5jCj4gaW5kZXggMDliNjcwOTI5Nzg2Li5kZTM4ZDAxNGVkMzkgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBpb19waHkuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwaW9fcGh5LmMKPiBAQCAtMjA4LDEyICsyMDgsNiBAQCBzdGF0 aWMgY29uc3Qgc3RydWN0IGJ4dF9kZGlfcGh5X2luZm8gZ2xrX2RkaV9waHlfaW5mb1tdID0gewo+ ICAJfSwKPiAgfTsKPiAgCj4gLXN0YXRpYyB1MzIgYnh0X3BoeV9wb3J0X21hc2soY29uc3Qgc3Ry dWN0IGJ4dF9kZGlfcGh5X2luZm8gKnBoeV9pbmZvKQo+IC17Cj4gLQlyZXR1cm4gKHBoeV9pbmZv LT5kdWFsX2NoYW5uZWwgKiBCSVQocGh5X2luZm8tPmNoYW5uZWxbRFBJT19DSDFdLnBvcnQpKSB8 Cj4gLQkJQklUKHBoeV9pbmZvLT5jaGFubmVsW0RQSU9fQ0gwXS5wb3J0KTsKPiAtfQo+IC0KPiAg c3RhdGljIGNvbnN0IHN0cnVjdCBieHRfZGRpX3BoeV9pbmZvICoKPiAgYnh0X2dldF9waHlfbGlz dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGludCAqY291bnQpCj4gIHsKPiBA QCAtMzEzLDcgKzMwNyw2IEBAIGJvb2wgYnh0X2RkaV9waHlfaXNfZW5hYmxlZChzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCSAgICBlbnVtIGRwaW9fcGh5IHBoeSkKPiAg ewo+ICAJY29uc3Qgc3RydWN0IGJ4dF9kZGlfcGh5X2luZm8gKnBoeV9pbmZvOwo+IC0JZW51bSBw b3J0IHBvcnQ7Cj4gIAo+ICAJcGh5X2luZm8gPSBieHRfZ2V0X3BoeV9pbmZvKGRldl9wcml2LCBw aHkpOwo+ICAKPiBAQCAtMzM1LDE5ICszMjgsNiBAQCBib29sIGJ4dF9kZGlfcGh5X2lzX2VuYWJs ZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCXJldHVybiBmYWxzZTsK PiAgCX0KPiAgCj4gLQlmb3JfZWFjaF9wb3J0X21hc2tlZChwb3J0LCBieHRfcGh5X3BvcnRfbWFz ayhwaHlfaW5mbykpIHsKPiAtCQl1MzIgdG1wID0gSTkxNV9SRUFEKEJYVF9QSFlfQ1RMKHBvcnQp KTsKPiAtCj4gLQkJaWYgKHRtcCAmIEJYVF9QSFlfQ01OTEFORV9QT1dFUkRPV05fQUNLKSB7Cj4g LQkJCURSTV9ERUJVR19EUklWRVIoIkRESSBQSFkgJWQgcG93ZXJlZCwgYnV0IGNvbW1vbiBsYW5l ICIKPiAtCQkJCQkgImZvciBwb3J0ICVjIHBvd2VyZWQgZG93biAiCj4gLQkJCQkJICIoUEhZX0NU TCAlMDh4KVxuIiwKPiAtCQkJCQkgcGh5LCBwb3J0X25hbWUocG9ydCksIHRtcCk7Cj4gLQo+IC0J CQlyZXR1cm4gZmFsc2U7Cj4gLQkJfQo+IC0JfQo+IC0KPiAgCXJldHVybiB0cnVlOwo+ICB9Cj4g IAo+IC0tIAo+IDIuMTMuMgo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK