Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EAAEE21F3C181 for ; Tue, 10 Oct 2017 12:40:53 -0700 (PDT) Date: Tue, 10 Oct 2017 12:44:21 -0700 From: Andrew Morton Subject: Re: [PATCH] Fix mpage_writepage() for pages with buffers Message-Id: <20171010124421.c545e6308fed5a585acd43cd@linux-foundation.org> In-Reply-To: <20171006211541.GA7409@bombadil.infradead.org> References: <20171006211541.GA7409@bombadil.infradead.org> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Matthew Wilcox Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linus Torvalds , OGAWA Hirofumi List-ID: On Fri, 6 Oct 2017 14:15:41 -0700 Matthew Wilcox wrote: > When using FAT on a block device which supports rw_page, we can hit > BUG_ON(!PageLocked(page)) in try_to_free_buffers(). This is because we > call clean_buffers() after unlocking the page we've written. Introduce a > new clean_page_buffers() which cleans all buffers associated with a page > and call it from within bdev_write_page(). This is all pretty mature code (isn't it?). Any idea why this bug popped up now? _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm