Return-Path: Received: from mout.kundenserver.de ([212.227.126.130]:51747 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751682AbdJLPcI (ORCPT ); Thu, 12 Oct 2017 11:32:08 -0400 From: Arnd Bergmann To: Alexander Viro Cc: Nicolas Pitre , Arnd Bergmann , Ingo Molnar , Nicolas Pitre , Frederic Weisbecker , Mickael GUENE , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] elf_fdpic: fix unused variable warning Date: Thu, 12 Oct 2017 17:31:46 +0200 Message-Id: <20171012153158.2840511-1-arnd@arndb.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: The elf_fdpic code shows a harmless warning when built with MMU disabled, I ran into this now that fdpic is available on ARM randconfig builds since commit 50b2b2e691cd ("ARM: add ELF_FDPIC support"). fs/binfmt_elf_fdpic.c: In function 'elf_fdpic_dump_segments': fs/binfmt_elf_fdpic.c:1501:17: error: unused variable 'addr' [-Werror=unused-variable] This adds another #ifdef around the variable declaration to shut up the warning. Fixes: e6c1baa9b562 ("convert the rest of binfmt_elf_fdpic to dump_emit()") Acked-by: Nicolas Pitre Signed-off-by: Arnd Bergmann --- v2: fixed changelog text --- fs/binfmt_elf_fdpic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index 5429b035e249..429326b6e2e7 100644 --- a/fs/binfmt_elf_fdpic.c +++ b/fs/binfmt_elf_fdpic.c @@ -1498,7 +1498,9 @@ static bool elf_fdpic_dump_segments(struct coredump_params *cprm) struct vm_area_struct *vma; for (vma = current->mm->mmap; vma; vma = vma->vm_next) { +#ifdef CONFIG_MMU unsigned long addr; +#endif if (!maydump(vma, cprm->mm_flags)) continue; -- 2.9.0