Received: from eggs.gnu.org ([2001:4830:134:3::10]:36456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2vpL-0000OU-1Q for qemu-devel@nongnu.org; Fri, 13 Oct 2017 05:00:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2vpH-0004oK-24 for qemu-devel@nongnu.org; Fri, 13 Oct 2017 05:00:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35200) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e2vpG-0004nw-Pk for qemu-devel@nongnu.org; Fri, 13 Oct 2017 05:00:14 -0400 Date: Fri, 13 Oct 2017 11:00:04 +0200 From: Igor Mammedov Message-ID: <20171013110004.50db3472@nial.brq.redhat.com> In-Reply-To: <74abada799dfcfca81f7c582f2205abf7371ec14.1507852977.git.alistair.francis@xilinx.com> References: <74abada799dfcfca81f7c582f2205abf7371ec14.1507852977.git.alistair.francis@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/5] netduino2: Specify the valid CPUs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, f4bug@amsat.org, marcel@redhat.com, alistair23@gmail.com On Thu, 12 Oct 2017 17:07:25 -0700 Alistair Francis wrote: > List all possible valid CPU options. >=20 > Although the board only ever has a Cortex-M3 we mark the Cortex-M4 as > supported because the Netduino2 Plus supports the Cortex-M4 and the > Netduino2 Plus is similar to the Netduino2. >=20 > Signed-off-by: Alistair Francis > Reviewed-by: Eduardo Habkost > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > --- >=20 > V2: > - Fixup allignment > RFC v2: > - Use a NULL terminated list > - Add the Cortex-M4 for testing >=20 >=20 > hw/arm/netduino2.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c > index f936017d4a..6427552a72 100644 > --- a/hw/arm/netduino2.c > +++ b/hw/arm/netduino2.c > @@ -34,18 +34,26 @@ static void netduino2_init(MachineState *machine) > DeviceState *dev; > =20 > dev =3D qdev_create(NULL, TYPE_STM32F205_SOC); > - qdev_prop_set_string(dev, "cpu-type", ARM_CPU_TYPE_NAME("cortex-m3")= ); > + qdev_prop_set_string(dev, "cpu-type", machine->cpu_type); > object_property_set_bool(OBJECT(dev), true, "realized", &error_fatal= ); > =20 > armv7m_load_kernel(ARM_CPU(first_cpu), machine->kernel_filename, > FLASH_SIZE); > } > =20 > +const char *netduino_valid_cpus[] =3D { may be add 'static' here and ditto in other patches > + ARM_CPU_TYPE_NAME("cortex-m3"), > + ARM_CPU_TYPE_NAME("cortex-m4"), > + NULL > + }; > + > static void netduino2_machine_init(MachineClass *mc) > { > mc->desc =3D "Netduino 2 Machine"; > mc->init =3D netduino2_init; > mc->ignore_memory_transaction_failures =3D true; > + mc->default_cpu_type =3D ARM_CPU_TYPE_NAME("cortex-m3"); > + mc->valid_cpu_types =3D netduino_valid_cpus; > } > =20 > DEFINE_MACHINE("netduino2", netduino2_machine_init)