From: Boris Brezillon Subject: Re: [PATCH v2] drm/vc4: Fix sleeps during the IRQ handler for DSI transactions. Date: Sat, 14 Oct 2017 09:53:55 +0200 Message-ID: <20171014095355.0d9945c9@bbrezillon> References: <20171014001255.32005-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FEEF6E275 for ; Sat, 14 Oct 2017 07:53:57 +0000 (UTC) In-Reply-To: <20171014001255.32005-1-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAxMyBPY3QgMjAxNyAxNzoxMjo1NSAtMDcwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gVkM0J3MgRFNJMSBoYXMgYSBidWcgd2hlcmUgdGhlIEFYSSBjb25u ZWN0aW9uIGlzIGJyb2tlbiBmb3IgMzItYml0Cj4gd3JpdGVzIGZyb20gdGhlIENQVSwgc28gd2Ug dXNlIHRoZSBETUEgZW5naW5lIHRvIERNQSAzMi1iaXQgdmFsdWVzCj4gaW50byByZWdpc3RlcnMg aW5zdGVhZC4gIFRoYXQgc2xlZXBzLCBzbyB3ZSBjYW4ndCBkbyBpdCBmcm9tIHRoZSB0b3AKPiBo YWxmLgo+IAo+IEFzIGEgc29sdXRpb24sIHVzZSBhbiBpbnRlcnJ1cHQgdGhyZWFkIHNvIHRoYXQg YWxsIG91ciB3cml0ZXMgaGFwcGVuCj4gd2hlbiBzbGVlcGluZyBpcyBpcyBhbGxvd2VkLgo+IAo+ IHYyOiBVc2UgSVJRRl9PTkVTSE9UIChzdWdnZXN0ZWQgYnkgQm9yaXMpCj4gCj4gU2lnbmVkLW9m Zi1ieTogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0Lm5ldD4KClJldmlld2VkLWJ5OiBCb3JpcyBC cmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBmcmVlLWVsZWN0cm9ucy5jb20+Cgo+IC0tLQo+IAo+ IEJvcmlzLCB0aGF0IGNsZWFudXAgZW5kZWQgdXAgd29ya2luZyBhbmQgaXQgbG9va3MgZ3JlYXQu ICBUaGFua3MhCj4gCj4gIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2RzaS5jIHwgMzEgKysrKysr KysrKysrKysrKysrKysrKysrKysrKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjkgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Zj NC92YzRfZHNpLmMgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kc2kuYwo+IGluZGV4IDU1NDYw NWFmMzQ0ZS4uM2I3NGZkYTU2NjJkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92YzQv dmM0X2RzaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZHNpLmMKPiBAQCAtMTM2 MCw2ICsxMzYwLDI1IEBAIHN0YXRpYyB2b2lkIGRzaV9oYW5kbGVfZXJyb3Ioc3RydWN0IHZjNF9k c2kgKmRzaSwKPiAgCSpyZXQgPSBJUlFfSEFORExFRDsKPiAgfQo+ICAKPiArLyogSW5pdGlhbCBo YW5kbGVyIGZvciBwb3J0IDEgd2hlcmUgd2UgbmVlZCB0aGUgcmVnX2RtYSB3b3JrYXJvdW5kLgo+ ICsgKiBUaGUgcmVnaXN0ZXIgRE1BIHdyaXRlcyBzbGVlcCwgc28gd2UgY2FuJ3QgZG8gaXQgaW4g dGhlIHRvcCBoYWxmLgo+ICsgKiBJbnN0ZWFkIHdlIHVzZSBJUlFGX09ORVNIT1Qgc28gdGhhdCB0 aGUgSVJRIGdldHMgZGlzYWJsZWQgaW4gdGhlCj4gKyAqIHBhcmVudCBpbnRlcnJ1cHQgY29udHJs bGVyIHVudGlsIG91ciBpbnRlcnJ1cHQgdGhyZWFkIGlzIGRvbmUuCj4gKyAqLwo+ICtzdGF0aWMg aXJxcmV0dXJuX3QgdmM0X2RzaV9pcnFfZGVmZXJfdG9fdGhyZWFkX2hhbmRsZXIoaW50IGlycSwg dm9pZCAqZGF0YSkKPiArewo+ICsJc3RydWN0IHZjNF9kc2kgKmRzaSA9IGRhdGE7Cj4gKwl1MzIg c3RhdCA9IERTSV9QT1JUX1JFQUQoSU5UX1NUQVQpOwo+ICsKPiArCWlmICghc3RhdCkKPiArCQly ZXR1cm4gSVJRX05PTkU7Cj4gKwo+ICsJcmV0dXJuIElSUV9XQUtFX1RIUkVBRDsKPiArfQo+ICsK PiArLyogTm9ybWFsIElSUSBoYW5kbGVyIGZvciBwb3J0IDAsIG9yIHRoZSB0aHJlYWRlZCBJUlEg aGFuZGxlciBmb3IgcG9ydAo+ICsgKiAxIHdoZXJlIHdlIG5lZWQgdGhlIHJlZ19kbWEgd29ya2Fy b3VuZC4KPiArICovCj4gIHN0YXRpYyBpcnFyZXR1cm5fdCB2YzRfZHNpX2lycV9oYW5kbGVyKGlu dCBpcnEsIHZvaWQgKmRhdGEpCj4gIHsKPiAgCXN0cnVjdCB2YzRfZHNpICpkc2kgPSBkYXRhOwo+ IEBAIC0xNTM5LDggKzE1NTgsMTYgQEAgc3RhdGljIGludCB2YzRfZHNpX2JpbmQoc3RydWN0IGRl dmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsIHZvaWQgKmRhdGEpCj4gIAkvKiBDbGVh ciBhbnkgZXhpc3RpbmcgaW50ZXJydXB0IHN0YXRlLiAqLwo+ICAJRFNJX1BPUlRfV1JJVEUoSU5U X1NUQVQsIERTSV9QT1JUX1JFQUQoSU5UX1NUQVQpKTsKPiAgCj4gLQlyZXQgPSBkZXZtX3JlcXVl c3RfaXJxKGRldiwgcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKSwKPiAtCQkJICAgICAgIHZjNF9k c2lfaXJxX2hhbmRsZXIsIDAsICJ2YzQgZHNpIiwgZHNpKTsKPiArCWlmIChkc2ktPnJlZ19kbWFf bWVtKSB7Cj4gKwkJcmV0ID0gZGV2bV9yZXF1ZXN0X3RocmVhZGVkX2lycShkZXYsIHBsYXRmb3Jt X2dldF9pcnEocGRldiwgMCksCj4gKwkJCQkJCXZjNF9kc2lfaXJxX2RlZmVyX3RvX3RocmVhZF9o YW5kbGVyLAo+ICsJCQkJCQl2YzRfZHNpX2lycV9oYW5kbGVyLAo+ICsJCQkJCQlJUlFGX09ORVNI T1QsCj4gKwkJCQkJCSJ2YzQgZHNpIiwgZHNpKTsKPiArCX0gZWxzZSB7Cj4gKwkJcmV0ID0gZGV2 bV9yZXF1ZXN0X2lycShkZXYsIHBsYXRmb3JtX2dldF9pcnEocGRldiwgMCksCj4gKwkJCQkgICAg ICAgdmM0X2RzaV9pcnFfaGFuZGxlciwgMCwgInZjNCBkc2kiLCBkc2kpOwo+ICsJfQo+ICAJaWYg KHJldCkgewo+ICAJCWlmIChyZXQgIT0gLUVQUk9CRV9ERUZFUikKPiAgCQkJZGV2X2VycihkZXYs ICJGYWlsZWQgdG8gZ2V0IGludGVycnVwdDogJWRcbiIsIHJldCk7CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK