From: James Ausmus Subject: Re: [PATCH v5] drm/i915: Handle drm-layer errors in intel_dp_add_mst_connector Date: Tue, 17 Oct 2017 09:46:28 -0700 Message-ID: <20171017164626.GA18949@jausmus-gentoo-dev6.jf.intel.com> References: <20170914195935.2408-1-james.ausmus@intel.com> <20171013180144.15865-1-james.ausmus@intel.com> <20171017153818.GW10981@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 236E86E6FF for ; Tue, 17 Oct 2017 16:45:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171017153818.GW10981@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMTcsIDIwMTcgYXQgMDY6Mzg6MThQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIEZyaSwgT2N0IDEzLCAyMDE3IGF0IDExOjAxOjQ0QU0gLTA3MDAsIEphbWVz IEF1c211cyB3cm90ZToKPiA+IE1ha2UgaW50ZWxfZHBfYWRkX21zdF9jb25uZWN0b3IgaGFuZGxl IGVycm9yIHJldHVybnMgZnJvbSB0aGUgZHJtXyBjYWxscy4KPiA+IEFkZCBpbnRlbF9jb25uZWN0 b3JfZnJlZSB0byBzdXBwb3J0IGNsZWFudXAgb24gdGhlIGVycm9yIHBhdGguCj4gPiAKPiA+IHYy OiBSZW5hbWUgbmV3IGZ1bmN0aW9uIHRvIGF2b2lkIGNvbmZ1c2lvbiwgYW5kIHNpbXBsaWZ5IGVy cm9yCj4gPiBwYXRocyAoVmlsbGUpCj4gPiAKPiA+IHYzOiBJbmRlbnRhdGlvbiBmaXh1cCwgc3R5 bGUgZml4ZXMgKFZpbGxlKQo+ID4gCj4gPiB2NDogQ2xhcmlmeSB1c2FnZSBvZiBpbnRlbF9jb25u ZWN0b3JfZnJlZSwgYW5kIGZpeCB1c2FnZSBvZgo+ID4gaW50ZWxfY29ubmVjdG9yX2ZyZWUKPiA+ IAo+ID4gdjU6IFJlYmFzZQo+ID4gCj4gPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IEphbWVzIEF1c211cyA8amFt ZXMuYXVzbXVzQGludGVsLmNvbT4KPiAKPiBQdXNoZWQgdG8gZGlucS4gVGhhbmtzIGZvciB0aGUg cGF0Y2guCj4gCj4gT25lIHNsaWdodCBjb25jZXJuIHRoYXQgY2FtZSB0byBteSBtaW5kIGlzIHdo ZXRoZXIgd2UnbGwgbGVhdmUgc3VmZmljaWVudAo+IGJyZWFkY3J1bWJzIGludG8gdGhlIGxvZyB0 byBzZWUgdGhhdCB3ZSBmYWlsZWQgdG8gYWRkIGEgY29ubmVjdG9yIHRoYXQKPiB3YXMgcmVhbGx5 IG1lYW50IHRvIGJlIHRoZXJlLiBXZSBtaWdodCB3YW50IHRvIGFkZCBzb21lIGVycm9yIHByaW50 cwo+IGZvciB0aGF0LgoKSG1tIC0gbG9va2luZyBhdCB0aGUgZHJtX2RwX21zdF90b3BvbG9neV9t Z3IgYml0cywgaXQgbG9va3MgbGlrZSBpZgphZGRfY29ubmVjdG9yIHJldHVybnMgbnVsbCwgdGhl IHBvcnQgaW4gcXVlc3Rpb24gaXMganVzdCBkcm9wcGVkCnNpbGVudGx5LiBJJ2xsIHB1dCBhZGRp bmcgc29tZSBlcnJvciBtZXNzYWdlcyBvbiBmYWlsdXJlIHRvIG15IFRPRE8KbGlzdC4gOikKClRo YW5rcyEKCi1KYW1lcwoKPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYyB8IDEzICsrKysrKysrKysrKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcF9tc3QuYyAgfCAyNyArKysrKysrKysrKysrKysrKysrKysrKy0tLS0KPiA+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgfCAgMSArCj4gPiAgMyBmaWxlcyBjaGFu Z2VkLCAzNyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCAxODViZTU3MjZiNWUuLjc5NmVhZDQyNWYy MyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtNjEz OSw2ICs2MTM5LDE5IEBAIHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmludGVsX2Nvbm5lY3Rvcl9h bGxvYyh2b2lkKQo+ID4gIAlyZXR1cm4gY29ubmVjdG9yOwo+ID4gIH0KPiA+ICAKPiA+ICsvKgo+ ID4gKyAqIEZyZWUgdGhlIGJpdHMgYWxsb2NhdGVkIGJ5IGludGVsX2Nvbm5lY3Rvcl9hbGxvYy4K PiA+ICsgKiBUaGlzIHNob3VsZCBvbmx5IGJlIHVzZWQgYWZ0ZXIgaW50ZWxfY29ubmVjdG9yX2Fs bG9jIGhhcyByZXR1cm5lZAo+ID4gKyAqIHN1Y2Nlc3NmdWxseSwgYW5kIGJlZm9yZSBkcm1fY29u bmVjdG9yX2luaXQgcmV0dXJucyBzdWNjZXNzZnVsbHkuCj4gPiArICogT3RoZXJ3aXNlIHRoZSBk ZXN0cm95IGNhbGxiYWNrcyBmb3IgdGhlIGNvbm5lY3RvciBhbmQgdGhlIHN0YXRlIHNob3VsZAo+ ID4gKyAqIHRha2UgY2FyZSBvZiBwcm9wZXIgY2xlYW51cC9mcmVlCj4gPiArICovCj4gPiArdm9p ZCBpbnRlbF9jb25uZWN0b3JfZnJlZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3Ip Cj4gPiArewo+ID4gKwlrZnJlZSh0b19pbnRlbF9kaWdpdGFsX2Nvbm5lY3Rvcl9zdGF0ZShjb25u ZWN0b3ItPmJhc2Uuc3RhdGUpKTsKPiA+ICsJa2ZyZWUoY29ubmVjdG9yKTsKPiA+ICt9Cj4gPiAr Cj4gPiAgLyogU2ltcGxlIGNvbm5lY3Rvci0+Z2V0X2h3X3N0YXRlIGltcGxlbWVudGF0aW9uIGZv ciBlbmNvZGVycyB0aGF0IHN1cHBvcnQgb25seQo+ID4gICAqIG9uZSBjb25uZWN0b3IgYW5kIG5v IGNsb25pbmcgYW5kIGhlbmNlIHRoZSBlbmNvZGVyIHN0YXRlIGRldGVybWluZXMgdGhlIHN0YXRl Cj4gPiAgICogb2YgdGhlIGNvbm5lY3Rvci4gKi8KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw X21zdC5jCj4gPiBpbmRleCBmN2M3ODI1NzYxNjIuLjc3MjUyMTQ0MGE5ZiAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jCj4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYwo+ID4gQEAgLTQ1OCwxMyArNDU4LDIwIEBAIHN0 YXRpYyBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqaW50ZWxfZHBfYWRkX21zdF9jb25uZWN0b3Ioc3Ry dWN0IGRybV9kcF9tc3RfdG9wb2xvCj4gPiAgCXN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmludGVs X2Nvbm5lY3RvcjsKPiA+ICAJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcjsKPiA+ICAJ ZW51bSBwaXBlIHBpcGU7Cj4gPiArCWludCByZXQ7Cj4gPiAgCj4gPiAgCWludGVsX2Nvbm5lY3Rv ciA9IGludGVsX2Nvbm5lY3Rvcl9hbGxvYygpOwo+ID4gIAlpZiAoIWludGVsX2Nvbm5lY3RvcikK PiA+ICAJCXJldHVybiBOVUxMOwo+ID4gIAo+ID4gIAljb25uZWN0b3IgPSAmaW50ZWxfY29ubmVj dG9yLT5iYXNlOwo+ID4gLQlkcm1fY29ubmVjdG9yX2luaXQoZGV2LCBjb25uZWN0b3IsICZpbnRl bF9kcF9tc3RfY29ubmVjdG9yX2Z1bmNzLCBEUk1fTU9ERV9DT05ORUNUT1JfRGlzcGxheVBvcnQp Owo+ID4gKwlyZXQgPSBkcm1fY29ubmVjdG9yX2luaXQoZGV2LCBjb25uZWN0b3IsICZpbnRlbF9k cF9tc3RfY29ubmVjdG9yX2Z1bmNzLAo+ID4gKwkJCQkgRFJNX01PREVfQ09OTkVDVE9SX0Rpc3Bs YXlQb3J0KTsKPiA+ICsJaWYgKHJldCkgewo+ID4gKwkJaW50ZWxfY29ubmVjdG9yX2ZyZWUoaW50 ZWxfY29ubmVjdG9yKTsKPiA+ICsJCXJldHVybiBOVUxMOwo+ID4gKwl9Cj4gPiArCj4gPiAgCWRy bV9jb25uZWN0b3JfaGVscGVyX2FkZChjb25uZWN0b3IsICZpbnRlbF9kcF9tc3RfY29ubmVjdG9y X2hlbHBlcl9mdW5jcyk7Cj4gPiAgCj4gPiAgCWludGVsX2Nvbm5lY3Rvci0+Z2V0X2h3X3N0YXRl ID0gaW50ZWxfZHBfbXN0X2dldF9od19zdGF0ZTsKPiA+IEBAIC00NzIsMTUgKzQ3OSwyNyBAQCBz dGF0aWMgc3RydWN0IGRybV9jb25uZWN0b3IgKmludGVsX2RwX2FkZF9tc3RfY29ubmVjdG9yKHN0 cnVjdCBkcm1fZHBfbXN0X3RvcG9sbwo+ID4gIAlpbnRlbF9jb25uZWN0b3ItPnBvcnQgPSBwb3J0 Owo+ID4gIAo+ID4gIAlmb3JfZWFjaF9waXBlKGRldl9wcml2LCBwaXBlKSB7Cj4gPiAtCQlkcm1f bW9kZV9jb25uZWN0b3JfYXR0YWNoX2VuY29kZXIoJmludGVsX2Nvbm5lY3Rvci0+YmFzZSwKPiA+ IC0JCQkJCQkgICZpbnRlbF9kcC0+bXN0X2VuY29kZXJzW3BpcGVdLT5iYXNlLmJhc2UpOwo+ID4g KwkJc3RydWN0IGRybV9lbmNvZGVyICplbmMgPQo+ID4gKwkJCSZpbnRlbF9kcC0+bXN0X2VuY29k ZXJzW3BpcGVdLT5iYXNlLmJhc2U7Cj4gPiArCj4gPiArCQlyZXQgPSBkcm1fbW9kZV9jb25uZWN0 b3JfYXR0YWNoX2VuY29kZXIoJmludGVsX2Nvbm5lY3Rvci0+YmFzZSwKPiA+ICsJCQkJCQkJZW5j KTsKPiA+ICsJCWlmIChyZXQpCj4gPiArCQkJZ290byBlcnI7Cj4gPiAgCX0KPiA+ICAKPiA+ICAJ ZHJtX29iamVjdF9hdHRhY2hfcHJvcGVydHkoJmNvbm5lY3Rvci0+YmFzZSwgZGV2LT5tb2RlX2Nv bmZpZy5wYXRoX3Byb3BlcnR5LCAwKTsKPiA+ICAJZHJtX29iamVjdF9hdHRhY2hfcHJvcGVydHko JmNvbm5lY3Rvci0+YmFzZSwgZGV2LT5tb2RlX2NvbmZpZy50aWxlX3Byb3BlcnR5LCAwKTsKPiA+ ICAKPiA+IC0JZHJtX21vZGVfY29ubmVjdG9yX3NldF9wYXRoX3Byb3BlcnR5KGNvbm5lY3Rvciwg cGF0aHByb3ApOwo+ID4gKwlyZXQgPSBkcm1fbW9kZV9jb25uZWN0b3Jfc2V0X3BhdGhfcHJvcGVy dHkoY29ubmVjdG9yLCBwYXRocHJvcCk7Cj4gPiArCWlmIChyZXQpCj4gPiArCQlnb3RvIGVycjsK PiA+ICsKPiA+ICAJcmV0dXJuIGNvbm5lY3RvcjsKPiA+ICsKPiA+ICtlcnI6Cj4gPiArCWRybV9j b25uZWN0b3JfY2xlYW51cChjb25uZWN0b3IpOwo+ID4gKwlyZXR1cm4gTlVMTDsKPiA+ICB9Cj4g PiAgCj4gPiAgc3RhdGljIHZvaWQgaW50ZWxfZHBfcmVnaXN0ZXJfbXN0X2Nvbm5lY3RvcihzdHJ1 Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgK PiA+IGluZGV4IGQ2MTk4NWY5M2Q0MC4uZjg2M2EwY2EzOWQ5IDEwMDY0NAo+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rydi5oCj4gPiBAQCAtMTM2Myw2ICsxMzYzLDcgQEAgdm9pZCBpbnRlbF9wcHNf dW5sb2NrX3JlZ3Nfd2Eoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiA+ICB2 b2lkIGludGVsX2VuY29kZXJfZGVzdHJveShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIpOwo+ ID4gIGludCBpbnRlbF9jb25uZWN0b3JfaW5pdChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICopOwo+ ID4gIHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmludGVsX2Nvbm5lY3Rvcl9hbGxvYyh2b2lkKTsK PiA+ICt2b2lkIGludGVsX2Nvbm5lY3Rvcl9mcmVlKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNv bm5lY3Rvcik7Cj4gPiAgYm9vbCBpbnRlbF9jb25uZWN0b3JfZ2V0X2h3X3N0YXRlKHN0cnVjdCBp bnRlbF9jb25uZWN0b3IgKmNvbm5lY3Rvcik7Cj4gPiAgdm9pZCBpbnRlbF9jb25uZWN0b3JfYXR0 YWNoX2VuY29kZXIoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ID4gIAkJCQkg ICAgc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpOwo+ID4gLS0gCj4gPiAyLjE0LjEKPiAK PiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==