From: James Ausmus Subject: Re: [PATCH 08/10] drm/i915: Centralize the SKL DDI A/E vs. B/C/D buf trans handling Date: Wed, 18 Oct 2017 10:21:34 -0700 Message-ID: <20171018172133.GD31581@jausmus-gentoo-dev6.jf.intel.com> References: <20171016145705.11780-1-ville.syrjala@linux.intel.com> <20171016145705.11780-9-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id E33A26E910 for ; Wed, 18 Oct 2017 17:20:52 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171016145705.11780-9-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMTYsIDIwMTcgYXQgMDU6NTc6MDNQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFNLTCBEREkgQi9DL0Qgb25seSBoYXZlIDkgdXNhYmxlIGJ1ZiB0cmFucyByZWdp c3RlcnMgZm9yIERQL2VEUC4gVGhhdAo+IG1hdGNoZXMgdGhlIG5vcm1hbCBEUCBidWYgdHJhbnMg dGFibGVzLCBidXQgdGhlIGxvdyB2c3dpbmcgZURQIHRhYmxlcwo+IGhhdmUgMTAgZW50cmllcy4g VGh1cyB0aGUgZURQIHRhYmxlcyBjYW4gb25seSBiZSB1c2VkIHNhZmVseSB3aXRoIERESSBBCj4g YW5kIEUuCj4gCj4gV2UgdHJ5IHRvIGNhdGNoIGNhc2VzIHdoZXJlIERESSBCL0MvRCBnZXRzIHVz ZWQgd2l0aCB0aGUgd3JvbmcgbnVtYmVyIG9mCj4gZW50aXJlcyBpbiBzb21lIHBhcnRzIG9mIHRo ZSBjb2RlLCBidXQgbm90IGV2ZXJ5d2hlcmUuIExldCdzIG1vdmUgdGhlCj4gY29kZSB0byBkZWFs IHdpdGggdGhhdCBkZWVwZXIgaW50byBpbnRlbF9kZGlfZ2V0X2J1Zl90cmFuc19lZHAoKS4gQW5k Cj4gZm9yIHNha2Ugb2Ygc3ltbWV0cnkgZG8gdGhlIHNhbWUgaW4gaW50ZWxfZGRpX2dldF9idWZf dHJhbnNfZHAoKS4gVGhhdAo+IHdvdWxkIGFsc28gYXZvaWQgZXhwbG9zaW9ucyBpbiB0aGUgcmF0 aGVyIHVubGlrZWx5IGNhc2UgdGhhdCB0aGUgRFAKPiB0YWJsZXMgd291bGQgZ2V0IHJldmlzZWQg dG8gMTAgZW50cmllcyBhcyB3ZWxsLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzD pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogSmFtZXMgQXVz bXVzIDxqYW1lcy5hdXNtdXNAaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGRpLmMgfCA2MCArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0t LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCAyNiBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IGluZGV4IDNiY2U2YmRkZWFhOS4uZjBhNzA5 YjY2ZTAwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBAQCAtNTg3LDE0ICs1ODcs MjkgQEAgc2tsX2dldF9idWZfdHJhbnNfaGRtaShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsIGludCAqbl9lbnRyaWVzKQo+ICAJfQo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50IHNrbF9i dWZfdHJhbnNfbnVtX2VudHJpZXMoZW51bSBwb3J0IHBvcnQsIGludCBuX2VudHJpZXMpCj4gK3sK PiArCS8qIE9ubHkgRERJQSBhbmQgRERJRSBjYW4gc2VsZWN0IHRoZSAxMHRoIHJlZ2lzdGVyIHdp dGggRFAgKi8KPiArCWlmIChwb3J0ID09IFBPUlRfQSB8fCBwb3J0ID09IFBPUlRfRSkKPiArCQly ZXR1cm4gbWluKG5fZW50cmllcywgMTApOwo+ICsJZWxzZQo+ICsJCXJldHVybiBtaW4obl9lbnRy aWVzLCA5KTsKPiArfQo+ICsKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBkZGlfYnVmX3RyYW5zICoK PiAgaW50ZWxfZGRpX2dldF9idWZfdHJhbnNfZHAoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2LAo+IC0JCQkgICBpbnQgKm5fZW50cmllcykKPiArCQkJICAgZW51bSBwb3J0IHBvcnQs IGludCAqbl9lbnRyaWVzKQo+ICB7Cj4gIAlpZiAoSVNfS0FCWUxBS0UoZGV2X3ByaXYpIHx8IElT X0NPRkZFRUxBS0UoZGV2X3ByaXYpKSB7Cj4gLQkJcmV0dXJuIGtibF9nZXRfYnVmX3RyYW5zX2Rw KGRldl9wcml2LCBuX2VudHJpZXMpOwo+ICsJCWNvbnN0IHN0cnVjdCBkZGlfYnVmX3RyYW5zICpk ZGlfdHJhbnNsYXRpb25zID0KPiArCQkJa2JsX2dldF9idWZfdHJhbnNfZHAoZGV2X3ByaXYsIG5f ZW50cmllcyk7Cj4gKwkJKm5fZW50cmllcyA9IHNrbF9idWZfdHJhbnNfbnVtX2VudHJpZXMocG9y dCwgKm5fZW50cmllcyk7Cj4gKwkJcmV0dXJuIGRkaV90cmFuc2xhdGlvbnM7Cj4gIAl9IGVsc2Ug aWYgKElTX1NLWUxBS0UoZGV2X3ByaXYpKSB7Cj4gLQkJcmV0dXJuIHNrbF9nZXRfYnVmX3RyYW5z X2RwKGRldl9wcml2LCBuX2VudHJpZXMpOwo+ICsJCWNvbnN0IHN0cnVjdCBkZGlfYnVmX3RyYW5z ICpkZGlfdHJhbnNsYXRpb25zID0KPiArCQkJc2tsX2dldF9idWZfdHJhbnNfZHAoZGV2X3ByaXYs IG5fZW50cmllcyk7Cj4gKwkJKm5fZW50cmllcyA9IHNrbF9idWZfdHJhbnNfbnVtX2VudHJpZXMo cG9ydCwgKm5fZW50cmllcyk7Cj4gKwkJcmV0dXJuIGRkaV90cmFuc2xhdGlvbnM7Cj4gIAl9IGVs c2UgaWYgKElTX0JST0FEV0VMTChkZXZfcHJpdikpIHsKPiAgCQkqbl9lbnRyaWVzID0gQVJSQVlf U0laRShiZHdfZGRpX3RyYW5zbGF0aW9uc19kcCk7Cj4gIAkJcmV0dXJuICBiZHdfZGRpX3RyYW5z bGF0aW9uc19kcDsKPiBAQCAtNjA5LDEwICs2MjQsMTMgQEAgaW50ZWxfZGRpX2dldF9idWZfdHJh bnNfZHAoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAKPiAgc3RhdGljIGNv bnN0IHN0cnVjdCBkZGlfYnVmX3RyYW5zICoKPiAgaW50ZWxfZGRpX2dldF9idWZfdHJhbnNfZWRw KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkJICAgIGludCAqbl9lbnRy aWVzKQo+ICsJCQkgICAgZW51bSBwb3J0IHBvcnQsIGludCAqbl9lbnRyaWVzKQo+ICB7Cj4gIAlp ZiAoSVNfR0VOOV9CQyhkZXZfcHJpdikpIHsKPiAtCQlyZXR1cm4gc2tsX2dldF9idWZfdHJhbnNf ZWRwKGRldl9wcml2LCBuX2VudHJpZXMpOwo+ICsJCWNvbnN0IHN0cnVjdCBkZGlfYnVmX3RyYW5z ICpkZGlfdHJhbnNsYXRpb25zID0KPiArCQkJc2tsX2dldF9idWZfdHJhbnNfZWRwKGRldl9wcml2 LCBuX2VudHJpZXMpOwo+ICsJCSpuX2VudHJpZXMgPSBza2xfYnVmX3RyYW5zX251bV9lbnRyaWVz KHBvcnQsICpuX2VudHJpZXMpOwo+ICsJCXJldHVybiBkZGlfdHJhbnNsYXRpb25zOwo+ICAJfSBl bHNlIGlmIChJU19CUk9BRFdFTEwoZGV2X3ByaXYpKSB7Cj4gIAkJcmV0dXJuIGJkd19nZXRfYnVm X3RyYW5zX2VkcChkZXZfcHJpdiwgbl9lbnRyaWVzKTsKPiAgCX0gZWxzZSBpZiAoSVNfSEFTV0VM TChkZXZfcHJpdikpIHsKPiBAQCAtODAxLDExICs4MTksMTEgQEAgc3RhdGljIHZvaWQgaW50ZWxf cHJlcGFyZV9kcF9kZGlfYnVmZmVycyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAg Cj4gIAlzd2l0Y2ggKGVuY29kZXItPnR5cGUpIHsKPiAgCWNhc2UgSU5URUxfT1VUUFVUX0VEUDoK PiAtCQlkZGlfdHJhbnNsYXRpb25zID0gaW50ZWxfZGRpX2dldF9idWZfdHJhbnNfZWRwKGRldl9w cml2LAo+ICsJCWRkaV90cmFuc2xhdGlvbnMgPSBpbnRlbF9kZGlfZ2V0X2J1Zl90cmFuc19lZHAo ZGV2X3ByaXYsIHBvcnQsCj4gIAkJCQkJCQkgICAgICAgJm5fZW50cmllcyk7Cj4gIAkJYnJlYWs7 Cj4gIAljYXNlIElOVEVMX09VVFBVVF9EUDoKPiAtCQlkZGlfdHJhbnNsYXRpb25zID0gaW50ZWxf ZGRpX2dldF9idWZfdHJhbnNfZHAoZGV2X3ByaXYsCj4gKwkJZGRpX3RyYW5zbGF0aW9ucyA9IGlu dGVsX2RkaV9nZXRfYnVmX3RyYW5zX2RwKGRldl9wcml2LCBwb3J0LAo+ICAJCQkJCQkJICAgICAg Jm5fZW50cmllcyk7Cj4gIAkJYnJlYWs7Cj4gIAljYXNlIElOVEVMX09VVFBVVF9BTkFMT0c6Cj4g QEAgLTgxNywxNiArODM1LDEwIEBAIHN0YXRpYyB2b2lkIGludGVsX3ByZXBhcmVfZHBfZGRpX2J1 ZmZlcnMoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gIAkJcmV0dXJuOwo+ICAJfQo+ ICAKPiAtCWlmIChJU19HRU45X0JDKGRldl9wcml2KSkgewo+IC0JCS8qIElmIHdlJ3JlIGJvb3N0 aW5nIHRoZSBjdXJyZW50LCBzZXQgYml0IDMxIG9mIHRyYW5zMSAqLwo+IC0JCWlmIChkZXZfcHJp di0+dmJ0LmRkaV9wb3J0X2luZm9bcG9ydF0uZHBfYm9vc3RfbGV2ZWwpCj4gLQkJCWlib29zdF9i aXQgPSBERElfQlVGX0JBTEFOQ0VfTEVHX0VOQUJMRTsKPiAtCj4gLQkJaWYgKFdBUk5fT04oZW5j b2Rlci0+dHlwZSA9PSBJTlRFTF9PVVRQVVRfRURQICYmCj4gLQkJCSAgICBwb3J0ICE9IFBPUlRf QSAmJiBwb3J0ICE9IFBPUlRfRSAmJgo+IC0JCQkgICAgbl9lbnRyaWVzID4gOSkpCj4gLQkJCW5f ZW50cmllcyA9IDk7Cj4gLQl9Cj4gKwkvKiBJZiB3ZSdyZSBib29zdGluZyB0aGUgY3VycmVudCwg c2V0IGJpdCAzMSBvZiB0cmFuczEgKi8KPiArCWlmIChJU19HRU45X0JDKGRldl9wcml2KSAmJgo+ ICsJICAgIGRldl9wcml2LT52YnQuZGRpX3BvcnRfaW5mb1twb3J0XS5kcF9ib29zdF9sZXZlbCkK PiArCQlpYm9vc3RfYml0ID0gRERJX0JVRl9CQUxBTkNFX0xFR19FTkFCTEU7Cj4gIAo+ICAJZm9y IChpID0gMDsgaSA8IG5fZW50cmllczsgaSsrKSB7Cj4gIAkJSTkxNV9XUklURShERElfQlVGX1RS QU5TX0xPKHBvcnQsIGkpLAo+IEBAIC0xODMxLDE0ICsxODQzLDkgQEAgc3RhdGljIHZvaWQgc2ts X2RkaV9zZXRfaWJvb3N0KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJCWlmICh0 eXBlID09IElOVEVMX09VVFBVVF9IRE1JKQo+ICAJCQlkZGlfdHJhbnNsYXRpb25zID0gaW50ZWxf ZGRpX2dldF9idWZfdHJhbnNfaGRtaShkZXZfcHJpdiwgJm5fZW50cmllcyk7Cj4gIAkJZWxzZSBp ZiAodHlwZSA9PSBJTlRFTF9PVVRQVVRfRURQKQo+IC0JCQlkZGlfdHJhbnNsYXRpb25zID0gaW50 ZWxfZGRpX2dldF9idWZfdHJhbnNfZWRwKGRldl9wcml2LCAmbl9lbnRyaWVzKTsKPiArCQkJZGRp X3RyYW5zbGF0aW9ucyA9IGludGVsX2RkaV9nZXRfYnVmX3RyYW5zX2VkcChkZXZfcHJpdiwgcG9y dCwgJm5fZW50cmllcyk7Cj4gIAkJZWxzZQo+IC0JCQlkZGlfdHJhbnNsYXRpb25zID0gaW50ZWxf ZGRpX2dldF9idWZfdHJhbnNfZHAoZGV2X3ByaXYsICZuX2VudHJpZXMpOwo+IC0KPiAtCQlpZiAo V0FSTl9PTih0eXBlICE9IElOVEVMX09VVFBVVF9IRE1JICYmCj4gLQkJCSAgICBwb3J0ICE9IFBP UlRfQSAmJgo+IC0JCQkgICAgcG9ydCAhPSBQT1JUX0UgJiYgbl9lbnRyaWVzID4gOSkpCj4gLQkJ CW5fZW50cmllcyA9IDk7Cj4gKwkJCWRkaV90cmFuc2xhdGlvbnMgPSBpbnRlbF9kZGlfZ2V0X2J1 Zl90cmFuc19kcChkZXZfcHJpdiwgcG9ydCwgJm5fZW50cmllcyk7Cj4gIAo+ICAJCWlib29zdCA9 IGRkaV90cmFuc2xhdGlvbnNbbGV2ZWxdLmlfYm9vc3Q7Cj4gIAl9Cj4gQEAgLTE4ODAsNiArMTg4 Nyw3IEBAIHN0YXRpYyB2b2lkIGJ4dF9kZGlfdnN3aW5nX3NlcXVlbmNlKHN0cnVjdCBpbnRlbF9l bmNvZGVyICplbmNvZGVyLAo+ICB1OCBpbnRlbF9kZGlfZHBfdm9sdGFnZV9tYXgoc3RydWN0IGlu dGVsX2VuY29kZXIgKmVuY29kZXIpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYpOwo+ICsJZW51bSBwb3J0IHBvcnQg PSBlbmNvZGVyLT5wb3J0Owo+ICAJaW50IG5fZW50cmllczsKPiAgCj4gIAlpZiAoSVNfQ0FOTk9O TEFLRShkZXZfcHJpdikpIHsKPiBAQCAtMTg5NCw5ICsxOTAyLDkgQEAgdTggaW50ZWxfZGRpX2Rw X3ZvbHRhZ2VfbWF4KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+ICAJCQlieHRfZ2V0 X2J1Zl90cmFuc19kcChkZXZfcHJpdiwgJm5fZW50cmllcyk7Cj4gIAl9IGVsc2Ugewo+ICAJCWlm IChlbmNvZGVyLT50eXBlID09IElOVEVMX09VVFBVVF9FRFApCj4gLQkJCWludGVsX2RkaV9nZXRf YnVmX3RyYW5zX2VkcChkZXZfcHJpdiwgJm5fZW50cmllcyk7Cj4gKwkJCWludGVsX2RkaV9nZXRf YnVmX3RyYW5zX2VkcChkZXZfcHJpdiwgcG9ydCwgJm5fZW50cmllcyk7Cj4gIAkJZWxzZQo+IC0J CQlpbnRlbF9kZGlfZ2V0X2J1Zl90cmFuc19kcChkZXZfcHJpdiwgJm5fZW50cmllcyk7Cj4gKwkJ CWludGVsX2RkaV9nZXRfYnVmX3RyYW5zX2RwKGRldl9wcml2LCBwb3J0LCAmbl9lbnRyaWVzKTsK PiAgCX0KPiAgCj4gIAlpZiAoV0FSTl9PTihuX2VudHJpZXMgPCAxKSkKPiAtLSAKPiAyLjEzLjYK PiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IElu dGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==