From: James Ausmus Subject: Re: [PATCH 10/10] drm/i915: Drop the redundant hdmi prefix/suffix from a lot of variables Date: Wed, 18 Oct 2017 10:43:54 -0700 Message-ID: <20171018174353.GF31581@jausmus-gentoo-dev6.jf.intel.com> References: <20171016145705.11780-1-ville.syrjala@linux.intel.com> <20171016145705.11780-11-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4B5E6E91B for ; Wed, 18 Oct 2017 17:43:12 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171016145705.11780-11-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMTYsIDIwMTcgYXQgMDU6NTc6MDVQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IEEgYnVuY2ggb2YgZnVuY3Rpb25zIGFyZSBub3cgZXhjbHVzaXZlbHkgdXNlZCBm b3IgSERNSSwgc28gbmFtaW5nIHRoZQo+IHZhcmlhYmxlcyB3aXRoIGhkbWkgcHJlZml4L3N1ZmZp eCBpcyByZWR1bmRhbnQuIEFsc28gdXNlIGludCByYXRoZXIKPiB0aGFuIHUzMiBmb3IgdGhlIHRy YW5zbGF0aW9uIGxldmVsIGNvbnNpc3RlbnRseS4KCklzIHRoZXJlIGEgY2FzZSBmb3IgbGV2ZWwg dG8gYmUgbmVnYXRpdmUsIGV2ZXI/IElmIG5vdCwga2VlcGluZyBpdCB1MzIKY291bGQgaGVscCBj YXRjaCBjYXNlcyB3aGVyZSB3ZSBhY2NpZGVudGx5IHRyeSB0byBzZXQgbGV2ZWwgdG8gLTEuCgo+ IAo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIHwgNjEg KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMjkgaW5zZXJ0aW9ucygrKSwgMzIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGRpLmMKPiBpbmRleCA1ZjFjNTQ2ZTVlNjEuLmNkNTUwYWFiMzMyYiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RkaS5jCj4gQEAgLTc3MCw0MSArNzcwLDM4IEBAIGNubF9nZXRfYnVmX3Ry YW5zX2VkcChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGludCAqbl9lbnRyaWVz KQo+ICAKPiAgc3RhdGljIGludCBpbnRlbF9kZGlfaGRtaV9sZXZlbChzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcG9ydCBwb3J0KQo+ICB7Cj4gLQlpbnQgbl9oZG1pX2Vu dHJpZXM7Cj4gLQlpbnQgaGRtaV9sZXZlbDsKPiAtCWludCBoZG1pX2RlZmF1bHRfZW50cnk7Cj4g KwlpbnQgbl9lbnRyaWVzLCBsZXZlbCwgZGVmYXVsdF9lbnRyeTsKPiAgCj4gLQloZG1pX2xldmVs ID0gZGV2X3ByaXYtPnZidC5kZGlfcG9ydF9pbmZvW3BvcnRdLmhkbWlfbGV2ZWxfc2hpZnQ7Cj4g KwlsZXZlbCA9IGRldl9wcml2LT52YnQuZGRpX3BvcnRfaW5mb1twb3J0XS5oZG1pX2xldmVsX3No aWZ0Owo+ICAKPiAgCWlmIChJU19DQU5OT05MQUtFKGRldl9wcml2KSkgewo+IC0JCWNubF9nZXRf YnVmX3RyYW5zX2hkbWkoZGV2X3ByaXYsICZuX2hkbWlfZW50cmllcyk7Cj4gLQkJaGRtaV9kZWZh dWx0X2VudHJ5ID0gbl9oZG1pX2VudHJpZXMgLSAxOwo+ICsJCWNubF9nZXRfYnVmX3RyYW5zX2hk bWkoZGV2X3ByaXYsICZuX2VudHJpZXMpOwo+ICsJCWRlZmF1bHRfZW50cnkgPSBuX2VudHJpZXMg LSAxOwo+ICAJfSBlbHNlIGlmIChJU19HRU45X0xQKGRldl9wcml2KSkgewo+IC0JCWJ4dF9nZXRf YnVmX3RyYW5zX2hkbWkoZGV2X3ByaXYsICZuX2hkbWlfZW50cmllcyk7Cj4gLQkJaGRtaV9kZWZh dWx0X2VudHJ5ID0gbl9oZG1pX2VudHJpZXMgLSAxOwo+ICsJCWJ4dF9nZXRfYnVmX3RyYW5zX2hk bWkoZGV2X3ByaXYsICZuX2VudHJpZXMpOwo+ICsJCWRlZmF1bHRfZW50cnkgPSBuX2VudHJpZXMg LSAxOwo+ICAJfSBlbHNlIGlmIChJU19HRU45X0JDKGRldl9wcml2KSkgewo+IC0JCWludGVsX2Rk aV9nZXRfYnVmX3RyYW5zX2hkbWkoZGV2X3ByaXYsICZuX2hkbWlfZW50cmllcyk7Cj4gLQkJaGRt aV9kZWZhdWx0X2VudHJ5ID0gODsKPiArCQlpbnRlbF9kZGlfZ2V0X2J1Zl90cmFuc19oZG1pKGRl dl9wcml2LCAmbl9lbnRyaWVzKTsKPiArCQlkZWZhdWx0X2VudHJ5ID0gODsKPiAgCX0gZWxzZSBp ZiAoSVNfQlJPQURXRUxMKGRldl9wcml2KSkgewo+IC0JCWludGVsX2RkaV9nZXRfYnVmX3RyYW5z X2hkbWkoZGV2X3ByaXYsICZuX2hkbWlfZW50cmllcyk7Cj4gLQkJaGRtaV9kZWZhdWx0X2VudHJ5 ID0gNzsKPiArCQlpbnRlbF9kZGlfZ2V0X2J1Zl90cmFuc19oZG1pKGRldl9wcml2LCAmbl9lbnRy aWVzKTsKPiArCQlkZWZhdWx0X2VudHJ5ID0gNzsKPiAgCX0gZWxzZSBpZiAoSVNfSEFTV0VMTChk ZXZfcHJpdikpIHsKPiAtCQlpbnRlbF9kZGlfZ2V0X2J1Zl90cmFuc19oZG1pKGRldl9wcml2LCAm bl9oZG1pX2VudHJpZXMpOwo+IC0JCWhkbWlfZGVmYXVsdF9lbnRyeSA9IDY7Cj4gKwkJaW50ZWxf ZGRpX2dldF9idWZfdHJhbnNfaGRtaShkZXZfcHJpdiwgJm5fZW50cmllcyk7Cj4gKwkJZGVmYXVs dF9lbnRyeSA9IDY7Cj4gIAl9IGVsc2Ugewo+ICAJCVdBUk4oMSwgImRkaSB0cmFuc2xhdGlvbiB0 YWJsZSBtaXNzaW5nXG4iKTsKPiAgCQlyZXR1cm4gMDsKPiAgCX0KPiAgCj4gIAkvKiBDaG9vc2Ug YSBnb29kIGRlZmF1bHQgaWYgVkJUIGlzIGJhZGx5IHBvcHVsYXRlZCAqLwo+IC0JaWYgKGhkbWlf bGV2ZWwgPT0gSERNSV9MRVZFTF9TSElGVF9VTktOT1dOIHx8Cj4gLQkgICAgaGRtaV9sZXZlbCA+ PSBuX2hkbWlfZW50cmllcykKPiAtCQloZG1pX2xldmVsID0gaGRtaV9kZWZhdWx0X2VudHJ5Owo+ ICsJaWYgKGxldmVsID09IEhETUlfTEVWRUxfU0hJRlRfVU5LTk9XTiB8fCBsZXZlbCA+PSBuX2Vu dHJpZXMpCj4gKwkJbGV2ZWwgPSBkZWZhdWx0X2VudHJ5Owo+ICAKPiAtCWlmIChXQVJOX09OX09O Q0UoaGRtaV9sZXZlbCA+PSBuX2hkbWlfZW50cmllcykpCj4gLQkJaGRtaV9sZXZlbCA9IG5faGRt aV9lbnRyaWVzIC0gMTsKPiArCWlmIChXQVJOX09OX09OQ0UobGV2ZWwgPj0gbl9lbnRyaWVzKSkK PiArCQlsZXZlbCA9IG5fZW50cmllcyAtIDE7Cj4gIAo+IC0JcmV0dXJuIGhkbWlfbGV2ZWw7Cj4g KwlyZXR1cm4gbGV2ZWw7Cj4gIH0KPiAgCj4gIC8qCj4gQEAgLTg1NywyMCArODU0LDIwIEBAIHN0 YXRpYyB2b2lkIGludGVsX3ByZXBhcmVfZHBfZGRpX2J1ZmZlcnMoc3RydWN0IGludGVsX2VuY29k ZXIgKmVuY29kZXIpCj4gICAqIEhETUkvRFZJIHVzZSBjYXNlcy4KPiAgICovCj4gIHN0YXRpYyB2 b2lkIGludGVsX3ByZXBhcmVfaGRtaV9kZGlfYnVmZmVycyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAq ZW5jb2RlciwKPiAtCQkJCQkgICBpbnQgaGRtaV9sZXZlbCkKPiArCQkJCQkgICBpbnQgbGV2ZWwp Cj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZW5j b2Rlci0+YmFzZS5kZXYpOwo+ICAJdTMyIGlib29zdF9iaXQgPSAwOwo+IC0JaW50IG5faGRtaV9l bnRyaWVzOwo+ICsJaW50IG5fZW50cmllczsKPiAgCWVudW0gcG9ydCBwb3J0ID0gaW50ZWxfZGRp X2dldF9lbmNvZGVyX3BvcnQoZW5jb2Rlcik7Cj4gLQljb25zdCBzdHJ1Y3QgZGRpX2J1Zl90cmFu cyAqZGRpX3RyYW5zbGF0aW9uc19oZG1pOwo+ICsJY29uc3Qgc3RydWN0IGRkaV9idWZfdHJhbnMg KmRkaV90cmFuc2xhdGlvbnM7Cj4gIAo+IC0JZGRpX3RyYW5zbGF0aW9uc19oZG1pID0gaW50ZWxf ZGRpX2dldF9idWZfdHJhbnNfaGRtaShkZXZfcHJpdiwgJm5faGRtaV9lbnRyaWVzKTsKPiArCWRk aV90cmFuc2xhdGlvbnMgPSBpbnRlbF9kZGlfZ2V0X2J1Zl90cmFuc19oZG1pKGRldl9wcml2LCAm bl9lbnRyaWVzKTsKPiAgCj4gLQlpZiAoV0FSTl9PTl9PTkNFKCFkZGlfdHJhbnNsYXRpb25zX2hk bWkpKQo+ICsJaWYgKFdBUk5fT05fT05DRSghZGRpX3RyYW5zbGF0aW9ucykpCj4gIAkJcmV0dXJu Owo+IC0JaWYgKFdBUk5fT05fT05DRShoZG1pX2xldmVsID49IG5faGRtaV9lbnRyaWVzKSkKPiAt CQloZG1pX2xldmVsID0gbl9oZG1pX2VudHJpZXMgLSAxOwo+ICsJaWYgKFdBUk5fT05fT05DRShs ZXZlbCA+PSBuX2VudHJpZXMpKQo+ICsJCWxldmVsID0gbl9lbnRyaWVzIC0gMTsKPiAgCj4gIAkv KiBJZiB3ZSdyZSBib29zdGluZyB0aGUgY3VycmVudCwgc2V0IGJpdCAzMSBvZiB0cmFuczEgKi8K PiAgCWlmIChJU19HRU45X0JDKGRldl9wcml2KSAmJgo+IEBAIC04NzksOSArODc2LDkgQEAgc3Rh dGljIHZvaWQgaW50ZWxfcHJlcGFyZV9oZG1pX2RkaV9idWZmZXJzKHN0cnVjdCBpbnRlbF9lbmNv ZGVyICplbmNvZGVyLAo+ICAKPiAgCS8qIEVudHJ5IDkgaXMgZm9yIEhETUk6ICovCj4gIAlJOTE1 X1dSSVRFKERESV9CVUZfVFJBTlNfTE8ocG9ydCwgOSksCj4gLQkJICAgZGRpX3RyYW5zbGF0aW9u c19oZG1pW2hkbWlfbGV2ZWxdLnRyYW5zMSB8IGlib29zdF9iaXQpOwo+ICsJCSAgIGRkaV90cmFu c2xhdGlvbnNbbGV2ZWxdLnRyYW5zMSB8IGlib29zdF9iaXQpOwo+ICAJSTkxNV9XUklURShERElf QlVGX1RSQU5TX0hJKHBvcnQsIDkpLAo+IC0JCSAgIGRkaV90cmFuc2xhdGlvbnNfaGRtaVtoZG1p X2xldmVsXS50cmFuczIpOwo+ICsJCSAgIGRkaV90cmFuc2xhdGlvbnNbbGV2ZWxdLnRyYW5zMik7 Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGludGVsX3dhaXRfZGRpX2J1Zl9pZGxlKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiBAQCAtMjA5NCw3ICsyMDkxLDcgQEAgdTMyIGJ4 dF9zaWduYWxfbGV2ZWxzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAlzdHJ1Y3QgaW50 ZWxfZGlnaXRhbF9wb3J0ICpkcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsKPiAgCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZHBvcnQtPmJhc2UuYmFz ZS5kZXYpOwo+ICAJc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIgPSAmZHBvcnQtPmJhc2U7 Cj4gLQl1MzIgbGV2ZWwgPSBpbnRlbF9kZGlfZHBfbGV2ZWwoaW50ZWxfZHApOwo+ICsJaW50IGxl dmVsID0gaW50ZWxfZGRpX2RwX2xldmVsKGludGVsX2RwKTsKPiAgCj4gIAlpZiAoSVNfQ0FOTk9O TEFLRShkZXZfcHJpdikpCj4gIAkJY25sX2RkaV92c3dpbmdfc2VxdWVuY2UoZW5jb2RlciwgbGV2 ZWwsIGVuY29kZXItPnR5cGUpOwo+IEBAIC0yMTA5LDcgKzIxMDYsNyBAQCB1aW50MzJfdCBkZGlf c2lnbmFsX2xldmVscyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJc3RydWN0IGludGVs X2RpZ2l0YWxfcG9ydCAqZHBvcnQgPSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gIAlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRwb3J0LT5iYXNlLmJhc2Uu ZGV2KTsKPiAgCXN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyID0gJmRwb3J0LT5iYXNlOwo+ IC0JdWludDMyX3QgbGV2ZWwgPSBpbnRlbF9kZGlfZHBfbGV2ZWwoaW50ZWxfZHApOwo+ICsJaW50 IGxldmVsID0gaW50ZWxfZGRpX2RwX2xldmVsKGludGVsX2RwKTsKPiAgCj4gIAlpZiAoSVNfR0VO OV9CQyhkZXZfcHJpdikpCj4gIAkJc2tsX2RkaV9zZXRfaWJvb3N0KGVuY29kZXIsIGxldmVsLCBl bmNvZGVyLT50eXBlKTsKPiBAQCAtMjE4Miw3ICsyMTc5LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxf ZGRpX3ByZV9lbmFibGVfZHAoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAllbnVt IHBvcnQgcG9ydCA9IGludGVsX2RkaV9nZXRfZW5jb2Rlcl9wb3J0KGVuY29kZXIpOwo+ICAJc3Ry dWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPSBlbmNfdG9fZGlnX3BvcnQoJmVuY29k ZXItPmJhc2UpOwo+ICAJYm9vbCBpc19tc3QgPSBpbnRlbF9jcnRjX2hhc190eXBlKGNydGNfc3Rh dGUsIElOVEVMX09VVFBVVF9EUF9NU1QpOwo+IC0JdWludDMyX3QgbGV2ZWwgPSBpbnRlbF9kZGlf ZHBfbGV2ZWwoaW50ZWxfZHApOwo+ICsJaW50IGxldmVsID0gaW50ZWxfZGRpX2RwX2xldmVsKGlu dGVsX2RwKTsKPiAgCj4gIAlXQVJOX09OKGlzX21zdCAmJiAocG9ydCA9PSBQT1JUX0EgfHwgcG9y dCA9PSBQT1JUX0UpKTsKPiAgCj4gLS0gCj4gMi4xMy42Cj4gCj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4g SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=