From: James Ausmus Subject: Re: [PATCH 02/10] drm/i915: Extract intel_ddi_get_buf_trans_hdmi() Date: Wed, 18 Oct 2017 10:50:15 -0700 Message-ID: <20171018175014.GG31581@jausmus-gentoo-dev6.jf.intel.com> References: <20171016145705.11780-1-ville.syrjala@linux.intel.com> <20171016145705.11780-3-ville.syrjala@linux.intel.com> <20171018170924.GN10981@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id C2F826E91F for ; Wed, 18 Oct 2017 17:49:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171018170924.GN10981@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMTgsIDIwMTcgYXQgMDg6MDk6MjRQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIE1vbiwgT2N0IDE2LCAyMDE3IGF0IDA0OjQxOjQ5UE0gLTA3MDAsIEF1c211 cywgSmFtZXMgd3JvdGU6Cj4gPiBPbiBNb24sIE9jdCAxNiwgMjAxNyBhdCA3OjU2IEFNLCBWaWxs ZSBTeXJqYWxhCj4gPiA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4g PiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ ID4gPgo+ID4gPiBJbnRyb2R1Y2UgaW50ZWxfZGRpX2dldF9idWZfdHJhbnNfaGRtaSgpIGFuZCBz dGFydCB1c2luZyBpdCB3aGVyZSB3ZQo+ID4gPiBjYW4uCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYt Ynk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgfCA1MCArKysrKysr KysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwg MjggaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCj4gPiA+Cj4gPiA+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RkaS5jCj4gPiA+IGluZGV4IDU1OTM3YWJkYTYxZi4uZTZjODg0YTZkNDA4IDEwMDY0 NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gPiBAQCAtNjQxLDYgKzY0MSwy NCBAQCBpbnRlbF9kZGlfZ2V0X2J1Zl90cmFuc19mZGkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LAo+ID4gPiAgICAgICAgIHJldHVybiBOVUxMOwo+ID4gPiAgfQo+ID4gPgo+ID4g PiArc3RhdGljIGNvbnN0IHN0cnVjdCBkZGlfYnVmX3RyYW5zICoKPiA+ID4gK2ludGVsX2RkaV9n ZXRfYnVmX3RyYW5zX2hkbWkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCAqbl9lbnRyaWVzKQo+ID4gPiArewo+ ID4gPiArICAgICAgIGlmIChJU19HRU45X0JDKGRldl9wcml2KSkgewo+ID4gPiArICAgICAgICAg ICAgICAgcmV0dXJuIHNrbF9nZXRfYnVmX3RyYW5zX2hkbWkoZGV2X3ByaXYsIG5fZW50cmllcyk7 Cj4gPiA+ICsgICAgICAgfSBlbHNlIGlmIChJU19CUk9BRFdFTEwoZGV2X3ByaXYpKSB7Cj4gPiA+ ICsgICAgICAgICAgICAgICAqbl9lbnRyaWVzID0gQVJSQVlfU0laRShiZHdfZGRpX3RyYW5zbGF0 aW9uc19oZG1pKTsKPiA+ID4gKyAgICAgICAgICAgICAgIHJldHVybiBiZHdfZGRpX3RyYW5zbGF0 aW9uc19oZG1pOwo+ID4gPiArICAgICAgIH0gZWxzZSBpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikp IHsKPiA+ID4gKyAgICAgICAgICAgICAgICpuX2VudHJpZXMgPSBBUlJBWV9TSVpFKGhzd19kZGlf dHJhbnNsYXRpb25zX2hkbWkpOwo+ID4gPiArICAgICAgICAgICAgICAgcmV0dXJuIGhzd19kZGlf dHJhbnNsYXRpb25zX2hkbWk7Cj4gPiA+ICsgICAgICAgfQo+ID4gPiArCj4gPiA+ICsgICAgICAg Km5fZW50cmllcyA9IDA7Cj4gPiA+ICsgICAgICAgcmV0dXJuIE5VTEw7Cj4gPiA+ICt9Cj4gPiA+ ICsKPiA+ID4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgY25sX2RkaV9idWZfdHJhbnMgKgo+ID4gPiAg Y25sX2dldF9idWZfdHJhbnNfaGRtaShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs IGludCAqbl9lbnRyaWVzKQo+ID4gPiAgewo+ID4gPiBAQCAtNzIzLDE4ICs3NDEsMTcgQEAgc3Rh dGljIGludCBpbnRlbF9kZGlfaGRtaV9sZXZlbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsIGVudW0gcG9ydCBwb3IKPiA+ID4gICAgICAgICAgICAgICAgIGNubF9nZXRfYnVmX3Ry YW5zX2hkbWkoZGV2X3ByaXYsICZuX2hkbWlfZW50cmllcyk7Cj4gPiA+ICAgICAgICAgICAgICAg ICBoZG1pX2RlZmF1bHRfZW50cnkgPSBuX2hkbWlfZW50cmllcyAtIDE7Cj4gPiAKPiA+IFdoeSBh cmUgeW91IHNraXBwaW5nIHRoZSBDTkwgY2FzZT8gSWYgeW91IGV4dHJhY3QgaXQgaW4gdG8KPiA+ IGludGVsX2RkaV9nZXRfYnVmX3RyYW5zX2hkbWkgYXMgd2VsbCwgeW91IGNvdWxkIGp1c3QKPiA+ IHVuY29uZGl0aW9uYWxseSBjYWxsIGludGVsX2RkaV9nZXRfYnVmX3RyYW5zX2hkbWksIGFuZCBq dXN0IHNldAo+ID4gaGRtaV9kZWZhdWx0X2VudHJ5IGluIHRoZSBwbGF0Zm9ybS1zcGVjaWZpYyBz ZWN0aW9uLgo+IAo+IFRoZSBwcm9ibGVtIGlzIHRoYXQgQ05MIChhbmQgQlhUKSB1c2UgYSBkaWZm ZXJlbnQgc3RydWN0dXJlIGZvciB0aGVpcgo+IGJ1ZiB0cmFucyB2YWx1ZXMuIFNvIGZhciBJJ3Zl IG5vdCBib3RoZXJlZCB0byBjaGVjayBpZiB3ZSBjb3VsZCBjaGFuZ2UKPiB0aGVtIHRvIHVzZSB0 aGUgSFNXKyBzdHJ1Y3R1cmUuIEkgZ3Vlc3MgdGhlIG90aGVyIG9wdGlvbnMgd291bGQgYmUgdG8K PiBzbGFwIGEgdW5pb24gaW50byB0aGUgc3RydWN0dXJlLCBvciBtYWtlIHRoZXNlIGZ1bmN0aW9u cyByZXR1cm4KPiB2b2lkICosIGJ1dCBuZWl0aGVyIG9wdGlvbiBzZWVtcyB2ZXJ5IGFwcGVhbGlu ZyBzaW5jZSB3ZSdkIGxvc2Ugc29tZQo+IHR5cGUgc2FmZXR5LgoKQWggeWVzIC0gaGFkbid0IG5v dGljZWQgdGhlIHJldHVybiB0eXBlcywgYXMgdGhleSdyZSBub3QgdXNlZCBoZXJlIC0KdGhhbmtz IGZvciBleHBsYWluaW5nLgoKUmV2aWV3ZWQtYnk6IEphbWVzIEF1c211cyA8amFtZXMuYXVzbXVz QGludGVsLmNvbT4KCj4gCj4gSW4gYW55IGNhc2UgdGhhdCdkIGJlIG1hdGVyaWFsIGZvciBmb2xs b3d1cCB3b3JrLiBNYXliZSBzb21lb25lIGVsc2UKPiBjb3VsZCB0YWtlIGEgbG9vayBhdCBpdD8g OykKPiAKPiA+IAo+ID4gPiAgICAgICAgIH0gZWxzZSBpZiAoSVNfR0VOOV9CQyhkZXZfcHJpdikp IHsKPiA+ID4gLSAgICAgICAgICAgICAgIHNrbF9nZXRfYnVmX3RyYW5zX2hkbWkoZGV2X3ByaXYs ICZuX2hkbWlfZW50cmllcyk7Cj4gPiA+ICsgICAgICAgICAgICAgICBpbnRlbF9kZGlfZ2V0X2J1 Zl90cmFuc19oZG1pKGRldl9wcml2LCAmbl9oZG1pX2VudHJpZXMpOwo+ID4gPiAgICAgICAgICAg ICAgICAgaGRtaV9kZWZhdWx0X2VudHJ5ID0gODsKPiA+ID4gICAgICAgICB9IGVsc2UgaWYgKElT X0JST0FEV0VMTChkZXZfcHJpdikpIHsKPiA+ID4gLSAgICAgICAgICAgICAgIG5faGRtaV9lbnRy aWVzID0gQVJSQVlfU0laRShiZHdfZGRpX3RyYW5zbGF0aW9uc19oZG1pKTsKPiA+ID4gKyAgICAg ICAgICAgICAgIGludGVsX2RkaV9nZXRfYnVmX3RyYW5zX2hkbWkoZGV2X3ByaXYsICZuX2hkbWlf ZW50cmllcyk7Cj4gPiA+ICAgICAgICAgICAgICAgICBoZG1pX2RlZmF1bHRfZW50cnkgPSA3Owo+ ID4gPiAgICAgICAgIH0gZWxzZSBpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikpIHsKPiA+ID4gLSAg ICAgICAgICAgICAgIG5faGRtaV9lbnRyaWVzID0gQVJSQVlfU0laRShoc3dfZGRpX3RyYW5zbGF0 aW9uc19oZG1pKTsKPiA+ID4gKyAgICAgICAgICAgICAgIGludGVsX2RkaV9nZXRfYnVmX3RyYW5z X2hkbWkoZGV2X3ByaXYsICZuX2hkbWlfZW50cmllcyk7Cj4gPiA+ICAgICAgICAgICAgICAgICBo ZG1pX2RlZmF1bHRfZW50cnkgPSA2Owo+ID4gPiAgICAgICAgIH0gZWxzZSB7Cj4gPiA+ICAgICAg ICAgICAgICAgICBXQVJOKDEsICJkZGkgdHJhbnNsYXRpb24gdGFibGUgbWlzc2luZ1xuIik7Cj4g PiA+IC0gICAgICAgICAgICAgICBuX2hkbWlfZW50cmllcyA9IEFSUkFZX1NJWkUoYmR3X2RkaV90 cmFuc2xhdGlvbnNfaGRtaSk7Cj4gPiA+IC0gICAgICAgICAgICAgICBoZG1pX2RlZmF1bHRfZW50 cnkgPSA3Owo+ID4gPiArICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4gPiA+ICAgICAgICAgfQo+ ID4gPgo+ID4gPiAgICAgICAgIC8qIENob29zZSBhIGdvb2QgZGVmYXVsdCBpZiBWQlQgaXMgYmFk bHkgcG9wdWxhdGVkICovCj4gPiA+IEBAIC04MTAsMjMgKzgyNywxMiBAQCBzdGF0aWMgdm9pZCBp bnRlbF9wcmVwYXJlX2hkbWlfZGRpX2J1ZmZlcnMoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29k ZXIpCj4gPiA+Cj4gPiA+ICAgICAgICAgaGRtaV9sZXZlbCA9IGludGVsX2RkaV9oZG1pX2xldmVs KGRldl9wcml2LCBwb3J0KTsKPiA+ID4KPiA+ID4gLSAgICAgICBpZiAoSVNfR0VOOV9CQyhkZXZf cHJpdikpIHsKPiA+ID4gLSAgICAgICAgICAgICAgIGRkaV90cmFuc2xhdGlvbnNfaGRtaSA9IHNr bF9nZXRfYnVmX3RyYW5zX2hkbWkoZGV2X3ByaXYsICZuX2hkbWlfZW50cmllcyk7Cj4gPiA+ICsg ICAgICAgZGRpX3RyYW5zbGF0aW9uc19oZG1pID0gaW50ZWxfZGRpX2dldF9idWZfdHJhbnNfaGRt aShkZXZfcHJpdiwgJm5faGRtaV9lbnRyaWVzKTsKPiA+ID4KPiA+ID4gLSAgICAgICAgICAgICAg IC8qIElmIHdlJ3JlIGJvb3N0aW5nIHRoZSBjdXJyZW50LCBzZXQgYml0IDMxIG9mIHRyYW5zMSAq Lwo+ID4gPiAtICAgICAgICAgICAgICAgaWYgKGRldl9wcml2LT52YnQuZGRpX3BvcnRfaW5mb1tw b3J0XS5oZG1pX2Jvb3N0X2xldmVsKQo+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgICBpYm9v c3RfYml0ID0gRERJX0JVRl9CQUxBTkNFX0xFR19FTkFCTEU7Cj4gPiA+IC0gICAgICAgfSBlbHNl IGlmIChJU19CUk9BRFdFTEwoZGV2X3ByaXYpKSB7Cj4gPiA+IC0gICAgICAgICAgICAgICBkZGlf dHJhbnNsYXRpb25zX2hkbWkgPSBiZHdfZGRpX3RyYW5zbGF0aW9uc19oZG1pOwo+ID4gPiAtICAg ICAgICAgICAgICAgbl9oZG1pX2VudHJpZXMgPSBBUlJBWV9TSVpFKGJkd19kZGlfdHJhbnNsYXRp b25zX2hkbWkpOwo+ID4gPiAtICAgICAgIH0gZWxzZSBpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikp IHsKPiA+ID4gLSAgICAgICAgICAgICAgIGRkaV90cmFuc2xhdGlvbnNfaGRtaSA9IGhzd19kZGlf dHJhbnNsYXRpb25zX2hkbWk7Cj4gPiA+IC0gICAgICAgICAgICAgICBuX2hkbWlfZW50cmllcyA9 IEFSUkFZX1NJWkUoaHN3X2RkaV90cmFuc2xhdGlvbnNfaGRtaSk7Cj4gPiA+IC0gICAgICAgfSBl bHNlIHsKPiA+ID4gLSAgICAgICAgICAgICAgIFdBUk4oMSwgImRkaSB0cmFuc2xhdGlvbiB0YWJs ZSBtaXNzaW5nXG4iKTsKPiA+ID4gLSAgICAgICAgICAgICAgIGRkaV90cmFuc2xhdGlvbnNfaGRt aSA9IGJkd19kZGlfdHJhbnNsYXRpb25zX2hkbWk7Cj4gPiA+IC0gICAgICAgICAgICAgICBuX2hk bWlfZW50cmllcyA9IEFSUkFZX1NJWkUoYmR3X2RkaV90cmFuc2xhdGlvbnNfaGRtaSk7Cj4gPiA+ IC0gICAgICAgfQo+ID4gPiArICAgICAgIC8qIElmIHdlJ3JlIGJvb3N0aW5nIHRoZSBjdXJyZW50 LCBzZXQgYml0IDMxIG9mIHRyYW5zMSAqLwo+ID4gPiArICAgICAgIGlmIChJU19HRU45X0JDKGRl dl9wcml2KSAmJgo+ID4gPiArICAgICAgICAgICBkZXZfcHJpdi0+dmJ0LmRkaV9wb3J0X2luZm9b cG9ydF0uaGRtaV9ib29zdF9sZXZlbCkKPiA+ID4gKyAgICAgICAgICAgICAgIGlib29zdF9iaXQg PSBERElfQlVGX0JBTEFOQ0VfTEVHX0VOQUJMRTsKPiA+ID4KPiA+ID4gICAgICAgICAvKiBFbnRy eSA5IGlzIGZvciBIRE1JOiAqLwo+ID4gPiAgICAgICAgIEk5MTVfV1JJVEUoRERJX0JVRl9UUkFO U19MTyhwb3J0LCA5KSwKPiA+ID4gQEAgLTE4MjAsNyArMTgyNiw3IEBAIHN0YXRpYyB2b2lkIHNr bF9kZGlfc2V0X2lib29zdChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwgdTMyIGxldmVs KQo+ID4gPiAgICAgICAgICAgICAgICAgaWYgKGhkbWlfaWJvb3N0KSB7Cj4gPiA+ICAgICAgICAg ICAgICAgICAgICAgICAgIGlib29zdCA9IGhkbWlfaWJvb3N0Owo+ID4gPiAgICAgICAgICAgICAg ICAgfSBlbHNlIHsKPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgZGRpX3RyYW5zbGF0aW9u cyA9IHNrbF9nZXRfYnVmX3RyYW5zX2hkbWkoZGV2X3ByaXYsICZuX2VudHJpZXMpOwo+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgICBkZGlfdHJhbnNsYXRpb25zID0gaW50ZWxfZGRpX2dldF9i dWZfdHJhbnNfaGRtaShkZXZfcHJpdiwgJm5fZW50cmllcyk7Cj4gPiA+ICAgICAgICAgICAgICAg ICAgICAgICAgIGlib29zdCA9IGRkaV90cmFuc2xhdGlvbnNbbGV2ZWxdLmlfYm9vc3Q7Cj4gPiA+ ICAgICAgICAgICAgICAgICB9Cj4gPiA+ICAgICAgICAgfSBlbHNlIHsKPiA+ID4gLS0KPiA+ID4g Mi4xMy42Cj4gPiA+Cj4gPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4gPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+ID4gSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+ID4gCj4gPiAKPiA+IAo+ID4gLS0gCj4gPiAKPiA+ IAo+ID4gSmFtZXMgQXVzbXVzCj4gCj4gLS0gCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwgT1RD Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=