From: Rodrigo Vivi Subject: Re: [PATCH 5/8] drm/i915: Use cdclk_state->voltage on SKL/KBL/CFL Date: Thu, 19 Oct 2017 16:47:08 -0700 Message-ID: <20171019234708.bmwdladlcaa4gwax@intel.com> References: <20171018204825.2500-1-ville.syrjala@linux.intel.com> <20171018204825.2500-6-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B1216EBB7 for ; Thu, 19 Oct 2017 23:47:09 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171018204825.2500-6-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMTgsIDIwMTcgYXQgMDg6NDg6MjJQTSArMDAwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFRyYWNrIHRoZSBzeXN0ZW0gYWdlbnQgdm9sdGFnZSB3ZSByZXF1ZXN0IGZyb20g cGNvZGUgaW4gdGhlIGNkY2xrIHN0YXRlCj4gb24gU0tML0tCTC9DRkwuIEFubm95aW5nbHkgd2Ug Y2FuJ3QgYWN0dWFsbHkgcmVhZCBvdXQgdGhlIGN1cnJlbnQgdmFsdWUgc2luY2UKPiB0aGVyZSdz IG5vIHBjb2RlIGNvbW1hbmQgdG8gZG8gdGhhdCwgc28gd2UnbGwgaGF2ZSB0byBqdXN0IGFzc3Vt ZSB0aGF0Cj4gaXQgd29ya2VkLgo+IAo+IENjOiBNaWthIEthaG9sYSA8bWlrYS5rYWhvbGFAaW50 ZWwuY29tPgo+IENjOiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+ IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1i eTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYyB8IDQwICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMyBpbnNlcnRpb25z KCspLCA3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9jZGNsay5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYwo+IGlu ZGV4IDc0NDJlOTQ0M2ZmYS4uNmY3YjVhYmU2ZTNmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9jZGNsay5jCj4gQEAgLTc4OSw2ICs3ODksMjQgQEAgc3RhdGljIGludCBza2xfY2FsY19jZGNs ayhpbnQgbWluX2NkY2xrLCBpbnQgdmNvKQo+ICAJfQo+ICB9Cj4gIAo+ICtzdGF0aWMgdTggc2ts X2NhbGNfdm9sdGFnZShpbnQgY2RjbGspCj4gK3sKPiArCXN3aXRjaCAoY2RjbGspIHsKPiArCWRl ZmF1bHQ6Cj4gKwljYXNlIDMwODU3MToKPiArCWNhc2UgMzM3NTAwOgo+ICsJCXJldHVybiAwOwo+ ICsJY2FzZSA0NTAwMDA6Cj4gKwljYXNlIDQzMjAwMDoKPiArCQlyZXR1cm4gMTsKPiArCWNhc2Ug NTQwMDAwOgo+ICsJCXJldHVybiAyOwo+ICsJY2FzZSA2MTcxNDM6Cj4gKwljYXNlIDY3NTAwMDoK PiArCQlyZXR1cm4gMzsKPiArCX0KPiArfQo+ICsKPiAgc3RhdGljIHZvaWQgc2tsX2RwbGwwX3Vw ZGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCSAgICAgc3RydWN0 IGludGVsX2NkY2xrX3N0YXRlICpjZGNsa19zdGF0ZSkKPiAgewo+IEBAIC04MzksNyArODU3LDcg QEAgc3RhdGljIHZvaWQgc2tsX2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4gIAljZGNsa19zdGF0ZS0+Y2RjbGsgPSBjZGNsa19zdGF0ZS0+cmVmOwo+ICAKPiAg CWlmIChjZGNsa19zdGF0ZS0+dmNvID09IDApCj4gLQkJcmV0dXJuOwo+ICsJCWdvdG8gb3V0OwoK d2h5IGRvIHdlIG5lZWQgdGhpcyBjYXNlPwoKPiAgCj4gIAljZGN0bCA9IEk5MTVfUkVBRChDRENM S19DVEwpOwo+ICAKPiBAQCAtODgwLDYgKzg5OCwxMyBAQCBzdGF0aWMgdm9pZCBza2xfZ2V0X2Nk Y2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJYnJlYWs7Cj4gIAkJ fQo+ICAJfQo+ICsKPiArIG91dDoKPiArCS8qCj4gKwkgKiBDYW4ndCByZWFkIHRoaXMgb3V0IDoo IExldCdzIGFzc3VtZSBpdCdzCj4gKwkgKiBhdCBsZWFzdCB3aGF0IHRoZSBDRENMSyBmcmVxdWVu Y3kgcmVxdWlyZXMuCj4gKwkgKi8KPiArCWNkY2xrX3N0YXRlLT52b2x0YWdlID0gc2tsX2NhbGNf dm9sdGFnZShjZGNsa19zdGF0ZS0+Y2RjbGspOwo+ICB9Cj4gIAo+ICAvKiBjb252ZXJ0IGZyb20g a0h6IHRvIC4xIGZpeHBvaW50IE1IeiB3aXRoIC0xTUh6IG9mZnNldCAqLwo+IEBAIC05NjQsNyAr OTg5LDcgQEAgc3RhdGljIHZvaWQgc2tsX3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4gIHsKPiAgCWludCBjZGNsayA9IGNkY2xrX3N0YXRlLT5jZGNsazsKPiAg CWludCB2Y28gPSBjZGNsa19zdGF0ZS0+dmNvOwo+IC0JdTMyIGZyZXFfc2VsZWN0LCBwY3VfYWNr Owo+ICsJdTMyIGZyZXFfc2VsZWN0Owo+ICAJaW50IHJldDsKPiAgCj4gIAltdXRleF9sb2NrKCZk ZXZfcHJpdi0+cGN1X2xvY2spOwo+IEBAIC05ODgsMjEgKzEwMTMsMTcgQEAgc3RhdGljIHZvaWQg c2tsX3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAljYXNl IDMwODU3MToKPiAgCWNhc2UgMzM3NTAwOgo+ICAJCWZyZXFfc2VsZWN0ID0gQ0RDTEtfRlJFUV8z MzdfMzA4Owo+IC0JCXBjdV9hY2sgPSAwOwo+ICAJCWJyZWFrOwo+ICAJY2FzZSA0NTAwMDA6Cj4g IAljYXNlIDQzMjAwMDoKPiAgCQlmcmVxX3NlbGVjdCA9IENEQ0xLX0ZSRVFfNDUwXzQzMjsKPiAt CQlwY3VfYWNrID0gMTsKPiAgCQlicmVhazsKPiAgCWNhc2UgNTQwMDAwOgo+ICAJCWZyZXFfc2Vs ZWN0ID0gQ0RDTEtfRlJFUV81NDA7Cj4gLQkJcGN1X2FjayA9IDI7Cj4gIAkJYnJlYWs7Cj4gIAlj YXNlIDYxNzE0MzoKPiAgCWNhc2UgNjc1MDAwOgo+ICAJCWZyZXFfc2VsZWN0ID0gQ0RDTEtfRlJF UV82NzVfNjE3Owo+IC0JCXBjdV9hY2sgPSAzOwo+ICAJCWJyZWFrOwo+ICAJfQo+ICAKPiBAQCAt MTAxOCw3ICsxMDM5LDggQEAgc3RhdGljIHZvaWQgc2tsX3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAo+ICAJLyogaW5mb3JtIFBDVSBvZiB0aGUgY2hhbmdl ICovCj4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+cGN1X2xvY2spOwo+IC0Jc2FuZHlicmlkZ2Vf cGNvZGVfd3JpdGUoZGV2X3ByaXYsIFNLTF9QQ09ERV9DRENMS19DT05UUk9MLCBwY3VfYWNrKTsK PiArCXNhbmR5YnJpZGdlX3Bjb2RlX3dyaXRlKGRldl9wcml2LCBTS0xfUENPREVfQ0RDTEtfQ09O VFJPTCwKPiArCQkJCWNkY2xrX3N0YXRlLT52b2x0YWdlKTsKPiAgCW11dGV4X3VubG9jaygmZGV2 X3ByaXYtPnBjdV9sb2NrKTsKPiAgCj4gIAlpbnRlbF91cGRhdGVfY2RjbGsoZGV2X3ByaXYpOwo+ IEBAIC0xMDk3LDYgKzExMTksNyBAQCB2b2lkIHNrbF9pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgCWlmIChjZGNsa19zdGF0ZS52Y28gPT0gMCkKPiAgCQlj ZGNsa19zdGF0ZS52Y28gPSA4MTAwMDAwOwo+ICAJY2RjbGtfc3RhdGUuY2RjbGsgPSBza2xfY2Fs Y19jZGNsaygwLCBjZGNsa19zdGF0ZS52Y28pOwo+ICsJY2RjbGtfc3RhdGUudm9sdGFnZSA9IHNr bF9jYWxjX3ZvbHRhZ2UoY2RjbGtfc3RhdGUuY2RjbGspOwo+ICAKPiAgCXNrbF9zZXRfY2RjbGso ZGV2X3ByaXYsICZjZGNsa19zdGF0ZSk7Cj4gIH0KPiBAQCAtMTExNCw2ICsxMTM3LDcgQEAgdm9p ZCBza2xfdW5pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAg Cj4gIAljZGNsa19zdGF0ZS5jZGNsayA9IGNkY2xrX3N0YXRlLnJlZjsKPiAgCWNkY2xrX3N0YXRl LnZjbyA9IDA7Cj4gKwljZGNsa19zdGF0ZS52b2x0YWdlID0gc2tsX2NhbGNfdm9sdGFnZShjZGNs a19zdGF0ZS5jZGNsayk7Cj4gIAo+ICAJc2tsX3NldF9jZGNsayhkZXZfcHJpdiwgJmNkY2xrX3N0 YXRlKTsKPiAgfQo+IEBAIC0xOTcwLDEyICsxOTk0LDE0IEBAIHN0YXRpYyBpbnQgc2tsX21vZGVz ZXRfY2FsY19jZGNsayhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gIAo+ICAJaW50 ZWxfc3RhdGUtPmNkY2xrLmxvZ2ljYWwudmNvID0gdmNvOwo+ICAJaW50ZWxfc3RhdGUtPmNkY2xr LmxvZ2ljYWwuY2RjbGsgPSBjZGNsazsKPiArCWludGVsX3N0YXRlLT5jZGNsay5sb2dpY2FsLnZv bHRhZ2UgPSBza2xfY2FsY192b2x0YWdlKGNkY2xrKTsKPiAgCj4gIAlpZiAoIWludGVsX3N0YXRl LT5hY3RpdmVfY3J0Y3MpIHsKPiAgCQljZGNsayA9IHNrbF9jYWxjX2NkY2xrKDAsIHZjbyk7Cj4g IAo+ICAJCWludGVsX3N0YXRlLT5jZGNsay5hY3R1YWwudmNvID0gdmNvOwo+ICAJCWludGVsX3N0 YXRlLT5jZGNsay5hY3R1YWwuY2RjbGsgPSBjZGNsazsKPiArCQlpbnRlbF9zdGF0ZS0+Y2RjbGsu YWN0dWFsLnZvbHRhZ2UgPSBza2xfY2FsY192b2x0YWdlKGNkY2xrKTsKPiAgCX0gZWxzZSB7Cj4g IAkJaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbCA9Cj4gIAkJCWludGVsX3N0YXRlLT5jZGNsay5s b2dpY2FsOwo+IC0tIAo+IDIuMTMuNgo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK