From: Rodrigo Vivi Subject: Re: [PATCH v2 4/8] drm/i915: Use cdclk_state->voltage on BDW Date: Fri, 20 Oct 2017 13:47:27 -0700 Message-ID: <20171020204727.ho7a6f5vvu2jypoi@intel.com> References: <20171018204825.2500-5-ville.syrjala@linux.intel.com> <20171020170358.25030-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F5BF6E17B for ; Fri, 20 Oct 2017 20:47:28 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171020170358.25030-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBPY3QgMjAsIDIwMTcgYXQgMDU6MDM6NThQTSArMDAwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFRyYWNrIHRoZSBzeXN0ZW0gYWdlbnQgdm9sdGFnZSB3ZSByZXF1ZXN0IGZyb20g cGNvZGUgaW4gdGhlIGNkY2xrIHN0YXRlCj4gb24gQkRXLiBBbm5veWluZ2x5IHdlIGNhbid0IGFj dHVhbGx5IHJlYWQgb3V0IHRoZSBjdXJyZW50IHZhbHVlIHNpbmNlCj4gdGhlcmUncyBubyBwY29k ZSBjb21tYW5kIHRvIGRvIHRoYXQsIHNvIHdlJ2xsIGhhdmUgdG8ganVzdCBhc3N1bWUgdGhhdAo+ IGl0IHdvcmtlZC4KPiAKPiB2MjogS2VlcCB0aGUgV0FSTl9PTiAoUm9kcmlnbykKCnRoYW5rcwoK UmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KCgo+IAo+ IENjOiBNaWthIEthaG9sYSA8bWlrYS5rYWhvbGFAaW50ZWwuY29tPgo+IENjOiBNYW5hc2kgTmF2 YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJp Z28udml2aUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfY2RjbGsuYyB8IDMyICsrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfY2RjbGsuYwo+IGluZGV4IGUyZjE4NTQ1ZDIwYy4uYWIwNDgxMTgzYmFl IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jCj4gQEAgLTYzOSw2ICs2MzksMjEg QEAgc3RhdGljIGludCBiZHdfY2FsY19jZGNsayhpbnQgbWluX2NkY2xrKQo+ICAJCXJldHVybiAz Mzc1MDA7Cj4gIH0KPiAgCj4gK3N0YXRpYyB1OCBiZHdfY2FsY192b2x0YWdlKGludCBjZGNsaykK PiArewo+ICsJc3dpdGNoIChjZGNsaykgewo+ICsJZGVmYXVsdDoKPiArCWNhc2UgMzM3NTAwOgo+ ICsJCXJldHVybiAyOwo+ICsJY2FzZSA0NTAwMDA6Cj4gKwkJcmV0dXJuIDA7Cj4gKwljYXNlIDU0 MDAwMDoKPiArCQlyZXR1cm4gMTsKPiArCWNhc2UgNjc1MDAwOgo+ICsJCXJldHVybiAzOwo+ICsJ fQo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9pZCBiZHdfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwKPiAgCQkJICBzdHJ1Y3QgaW50ZWxfY2RjbGtfc3RhdGUgKmNkY2xr X3N0YXRlKQo+ICB7Cj4gQEAgLTY1NywxMyArNjcyLDE5IEBAIHN0YXRpYyB2b2lkIGJkd19nZXRf Y2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCWNkY2xrX3N0YXRl LT5jZGNsayA9IDMzNzUwMDsKPiAgCWVsc2UKPiAgCQljZGNsa19zdGF0ZS0+Y2RjbGsgPSA2NzUw MDA7Cj4gKwo+ICsJLyoKPiArCSAqIENhbid0IHJlYWQgdGhpcyBvdXQgOiggTGV0J3MgYXNzdW1l IGl0J3MKPiArCSAqIGF0IGxlYXN0IHdoYXQgdGhlIENEQ0xLIGZyZXF1ZW5jeSByZXF1aXJlcy4K PiArCSAqLwo+ICsJY2RjbGtfc3RhdGUtPnZvbHRhZ2UgPSBiZHdfY2FsY192b2x0YWdlKGNkY2xr X3N0YXRlLT5jZGNsayk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGJkd19zZXRfY2RjbGsoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkgIGNvbnN0IHN0cnVjdCBpbnRl bF9jZGNsa19zdGF0ZSAqY2RjbGtfc3RhdGUpCj4gIHsKPiAgCWludCBjZGNsayA9IGNkY2xrX3N0 YXRlLT5jZGNsazsKPiAtCXVpbnQzMl90IHZhbCwgZGF0YTsKPiArCXVpbnQzMl90IHZhbDsKPiAg CWludCByZXQ7Cj4gIAo+ICAJaWYgKFdBUk4oKEk5MTVfUkVBRChMQ1BMTF9DVEwpICYKPiBAQCAt NzA0LDE5ICs3MjUsMTUgQEAgc3RhdGljIHZvaWQgYmR3X3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJLyogZmFsbCB0aHJvdWdoICovCj4gIAljYXNlIDMz NzUwMDoKPiAgCQl2YWwgfD0gTENQTExfQ0xLX0ZSRVFfMzM3XzVfQkRXOwo+IC0JCWRhdGEgPSAy Owo+ICAJCWJyZWFrOwo+ICAJY2FzZSA0NTAwMDA6Cj4gIAkJdmFsIHw9IExDUExMX0NMS19GUkVR XzQ1MDsKPiAtCQlkYXRhID0gMDsKPiAgCQlicmVhazsKPiAgCWNhc2UgNTQwMDAwOgo+ICAJCXZh bCB8PSBMQ1BMTF9DTEtfRlJFUV81NE9fQkRXOwo+IC0JCWRhdGEgPSAxOwo+ICAJCWJyZWFrOwo+ ICAJY2FzZSA2NzUwMDA6Cj4gIAkJdmFsIHw9IExDUExMX0NMS19GUkVRXzY3NV9CRFc7Cj4gLQkJ ZGF0YSA9IDM7Cj4gIAkJYnJlYWs7Cj4gIAl9Cj4gIAo+IEBAIC03MzEsNyArNzQ4LDggQEAgc3Rh dGljIHZvaWQgYmR3X3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs Cj4gIAkJRFJNX0VSUk9SKCJTd2l0Y2hpbmcgYmFjayB0byBMQ1BMTCBmYWlsZWRcbiIpOwo+ICAK PiAgCW11dGV4X2xvY2soJmRldl9wcml2LT5wY3VfbG9jayk7Cj4gLQlzYW5keWJyaWRnZV9wY29k ZV93cml0ZShkZXZfcHJpdiwgSFNXX1BDT0RFX0RFX1dSSVRFX0ZSRVFfUkVRLCBkYXRhKTsKPiAr CXNhbmR5YnJpZGdlX3Bjb2RlX3dyaXRlKGRldl9wcml2LCBIU1dfUENPREVfREVfV1JJVEVfRlJF UV9SRVEsCj4gKwkJCQljZGNsa19zdGF0ZS0+dm9sdGFnZSk7Cj4gIAltdXRleF91bmxvY2soJmRl dl9wcml2LT5wY3VfbG9jayk7Cj4gIAo+ICAJSTkxNV9XUklURShDRENMS19GUkVRLCBESVZfUk9V TkRfQ0xPU0VTVChjZGNsaywgMTAwMCkgLSAxKTsKPiBAQCAtMTkxMCwxMSArMTkyOCwxMyBAQCBz dGF0aWMgaW50IGJkd19tb2Rlc2V0X2NhbGNfY2RjbGsoc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlKQo+ICAJY2RjbGsgPSBiZHdfY2FsY19jZGNsayhtaW5fY2RjbGspOwo+ICAKPiAgCWlu dGVsX3N0YXRlLT5jZGNsay5sb2dpY2FsLmNkY2xrID0gY2RjbGs7Cj4gKwlpbnRlbF9zdGF0ZS0+ Y2RjbGsubG9naWNhbC52b2x0YWdlID0gYmR3X2NhbGNfdm9sdGFnZShjZGNsayk7Cj4gIAo+ICAJ aWYgKCFpbnRlbF9zdGF0ZS0+YWN0aXZlX2NydGNzKSB7Cj4gIAkJY2RjbGsgPSBiZHdfY2FsY19j ZGNsaygwKTsKPiAgCj4gIAkJaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbC5jZGNsayA9IGNkY2xr Owo+ICsJCWludGVsX3N0YXRlLT5jZGNsay5hY3R1YWwudm9sdGFnZSA9IGJkd19jYWxjX3ZvbHRh Z2UoY2RjbGspOwo+ICAJfSBlbHNlIHsKPiAgCQlpbnRlbF9zdGF0ZS0+Y2RjbGsuYWN0dWFsID0K PiAgCQkJaW50ZWxfc3RhdGUtPmNkY2xrLmxvZ2ljYWw7Cj4gLS0gCj4gMi4xMy42Cj4gCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=