From: Rodrigo Vivi Subject: Re: [PATCH 7/8] drm/i915: Use cdclk_state->voltage on CNL Date: Mon, 23 Oct 2017 11:29:09 -0700 Message-ID: <20171023182909.b3syhzpbl6xbjlri@intel.com> References: <20171018204825.2500-1-ville.syrjala@linux.intel.com> <20171018204825.2500-8-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E2FC6E25E for ; Mon, 23 Oct 2017 18:29:09 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171018204825.2500-8-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMTgsIDIwMTcgYXQgMDg6NDg6MjRQTSArMDAwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFRyYWNrIHRoZSBzeXN0ZW0gYWdlbnQgdm9sdGFnZSB3ZSByZXF1ZXN0IGZyb20g cGNvZGUgaW4gdGhlIGNkY2xrIHN0YXRlCj4gb24gQ05MLiBBbm5veWluZ2x5IHdlIGNhbid0IGFj dHVhbGx5IHJlYWQgb3V0IHRoZSBjdXJyZW50IHZhbHVlIHNpbmNlCj4gdGhlcmUncyBubyBwY29k ZSBjb21tYW5kIHRvIGRvIHRoYXQsIHNvIHdlJ2xsIGhhdmUgdG8ganVzdCBhc3N1bWUgdGhhdAo+ IGl0IHdvcmtlZC4KPiAKPiBDYzogTWlrYSBLYWhvbGEgPG1pa2Eua2Fob2xhQGludGVsLmNvbT4K PiBDYzogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KPiBDYzogUm9k cmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTog Um9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgooZXZlbiB3aXRoIG5ldyB2IHdp dGggdm9sdGFnZV9sZXZlbCBuYW1lKQoKVGhhbmtzIGZvciBhbGwgZXhwbGFuYXRpb25zIGFuZCBk aXNjdXNzaW9ucywgdGhpcyBzZWVtcyB0aGUKcmlnaHQgYXBwcm9hY2guCgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jIHwgNDQgKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDE2 IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9jZGNsay5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYwo+IGluZGV4IDFi NGRjZDk2ODlkYS4uNzk1YTE4ZjY0YzRjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2NkY2xrLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNs ay5jCj4gQEAgLTE1MDUsNiArMTUwNSwxOSBAQCBzdGF0aWMgaW50IGNubF9jYWxjX2NkY2xrKGlu dCBtaW5fY2RjbGspCj4gIAkJcmV0dXJuIDE2ODAwMDsKPiAgfQo+ICAKPiArc3RhdGljIHU4IGNu bF9jYWxjX3ZvbHRhZ2UoaW50IGNkY2xrKQo+ICt7Cj4gKwlzd2l0Y2ggKGNkY2xrKSB7Cj4gKwlk ZWZhdWx0Ogo+ICsJY2FzZSAxNjgwMDA6Cj4gKwkJcmV0dXJuIDA7Cj4gKwljYXNlIDMzNjAwMDoK PiArCQlyZXR1cm4gMTsKPiArCWNhc2UgNTI4MDAwOgo+ICsJCXJldHVybiAyOwo+ICsJfQo+ICt9 Cj4gKwo+ICBzdGF0aWMgdm9pZCBjbmxfY2RjbGtfcGxsX3VwZGF0ZShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCQkgc3RydWN0IGludGVsX2NkY2xrX3N0YXRlICpjZGNs a19zdGF0ZSkKPiAgewo+IEBAIC0xNTM4LDcgKzE1NTEsNyBAQCBzdGF0aWMgdm9pZCBjbmxfZ2V0 X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCWNkY2xrX3N0YXRl LT5jZGNsayA9IGNkY2xrX3N0YXRlLT5yZWY7Cj4gIAo+ICAJaWYgKGNkY2xrX3N0YXRlLT52Y28g PT0gMCkKPiAtCQlyZXR1cm47Cj4gKwkJZ290byBvdXQ7Cj4gIAo+ICAJZGl2aWRlciA9IEk5MTVf UkVBRChDRENMS19DVEwpICYgQlhUX0NEQ0xLX0NEMlhfRElWX1NFTF9NQVNLOwo+ICAKPiBAQCAt MTU1NSw2ICsxNTY4LDEzIEBAIHN0YXRpYyB2b2lkIGNubF9nZXRfY2RjbGsoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJfQo+ICAKPiAgCWNkY2xrX3N0YXRlLT5jZGNsayA9 IERJVl9ST1VORF9DTE9TRVNUKGNkY2xrX3N0YXRlLT52Y28sIGRpdik7Cj4gKwo+ICsgb3V0Ogo+ ICsJLyoKPiArCSAqIENhbid0IHJlYWQgdGhpcyBvdXQgOiggTGV0J3MgYXNzdW1lIGl0J3MKPiAr CSAqIGF0IGxlYXN0IHdoYXQgdGhlIENEQ0xLIGZyZXF1ZW5jeSByZXF1aXJlcy4KPiArCSAqLwo+ ICsJY2RjbGtfc3RhdGUtPnZvbHRhZ2UgPSBjbmxfY2FsY192b2x0YWdlKGNkY2xrX3N0YXRlLT5j ZGNsayk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGNubF9jZGNsa19wbGxfZGlzYWJsZShzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gQEAgLTE1OTUsNyArMTYxNSw3IEBAIHN0 YXRpYyB2b2lkIGNubF9zZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+ICB7Cj4gIAlpbnQgY2RjbGsgPSBjZGNsa19zdGF0ZS0+Y2RjbGs7Cj4gIAlpbnQgdmNvID0g Y2RjbGtfc3RhdGUtPnZjbzsKPiAtCXUzMiB2YWwsIGRpdmlkZXIsIHBjdV9hY2s7Cj4gKwl1MzIg dmFsLCBkaXZpZGVyOwo+ICAJaW50IHJldDsKPiAgCj4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+ cGN1X2xvY2spOwo+IEBAIC0xNjI0LDE5ICsxNjQ0LDYgQEAgc3RhdGljIHZvaWQgY25sX3NldF9j ZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJYnJlYWs7Cj4gIAl9 Cj4gIAo+IC0Jc3dpdGNoIChjZGNsaykgewo+IC0JY2FzZSA1MjgwMDA6Cj4gLQkJcGN1X2FjayA9 IDI7Cj4gLQkJYnJlYWs7Cj4gLQljYXNlIDMzNjAwMDoKPiAtCQlwY3VfYWNrID0gMTsKPiAtCQli cmVhazsKPiAtCWNhc2UgMTY4MDAwOgo+IC0JZGVmYXVsdDoKPiAtCQlwY3VfYWNrID0gMDsKPiAt CQlicmVhazsKPiAtCX0KPiAtCj4gIAlpZiAoZGV2X3ByaXYtPmNkY2xrLmh3LnZjbyAhPSAwICYm Cj4gIAkgICAgZGV2X3ByaXYtPmNkY2xrLmh3LnZjbyAhPSB2Y28pCj4gIAkJY25sX2NkY2xrX3Bs bF9kaXNhYmxlKGRldl9wcml2KTsKPiBAQCAtMTY1NCw3ICsxNjYxLDggQEAgc3RhdGljIHZvaWQg Y25sX3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAo+ICAJ LyogaW5mb3JtIFBDVSBvZiB0aGUgY2hhbmdlICovCj4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+ cGN1X2xvY2spOwo+IC0Jc2FuZHlicmlkZ2VfcGNvZGVfd3JpdGUoZGV2X3ByaXYsIFNLTF9QQ09E RV9DRENMS19DT05UUk9MLCBwY3VfYWNrKTsKPiArCXNhbmR5YnJpZGdlX3Bjb2RlX3dyaXRlKGRl dl9wcml2LCBTS0xfUENPREVfQ0RDTEtfQ09OVFJPTCwKPiArCQkJCWNkY2xrX3N0YXRlLT52b2x0 YWdlKTsKPiAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPnBjdV9sb2NrKTsKPiAgCj4gIAlpbnRl bF91cGRhdGVfY2RjbGsoZGV2X3ByaXYpOwo+IEBAIC0xNzQ3LDYgKzE3NTUsNyBAQCB2b2lkIGNu bF9pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCj4gIAlj ZGNsa19zdGF0ZS5jZGNsayA9IGNubF9jYWxjX2NkY2xrKDApOwo+ICAJY2RjbGtfc3RhdGUudmNv ID0gY25sX2NkY2xrX3BsbF92Y28oZGV2X3ByaXYsIGNkY2xrX3N0YXRlLmNkY2xrKTsKPiArCWNk Y2xrX3N0YXRlLnZvbHRhZ2UgPSBjbmxfY2FsY192b2x0YWdlKGNkY2xrX3N0YXRlLmNkY2xrKTsK PiAgCj4gIAljbmxfc2V0X2NkY2xrKGRldl9wcml2LCAmY2RjbGtfc3RhdGUpOwo+ICB9Cj4gQEAg LTE3NjQsNiArMTc3Myw3IEBAIHZvaWQgY25sX3VuaW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAo+ICAJY2RjbGtfc3RhdGUuY2RjbGsgPSBjZGNsa19zdGF0 ZS5yZWY7Cj4gIAljZGNsa19zdGF0ZS52Y28gPSAwOwo+ICsJY2RjbGtfc3RhdGUudm9sdGFnZSA9 IGNubF9jYWxjX3ZvbHRhZ2UoY2RjbGtfc3RhdGUuY2RjbGspOwo+ICAKPiAgCWNubF9zZXRfY2Rj bGsoZGV2X3ByaXYsICZjZGNsa19zdGF0ZSk7Cj4gIH0KPiBAQCAtMjA4MSw2ICsyMDkxLDcgQEAg c3RhdGljIGludCBjbmxfbW9kZXNldF9jYWxjX2NkY2xrKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRl ICpzdGF0ZSkKPiAgCj4gIAlpbnRlbF9zdGF0ZS0+Y2RjbGsubG9naWNhbC52Y28gPSB2Y287Cj4g IAlpbnRlbF9zdGF0ZS0+Y2RjbGsubG9naWNhbC5jZGNsayA9IGNkY2xrOwo+ICsJaW50ZWxfc3Rh dGUtPmNkY2xrLmxvZ2ljYWwudm9sdGFnZSA9IGNubF9jYWxjX3ZvbHRhZ2UoY2RjbGspOwo+ICAK PiAgCWlmICghaW50ZWxfc3RhdGUtPmFjdGl2ZV9jcnRjcykgewo+ICAJCWNkY2xrID0gY25sX2Nh bGNfY2RjbGsoMCk7Cj4gQEAgLTIwODgsNiArMjA5OSw3IEBAIHN0YXRpYyBpbnQgY25sX21vZGVz ZXRfY2FsY19jZGNsayhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gIAo+ICAJCWlu dGVsX3N0YXRlLT5jZGNsay5hY3R1YWwudmNvID0gdmNvOwo+ICAJCWludGVsX3N0YXRlLT5jZGNs ay5hY3R1YWwuY2RjbGsgPSBjZGNsazsKPiArCQlpbnRlbF9zdGF0ZS0+Y2RjbGsuYWN0dWFsLnZv bHRhZ2UgPSBjbmxfY2FsY192b2x0YWdlKGNkY2xrKTsKPiAgCX0gZWxzZSB7Cj4gIAkJaW50ZWxf c3RhdGUtPmNkY2xrLmFjdHVhbCA9Cj4gIAkJCWludGVsX3N0YXRlLT5jZGNsay5sb2dpY2FsOwo+ IC0tIAo+IDIuMTMuNgo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK