From: Rodrigo Vivi Subject: Re: [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers. Date: Mon, 23 Oct 2017 15:53:15 -0700 Message-ID: <20171023225315.o6pdscgk2lotn6ts@intel.com> References: <20171019231820.28804-1-kenneth@whitecape.org> <150879796346.18467.14730848540037674402@jljusten-skl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <150879796346.18467.14730848540037674402@jljusten-skl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jordan Justen Cc: intel-gfx@lists.freedesktop.org, Kristian =?iso-8859-1?Q?H=F8gsberg?= , Kenneth Graunke , mesa-dev List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMjMsIDIwMTcgYXQgMTA6MzI6NDNQTSArMDAwMCwgSm9yZGFuIEp1c3RlbiB3 cm90ZToKPiBPbiAyMDE3LTEwLTE5IDE2OjMwOjQ0LCBLcmlzdGlhbiBIw7hnc2Jlcmcgd3JvdGU6 Cj4gPiBPbiBUaHUsIE9jdCAxOSwgMjAxNyBhdCA0OjE4IFBNLCBLZW5uZXRoIEdyYXVua2UgPGtl bm5ldGhAd2hpdGVjYXBlLm9yZz4gd3JvdGU6Cj4gPiA+IFRoZSBrZXJuZWwgZG9lc24ndCBpbml0 aWFsaXplIHRoZSB2YWx1ZSBvZiB0aGUgSU5TVFBNIG9yIENTX0RFQlVHX01PREUyCj4gPiA+IHJl Z2lzdGVycyBhdCBjb250ZXh0IGluaXRpYWxpemF0aW9uIHRpbWUuICBJbnN0ZWFkLCB0aGV5J3Jl IGluaGVyaXRlZAo+ID4gPiBmcm9tIHdoYXRldmVyIGhhcHBlbmVkIHRvIGJlIHJ1bm5pbmcgb24g dGhlIEdQVSBwcmlvciB0byBmaXJzdCBydW4gb2YgYQo+ID4gPiBuZXcgY29udGV4dC4gIFNvLCB3 aGVuIHdlIHN0YXJ0ZWQgc2V0dGluZyB0aGVzZSwgb3RoZXIgY29udGV4dHMgaW4gdGhlCj4gPiA+ IHN5c3RlbSBzdGFydGVkIGluaGVyaXRpbmcgb3VyIHZhbHVlcy4gIFNpbmNlIHRoaXMgY29udHJv bHMgd2hldGhlcgo+ID4gPiAzRFNUQVRFX0NPTlNUQU5UXyogdGFrZXMgYSBwb2ludGVyIG9yIGFu IG9mZnNldCwgZ2V0dGluZyB0aGUgd3JvbmcKPiA+ID4gc2V0dGluZyBpcyBmYXRhbCBmb3IgYWxt b3N0IGFueSBwcm9jZXNzIHdoaWNoIGlzbid0IGV4cGVjdGluZyB0aGlzLgo+ID4gPgo+ID4gPiBV bmZvcnR1bmF0ZWx5LCBWQS1BUEkgYW5kIEJlaWduZXQgZG9uJ3QgaW5pdGlhbGl6ZSB0aGlzIChu b3IgZG9lcyBvbGRlcgo+ID4gPiBNZXNhKSwgc28gdGhleSB3aWxsIGRpZSBob3JyaWJseSBpZiB3 ZSBzdGFydCBkb2luZyB0aGlzLiAgVVhBIGFuZCBTTkEKPiA+ID4gZG9uJ3QgdXNlIGFueSBwdXNo IGNvbnN0YW50cywgc28gdGhleSBhcmUgdW5hZmZlY3RlZC4KPiA+ID4KPiA+ID4gVGhlIGtlcm5l bCBkZXZlbG9wZXJzIGFyZSBhcHBhcmVudGx5IHVuaW50ZXJlc3RlZCBpbiBtYWtpbmcgdGhlIHBy b3RvLQo+ID4gPiBjb250ZXh0IGluaXRpYWxpemUgdGhlc2UgcmVnaXN0ZXJzIHRvIGd1YXJhbnRl ZSBkZXRlcm1pbmlzdGljIGJlaGF2aW9yLgo+ID4gCj4gPiBDb3VsZCBzb21lYm9keSBmcm9tIHRo ZSBrZXJuZWwgdGVhbSBlbGFib3JhdGUgaGVyZT8gVGhpcyBpcyBvYnZpb3VzbHkKPiA+IGJyb2tl biBhbmQgdW5kZXJtaW5lcyB0aGUgc2VjdXJpdHkgYW5kIGNvbnRhaW5lcml6YXRpb24gdGhhdCBo dwo+ID4gY29udGV4dHMgYXJlIHN1cHBvc2VkIHRvIHByb3ZpZGUuIEknbSByZWFsbHkgY3VyaW91 cyB3aGF0IHRoZSB0aGlua2luZwo+ID4gaXMgaGVyZS4uLgo+ID4gCj4gPiBLcmlzdGlhbgo+IAo+ IENjIGludGVsLWdmeCwgbWFpbnRhaW5lcnMKCklzIHRoaXMgdGhlIG51bGwtc3RhdGUvZ29sZGVu LWNvbnRleHQgcmVsYXRlZCBkaXNjdXNzaW9ucz8KCkkgYXNzdW1lIHdlIGFyZSBvayBmb3Igb2xk ZXIgcGxhdGZvcm1zLCBidXQgdGhlIHByb2JsZW0gd291bGQgYmUgb25seSBmb3IKQ05MKyB3aGVy ZSB3ZSBhcmUgbm90IGFkZGluZyB0aGUgbnVsbCBjb250ZXh0IGluaXRpYWxpemF0aW9uIHlldC4K QW0gSSBnZXR0aW5nIGl0IHJpZ2h0PwoKPiAKPiA+IAo+ID4gPiBBcHBhcmVudGx5LCB0aGUgIkRl ZmF1bHQgVmFsdWUiIG9mIHJlZ2lzdGVycyBpbiB0aGUgZG9jdW1lbnRhdGlvbiBpcyBhCj4gPiA+ IHRvdGFsIGxpZSwgYW5kIGNhbm5vdCBiZSByZWxpZWQgdXBvbiBieSB1c2Vyc3BhY2UuICBTbywg d2UgbmVlZCB0byBmaW5kCj4gPiA+IGEgbmV3IHNvbHV0aW9uLiAgT25lIHdvdWxkIGJlIHRvIHBh dGNoIFZBLUFQSSBhbmQgQmVpZ25ldCB0byBpbml0aWFsaXplCj4gPiA+IHRoZXNlLCB0aGVuIGdl dCBldmVyeSBkaXN0cmlidXRvciB0byBzaGlwIHRob3NlIGluIHRhbmRlbSB3aXRoIHRoZSBuZXdl cgo+ID4gPiBNZXNhIHZlcnNpb24uICBJJ20gdW5jbGVhciB3aGVuIHZhLWludGVsLWRyaXZlciBy ZWxlYXNlcyBtaWdodCBoYXBwZW4uCj4gPiA+IEFub3RoZXIgb3B0aW9uIHdvdWxkIGJlIHRvIGhh Y2sgTWVzYSB0byByZXN0b3JlIHRoZSByZWdpc3RlciBiYWNrIHRvIHRoZQo+ID4gPiBoaXN0b3Jp Y2FsIGRlZmF1bHQgKHJlbGF0aXZlIG1vZGUpIGF0IHRoZSBlbmQgb2YgZWFjaCBiYXRjaC4gIFRo aXMgaXMKPiA+ID4gYWxzbyBncm9zcywgYXMgaXQgaGFzIG5vbi16ZXJvIGNvc3QsIGFuZCBpcyBh bHNvIHJlbHlpbmcgb24gdXNlcnNwYWNlIHRvCj4gPiA+IGJlICJwb2xpdGUiIHRvIG90aGVyIGJy b2tlbiB1c2Vyc3BhY2UuICBBIGxhcmdlIHBhcnQgb2YgdGhlIG1vdGl2YXRpb24KPiA+ID4gZm9y IGNvbnRleHRzIHdhcyB0byBwcm92aWRlIHByb3BlciBwcm9jZXNzIGlzb2xhdGlvbiwgc28gd2Ug c2hvdWxkIG5vdAo+ID4gPiBoYXZlIHRvIGRvIHRoaXMuICBCdXQsIHdlJ3JlIGFscmVhZHkgZG9p bmcgaXQgaW4gc29tZSBjYXNlcywgYmVjYXVzZQo+ID4gPiBvdXIga2VybmVsIGZpeGVzIHRvIGVu Zm9yY2UgaXNvbGF0aW9uIHdlcmUgcmV2ZXJ0ZWQuCj4gPiA+Cj4gPiA+IEluIHRoZSBtZWFudGlt ZSwgSSBndWVzcyB3ZSdsbCBqdXN0IHJldmVydCB0aGlzIHBhdGNoIGFuZCBhYmFuZG9uIHVzaW5n Cj4gPiA+IHRoZSBmZWF0dXJlLiAgSXQgd2lsbCBsZWFkIHRvIGZld2VyIHB1c2hlZCBVQk9zIG9u IEJyb2Fkd2VsbCssIHdoaWNoIG1heQo+ID4gPiBsZWFkIHRvIGxvd2VyIHBlcmZvcm1hbmNlLCBi dXQgSSBkb24ndCBoYXZlIGFueSBkYXRhIG9uIHRoZSBpbXBhY3QuCj4gPiA+Cj4gPiA+IENjOiAi MTcuMiIgPG1lc2Etc3RhYmxlQGxpc3RzLmZyZWVkZXNrdG9wLm9yZz4KPiA+ID4gQnVnemlsbGE6 IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjc3NAo+ID4g PiAtLS0KPiA+ID4gIHNyYy9tZXNhL2RyaXZlcnMvZHJpL2k5NjUvYnJ3X3N0YXRlX3VwbG9hZC5j IHwgMjQgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiA+ICBzcmMvbWVzYS9kcml2ZXJzL2Ry aS9pOTY1L2ludGVsX3NjcmVlbi5jICAgICB8ICAyICstCj4gPiA+ICAyIGZpbGVzIGNoYW5nZWQs IDEgaW5zZXJ0aW9uKCspLCAyNSBkZWxldGlvbnMoLSkKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBh L3NyYy9tZXNhL2RyaXZlcnMvZHJpL2k5NjUvYnJ3X3N0YXRlX3VwbG9hZC5jIGIvc3JjL21lc2Ev ZHJpdmVycy9kcmkvaTk2NS9icndfc3RhdGVfdXBsb2FkLmMKPiA+ID4gaW5kZXggMTZmNDRkMDNi YmUuLjIzZTRlYmRhMjU5IDEwMDY0NAo+ID4gPiAtLS0gYS9zcmMvbWVzYS9kcml2ZXJzL2RyaS9p OTY1L2Jyd19zdGF0ZV91cGxvYWQuYwo+ID4gPiArKysgYi9zcmMvbWVzYS9kcml2ZXJzL2RyaS9p OTY1L2Jyd19zdGF0ZV91cGxvYWQuYwo+ID4gPiBAQCAtMTAxLDMwICsxMDEsNiBAQCBicndfdXBs b2FkX2luaXRpYWxfZ3B1X3N0YXRlKHN0cnVjdCBicndfY29udGV4dCAqYnJ3KQo+ID4gPiAgICAg ICAgT1VUX0JBVENIKDApOwo+ID4gPiAgICAgICAgQURWQU5DRV9CQVRDSCgpOwo+ID4gPiAgICAg fQo+ID4gPiAtCj4gPiA+IC0gICAvKiBTZXQgdGhlICJDT05TVEFOVF9CVUZGRVIgQWRkcmVzcyBP ZmZzZXQgRGlzYWJsZSIgYml0LCBzbwo+ID4gPiAtICAgICogM0RTVEFURV9DT05TVEFOVF9YUyBi dWZmZXIgMCBpcyBhbiBhYnNvbHV0ZSBhZGRyZXNzLgo+ID4gPiAtICAgICoKPiA+ID4gLSAgICAq IE9uIEdlbjYtNy41LCB3ZSB1c2UgYW4gZXhlY2J1ZiBwYXJhbWV0ZXIgdG8gZG8gdGhpcyBmb3Ig dXMuCj4gPiA+IC0gICAgKiBIb3dldmVyLCB0aGUga2VybmVsIGlnbm9yZXMgdGhhdCB3aGVuIGV4 ZWNsaXN0cyBhcmUgaW4gdXNlLgo+ID4gPiAtICAgICogRm9ydHVuYXRlbHksIHdlIGNhbiBqdXN0 IHdyaXRlIHRoZSByZWdpc3RlcnMgZnJvbSB1c2Vyc3BhY2UKPiA+ID4gLSAgICAqIG9uIEdlbjgr LCBhbmQgdGhleSdyZSBjb250ZXh0IHNhdmVkL3Jlc3RvcmVkLgo+ID4gPiAtICAgICovCj4gPiA+ IC0gICBpZiAoZGV2aW5mby0+Z2VuID49IDkpIHsKPiA+ID4gLSAgICAgIEJFR0lOX0JBVENIKDMp Owo+ID4gPiAtICAgICAgT1VUX0JBVENIKE1JX0xPQURfUkVHSVNURVJfSU1NIHwgKDMgLSAyKSk7 Cj4gPiA+IC0gICAgICBPVVRfQkFUQ0goQ1NfREVCVUdfTU9ERTIpOwo+ID4gPiAtICAgICAgT1VU X0JBVENIKFJFR19NQVNLKENTREJHMl9DT05TVEFOVF9CVUZGRVJfQUREUkVTU19PRkZTRVRfRElT QUJMRSkgfAo+ID4gPiAtICAgICAgICAgICAgICAgIENTREJHMl9DT05TVEFOVF9CVUZGRVJfQURE UkVTU19PRkZTRVRfRElTQUJMRSk7Cj4gPiA+IC0gICAgICBBRFZBTkNFX0JBVENIKCk7Cj4gPiA+ IC0gICB9IGVsc2UgaWYgKGRldmluZm8tPmdlbiA9PSA4KSB7Cj4gPiA+IC0gICAgICBCRUdJTl9C QVRDSCgzKTsKPiA+ID4gLSAgICAgIE9VVF9CQVRDSChNSV9MT0FEX1JFR0lTVEVSX0lNTSB8ICgz IC0gMikpOwo+ID4gPiAtICAgICAgT1VUX0JBVENIKElOU1RQTSk7Cj4gPiA+IC0gICAgICBPVVRf QkFUQ0goUkVHX01BU0soSU5TVFBNX0NPTlNUQU5UX0JVRkZFUl9BRERSRVNTX09GRlNFVF9ESVNB QkxFKSB8Cj4gPiA+IC0gICAgICAgICAgICAgICAgSU5TVFBNX0NPTlNUQU5UX0JVRkZFUl9BRERS RVNTX09GRlNFVF9ESVNBQkxFKTsKPiA+ID4gLSAgICAgIEFEVkFOQ0VfQkFUQ0goKTsKPiA+ID4g LSAgIH0KPiA+ID4gIH0KPiA+ID4KPiA+ID4gIHN0YXRpYyBpbmxpbmUgY29uc3Qgc3RydWN0IGJy d190cmFja2VkX3N0YXRlICoKPiA+ID4gZGlmZiAtLWdpdCBhL3NyYy9tZXNhL2RyaXZlcnMvZHJp L2k5NjUvaW50ZWxfc2NyZWVuLmMgYi9zcmMvbWVzYS9kcml2ZXJzL2RyaS9pOTY1L2ludGVsX3Nj cmVlbi5jCj4gPiA+IGluZGV4IGVhMDRhNzJlODYwLi43NzZjMjg5OGQ1YiAxMDA2NDQKPiA+ID4g LS0tIGEvc3JjL21lc2EvZHJpdmVycy9kcmkvaTk2NS9pbnRlbF9zY3JlZW4uYwo+ID4gPiArKysg Yi9zcmMvbWVzYS9kcml2ZXJzL2RyaS9pOTY1L2ludGVsX3NjcmVlbi5jCj4gPiA+IEBAIC0yNTEw LDcgKzI1MTAsNyBAQCBfX0RSSWNvbmZpZyAqKmludGVsSW5pdFNjcmVlbjIoX19EUklzY3JlZW4g KmRyaV9zY3JlZW4pCj4gPiA+ICAgICBzY3JlZW4tPmNvbXBpbGVyID0gYnJ3X2NvbXBpbGVyX2Ny ZWF0ZShzY3JlZW4sIGRldmluZm8pOwo+ID4gPiAgICAgc2NyZWVuLT5jb21waWxlci0+c2hhZGVy X2RlYnVnX2xvZyA9IHNoYWRlcl9kZWJ1Z19sb2dfbWVzYTsKPiA+ID4gICAgIHNjcmVlbi0+Y29t cGlsZXItPnNoYWRlcl9wZXJmX2xvZyA9IHNoYWRlcl9wZXJmX2xvZ19tZXNhOwo+ID4gPiAtICAg c2NyZWVuLT5jb21waWxlci0+Y29uc3RhbnRfYnVmZmVyXzBfaXNfcmVsYXRpdmUgPSBkZXZpbmZv LT5nZW4gPCA4Owo+ID4gPiArICAgc2NyZWVuLT5jb21waWxlci0+Y29uc3RhbnRfYnVmZmVyXzBf aXNfcmVsYXRpdmUgPSB0cnVlOwo+ID4gPiAgICAgc2NyZWVuLT5jb21waWxlci0+c3VwcG9ydHNf cHVsbF9jb25zdGFudHMgPSB0cnVlOwo+ID4gPgo+ID4gPiAgICAgc2NyZWVuLT5oYXNfZXhlY19m ZW5jZSA9Cj4gPiA+IC0tCj4gPiA+IDIuMTQuMgo+ID4gPgo+ID4gPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gPiBtZXNhLWRldiBtYWlsaW5nIGxp c3QKPiA+ID4gbWVzYS1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+IGh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vbWVzYS1kZXYKPiA+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBtZXNhLWRldiBtYWls aW5nIGxpc3QKPiA+IG1lc2EtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9tZXNhLWRldgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK