From: Harry Wentland Subject: [PATCH 07/29] drm/amd/display: Reject PPLib clock values if they are invalid Date: Thu, 26 Oct 2017 14:35:03 -0400 Message-ID: <20171026183525.7532-8-harry.wentland@amd.com> References: <20171026183525.7532-1-harry.wentland@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171026183525.7532-1-harry.wentland-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Andrew Jiang RnJvbTogQW5kcmV3IEppYW5nIDxBbmRyZXcuSmlhbmdAYW1kLmNvbT4KCldlIHNob3VsZCBiZSBz dGlja2luZyB3aXRoIHRoZSBkZWZhdWx0IGNsb2NrIHZhbHVlcyBpZiB0aGUgdmFsdWVzCm9idGFp bmVkIGZyb20gUFBMaWIgYXJlIGJvZ3VzLgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IEppYW5nIDxB bmRyZXcuSmlhbmdAYW1kLmNvbT4KUmV2aWV3ZWQtYnk6IFRvbnkgQ2hlbmcgPFRvbnkuQ2hlbmdA YW1kLmNvbT4KQWNrZWQtYnk6IEhhcnJ5IFdlbnRsYW5kIDxoYXJyeS53ZW50bGFuZEBhbWQuY29t PgotLS0KIGRyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9jYWxjcy9kY25fY2FsY3MuYyB8 IDY4ICsrKysrKysrKysrKysrKystLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQ1IGluc2VydGlv bnMoKyksIDIzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv ZGlzcGxheS9kYy9jYWxjcy9kY25fY2FsY3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxh eS9kYy9jYWxjcy9kY25fY2FsY3MuYwppbmRleCBlMTUxNTIzMGM2NjEuLjAxZjkyZjg4YWVhOCAx MDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNzL2Rjbl9jYWxj cy5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9jYWxjcy9kY25fY2FsY3Mu YwpAQCAtMTIzMSw0MCArMTIzMSw2MiBAQCB1bnNpZ25lZCBpbnQgZGNuX2ZpbmRfZGNmY2xrX3N1 aXRzX2FsbCgKIAlyZXR1cm4gZGNmX2NsazsKIH0KIAorc3RhdGljIGJvb2wgdmVyaWZ5X2Nsb2Nr X3ZhbHVlcyhzdHJ1Y3QgZG1fcHBfY2xvY2tfbGV2ZWxzX3dpdGhfdm9sdGFnZSAqY2xrcykKK3sK KwlpbnQgaTsKKworCWlmIChjbGtzLT5udW1fbGV2ZWxzID09IDApCisJCXJldHVybiBmYWxzZTsK KworCWZvciAoaSA9IDA7IGkgPCBjbGtzLT5udW1fbGV2ZWxzOyBpKyspCisJCS8qIEVuc3VyZSB0 aGF0IHRoZSByZXN1bHQgaXMgc2FuZSAqLworCQlpZiAoY2xrcy0+ZGF0YVtpXS5jbG9ja3NfaW5f a2h6ID09IDApCisJCQlyZXR1cm4gZmFsc2U7CisKKwlyZXR1cm4gdHJ1ZTsKK30KKwogdm9pZCBk Y25fYndfdXBkYXRlX2Zyb21fcHBsaWIoc3RydWN0IGRjICpkYykKIHsKIAlzdHJ1Y3QgZGNfY29u dGV4dCAqY3R4ID0gZGMtPmN0eDsKLQlzdHJ1Y3QgZG1fcHBfY2xvY2tfbGV2ZWxzX3dpdGhfdm9s dGFnZSBjbGtzID0gezB9OworCXN0cnVjdCBkbV9wcF9jbG9ja19sZXZlbHNfd2l0aF92b2x0YWdl IGZjbGtzID0gezB9LCBkY2ZjbGtzID0gezB9OworCWJvb2wgcmVzOwogCiAJa2VybmVsX2ZwdV9i ZWdpbigpOwogCiAJLyogVE9ETzogVGhpcyBpcyBub3QgdGhlIHByb3BlciB3YXkgdG8gb2J0YWlu IGZhYnJpY19hbmRfZHJhbV9iYW5kd2lkdGgsIHNob3VsZCBiZSBtaW4oZmNsaywgbWVtY2xrKSAq LwotCi0JaWYgKGRtX3BwX2dldF9jbG9ja19sZXZlbHNfYnlfdHlwZV93aXRoX3ZvbHRhZ2UoCi0J CQljdHgsIERNX1BQX0NMT0NLX1RZUEVfRkNMSywgJmNsa3MpICYmCi0JCQljbGtzLm51bV9sZXZl bHMgIT0gMCkgewotCQlBU1NFUlQoY2xrcy5udW1fbGV2ZWxzID49IDMpOwotCQlkYy0+ZGNuX3Nv Yy0+ZmFicmljX2FuZF9kcmFtX2JhbmR3aWR0aF92bWluMHA2NSA9IDMyICogKGNsa3MuZGF0YVsw XS5jbG9ja3NfaW5fa2h6IC8gMTAwMC4wKSAvIDEwMDAuMDsKLQkJaWYgKGNsa3MubnVtX2xldmVs cyA+IDIpIHsKLQkJCWRjLT5kY25fc29jLT5mYWJyaWNfYW5kX2RyYW1fYmFuZHdpZHRoX3ZtaWQw cDcyID0gZGMtPmRjbl9zb2MtPm51bWJlcl9vZl9jaGFubmVscyAqCi0JCQkJCShjbGtzLmRhdGFb Y2xrcy5udW1fbGV2ZWxzIC0gM10uY2xvY2tzX2luX2toeiAvIDEwMDAuMCkgKiBkZHI0X2RyYW1f ZmFjdG9yX3NpbmdsZV9DaGFubmVsIC8gMTAwMC4wOwotCQl9IGVsc2UgewotCQkJZGMtPmRjbl9z b2MtPmZhYnJpY19hbmRfZHJhbV9iYW5kd2lkdGhfdm1pZDBwNzIgPSBkYy0+ZGNuX3NvYy0+bnVt YmVyX29mX2NoYW5uZWxzICoKLQkJCQkJKGNsa3MuZGF0YVtjbGtzLm51bV9sZXZlbHMgLSAyXS5j bG9ja3NfaW5fa2h6IC8gMTAwMC4wKSAqIGRkcjRfZHJhbV9mYWN0b3Jfc2luZ2xlX0NoYW5uZWwg LyAxMDAwLjA7Ci0JCX0KKwlyZXMgPSBkbV9wcF9nZXRfY2xvY2tfbGV2ZWxzX2J5X3R5cGVfd2l0 aF92b2x0YWdlKAorCQkJY3R4LCBETV9QUF9DTE9DS19UWVBFX0ZDTEssICZmY2xrcyk7CisKKwlp ZiAocmVzKQorCQlyZXMgPSB2ZXJpZnlfY2xvY2tfdmFsdWVzKCZmY2xrcyk7CisKKwlpZiAocmVz KSB7CisJCUFTU0VSVChmY2xrcy5udW1fbGV2ZWxzID49IDMpOworCQlkYy0+ZGNuX3NvYy0+ZmFi cmljX2FuZF9kcmFtX2JhbmR3aWR0aF92bWluMHA2NSA9IDMyICogKGZjbGtzLmRhdGFbMF0uY2xv Y2tzX2luX2toeiAvIDEwMDAuMCkgLyAxMDAwLjA7CisJCWRjLT5kY25fc29jLT5mYWJyaWNfYW5k X2RyYW1fYmFuZHdpZHRoX3ZtaWQwcDcyID0gZGMtPmRjbl9zb2MtPm51bWJlcl9vZl9jaGFubmVs cyAqCisJCQkJKGZjbGtzLmRhdGFbZmNsa3MubnVtX2xldmVscyAtIChmY2xrcy5udW1fbGV2ZWxz ID4gMiA/IDMgOiAyKV0uY2xvY2tzX2luX2toeiAvIDEwMDAuMCkKKwkJCQkqIGRkcjRfZHJhbV9m YWN0b3Jfc2luZ2xlX0NoYW5uZWwgLyAxMDAwLjA7CiAJCWRjLT5kY25fc29jLT5mYWJyaWNfYW5k X2RyYW1fYmFuZHdpZHRoX3Zub20wcDggPSBkYy0+ZGNuX3NvYy0+bnVtYmVyX29mX2NoYW5uZWxz ICoKLQkJCQkoY2xrcy5kYXRhW2Nsa3MubnVtX2xldmVscyAtIDJdLmNsb2Nrc19pbl9raHogLyAx MDAwLjApICogZGRyNF9kcmFtX2ZhY3Rvcl9zaW5nbGVfQ2hhbm5lbCAvIDEwMDAuMDsKKwkJCQko ZmNsa3MuZGF0YVtmY2xrcy5udW1fbGV2ZWxzIC0gMl0uY2xvY2tzX2luX2toeiAvIDEwMDAuMCkK KwkJCQkqIGRkcjRfZHJhbV9mYWN0b3Jfc2luZ2xlX0NoYW5uZWwgLyAxMDAwLjA7CiAJCWRjLT5k Y25fc29jLT5mYWJyaWNfYW5kX2RyYW1fYmFuZHdpZHRoX3ZtYXgwcDkgPSBkYy0+ZGNuX3NvYy0+ bnVtYmVyX29mX2NoYW5uZWxzICoKLQkJCQkoY2xrcy5kYXRhW2Nsa3MubnVtX2xldmVscyAtIDFd LmNsb2Nrc19pbl9raHogLyAxMDAwLjApICogZGRyNF9kcmFtX2ZhY3Rvcl9zaW5nbGVfQ2hhbm5l bCAvIDEwMDAuMDsKKwkJCQkoZmNsa3MuZGF0YVtmY2xrcy5udW1fbGV2ZWxzIC0gMV0uY2xvY2tz X2luX2toeiAvIDEwMDAuMCkKKwkJCQkqIGRkcjRfZHJhbV9mYWN0b3Jfc2luZ2xlX0NoYW5uZWwg LyAxMDAwLjA7CiAJfSBlbHNlCiAJCUJSRUFLX1RPX0RFQlVHR0VSKCk7Ci0JaWYgKGRtX3BwX2dl dF9jbG9ja19sZXZlbHNfYnlfdHlwZV93aXRoX3ZvbHRhZ2UoCi0JCQkJY3R4LCBETV9QUF9DTE9D S19UWVBFX0RDRkNMSywgJmNsa3MpICYmCi0JCQkJY2xrcy5udW1fbGV2ZWxzID49IDMpIHsKLQkJ ZGMtPmRjbl9zb2MtPmRjZmNsa3ZfbWluMHA2NSA9IGNsa3MuZGF0YVswXS5jbG9ja3NfaW5fa2h6 IC8gMTAwMC4wOwotCQlkYy0+ZGNuX3NvYy0+ZGNmY2xrdl9taWQwcDcyID0gY2xrcy5kYXRhW2Ns a3MubnVtX2xldmVscyAtIDNdLmNsb2Nrc19pbl9raHogLyAxMDAwLjA7Ci0JCWRjLT5kY25fc29j LT5kY2ZjbGt2X25vbTBwOCA9IGNsa3MuZGF0YVtjbGtzLm51bV9sZXZlbHMgLSAyXS5jbG9ja3Nf aW5fa2h6IC8gMTAwMC4wOwotCQlkYy0+ZGNuX3NvYy0+ZGNmY2xrdl9tYXgwcDkgPSBjbGtzLmRh dGFbY2xrcy5udW1fbGV2ZWxzIC0gMV0uY2xvY2tzX2luX2toeiAvIDEwMDAuMDsKKworCXJlcyA9 IGRtX3BwX2dldF9jbG9ja19sZXZlbHNfYnlfdHlwZV93aXRoX3ZvbHRhZ2UoCisJCQljdHgsIERN X1BQX0NMT0NLX1RZUEVfRENGQ0xLLCAmZGNmY2xrcyk7CisKKwlpZiAocmVzKQorCQlyZXMgPSB2 ZXJpZnlfY2xvY2tfdmFsdWVzKCZkY2ZjbGtzKTsKKworCWlmIChyZXMgJiYgZGNmY2xrcy5udW1f bGV2ZWxzID49IDMpIHsKKwkJZGMtPmRjbl9zb2MtPmRjZmNsa3ZfbWluMHA2NSA9IGRjZmNsa3Mu ZGF0YVswXS5jbG9ja3NfaW5fa2h6IC8gMTAwMC4wOworCQlkYy0+ZGNuX3NvYy0+ZGNmY2xrdl9t aWQwcDcyID0gZGNmY2xrcy5kYXRhW2RjZmNsa3MubnVtX2xldmVscyAtIDNdLmNsb2Nrc19pbl9r aHogLyAxMDAwLjA7CisJCWRjLT5kY25fc29jLT5kY2ZjbGt2X25vbTBwOCA9IGRjZmNsa3MuZGF0 YVtkY2ZjbGtzLm51bV9sZXZlbHMgLSAyXS5jbG9ja3NfaW5fa2h6IC8gMTAwMC4wOworCQlkYy0+ ZGNuX3NvYy0+ZGNmY2xrdl9tYXgwcDkgPSBkY2ZjbGtzLmRhdGFbZGNmY2xrcy5udW1fbGV2ZWxz IC0gMV0uY2xvY2tzX2luX2toeiAvIDEwMDAuMDsKIAl9IGVsc2UKIAkJQlJFQUtfVE9fREVCVUdH RVIoKTsKIAotLSAKMi4xNC4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1n ZngK