From: =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= Subject: [PATCH v2 01/15] drm/fb-helper: Handle function NULL argument Date: Mon, 30 Oct 2017 16:39:37 +0100 Message-ID: <20171030153951.56269-2-noralf@tronnes.org> References: <20171030153951.56269-1-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171030153951.56269-1-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, tomi.valkeinen@ti.com, joonas.lahtinen@linux.intel.com, sw0312.kim@samsung.com, hdegoede@redhat.com, kyungmin.park@samsung.com, thierry.reding@gmail.com, bskeggs@redhat.com, rodrigo.vivi@intel.com, alexander.deucher@amd.com, linux@armlinux.org.uk, intel-gfx@lists.freedesktop.org, christian.koenig@amd.com List-Id: dri-devel@lists.freedesktop.org TWFrZSBmdW5jdGlvbnMgdG9sZXJhdGUgdGhhdCB0aGUgZHJtX2ZiX2hlbHBlciBhcmd1bWVudCBp cyBOVUxMLgpUaGlzIGlzIHVzZWZ1bCBmb3IgZHJpdmVycyB0aGF0IGNvbnRpbnVlIHByb2Jpbmcg d2hlbiBmYmRldiBlbXVsYXRpb24KZmFpbHMgYW5kIG5vdCBoYXZpbmcgdG8gZG8gdGhpcyBjaGVj ayB0aGVtc2VsdmVzLgpVcGRhdGUgZG9jcyBmb3IgZnVuY3Rpb25zIHRoYXQgYWxyZWFkeSBoYW5k bGVzIHRoaXMuCgpTaWduZWQtb2ZmLWJ5OiBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVz Lm9yZz4KUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+ Ci0tLQogZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYyB8IDI4ICsrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxMSBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIv ZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwppbmRleCAxMTZkMWYxMzM3YzcuLjk1NGNk ZDQ4ZGU5MiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYworKysg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCkBAIC0xNTAsNiArMTUwLDkgQEAgaW50 IGRybV9mYl9oZWxwZXJfYWRkX29uZV9jb25uZWN0b3Ioc3RydWN0IGRybV9mYl9oZWxwZXIgKmZi X2hlbHBlciwKIHsKIAlpbnQgZXJyOwogCisJaWYgKCFmYl9oZWxwZXIpCisJCXJldHVybiAwOwor CiAJbXV0ZXhfbG9jaygmZmJfaGVscGVyLT5sb2NrKTsKIAllcnIgPSBfX2RybV9mYl9oZWxwZXJf YWRkX29uZV9jb25uZWN0b3IoZmJfaGVscGVyLCBjb25uZWN0b3IpOwogCW11dGV4X3VubG9jaygm ZmJfaGVscGVyLT5sb2NrKTsKQEAgLTE2MSw3ICsxNjQsNyBAQCBFWFBPUlRfU1lNQk9MKGRybV9m Yl9oZWxwZXJfYWRkX29uZV9jb25uZWN0b3IpOwogLyoqCiAgKiBkcm1fZmJfaGVscGVyX3Npbmds ZV9hZGRfYWxsX2Nvbm5lY3RvcnMoKSAtIGFkZCBhbGwgY29ubmVjdG9ycyB0byBmYmRldgogICog CQkJCQkgICAgICAgZW11bGF0aW9uIGhlbHBlcgotICogQGZiX2hlbHBlcjogZmJkZXYgaW5pdGlh bGl6ZWQgd2l0aCBkcm1fZmJfaGVscGVyX2luaXQKKyAqIEBmYl9oZWxwZXI6IGZiZGV2IGluaXRp YWxpemVkIHdpdGggZHJtX2ZiX2hlbHBlcl9pbml0LCBjYW4gYmUgTlVMTAogICoKICAqIFRoaXMg ZnVuY3Rpb25zIGFkZHMgYWxsIHRoZSBhdmFpbGFibGUgY29ubmVjdG9ycyBmb3IgdXNlIHdpdGgg dGhlIGdpdmVuCiAgKiBmYl9oZWxwZXIuIFRoaXMgaXMgYSBzZXBhcmF0ZSBzdGVwIHRvIGFsbG93 IGRyaXZlcnMgdG8gZnJlZWx5IGFzc2lnbgpAQCAtMTc5LDcgKzE4Miw3IEBAIGludCBkcm1fZmJf aGVscGVyX3NpbmdsZV9hZGRfYWxsX2Nvbm5lY3RvcnMoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZi X2hlbHBlcikKIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9saXN0X2l0ZXIgY29ubl9pdGVyOwogCWlu dCBpLCByZXQgPSAwOwogCi0JaWYgKCFkcm1fZmJkZXZfZW11bGF0aW9uKQorCWlmICghZHJtX2Zi ZGV2X2VtdWxhdGlvbiB8fCAhZmJfaGVscGVyKQogCQlyZXR1cm4gMDsKIAogCW11dGV4X2xvY2so JmZiX2hlbHBlci0+bG9jayk7CkBAIC0yNDUsNiArMjQ4LDkgQEAgaW50IGRybV9mYl9oZWxwZXJf cmVtb3ZlX29uZV9jb25uZWN0b3Ioc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlciwKIHsK IAlpbnQgZXJyOwogCisJaWYgKCFmYl9oZWxwZXIpCisJCXJldHVybiAwOworCiAJbXV0ZXhfbG9j aygmZmJfaGVscGVyLT5sb2NrKTsKIAllcnIgPSBfX2RybV9mYl9oZWxwZXJfcmVtb3ZlX29uZV9j b25uZWN0b3IoZmJfaGVscGVyLCBjb25uZWN0b3IpOwogCW11dGV4X3VubG9jaygmZmJfaGVscGVy LT5sb2NrKTsKQEAgLTQ4NCw3ICs0OTAsNyBAQCBzdGF0aWMgaW50IHJlc3RvcmVfZmJkZXZfbW9k ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyKQogCiAvKioKICAqIGRybV9mYl9oZWxw ZXJfcmVzdG9yZV9mYmRldl9tb2RlX3VubG9ja2VkIC0gcmVzdG9yZSBmYmRldiBjb25maWd1cmF0 aW9uCi0gKiBAZmJfaGVscGVyOiBmYmNvbiB0byByZXN0b3JlCisgKiBAZmJfaGVscGVyOiBkcml2 ZXItYWxsb2NhdGVkIGZiZGV2IGhlbHBlciwgY2FuIGJlIE5VTEwKICAqCiAgKiBUaGlzIHNob3Vs ZCBiZSBjYWxsZWQgZnJvbSBkcml2ZXIncyBkcm0gJmRybV9kcml2ZXIubGFzdGNsb3NlIGNhbGxi YWNrCiAgKiB3aGVuIGltcGxlbWVudGluZyBhbiBmYmNvbiBvbiB0b3Agb2Yga21zIHVzaW5nIHRo aXMgaGVscGVyLiBUaGlzIGVuc3VyZXMgdGhhdApAQCAtNDk4LDcgKzUwNCw3IEBAIGludCBkcm1f ZmJfaGVscGVyX3Jlc3RvcmVfZmJkZXZfbW9kZV91bmxvY2tlZChzdHJ1Y3QgZHJtX2ZiX2hlbHBl ciAqZmJfaGVscGVyKQogCWJvb2wgZG9fZGVsYXllZDsKIAlpbnQgcmV0OwogCi0JaWYgKCFkcm1f ZmJkZXZfZW11bGF0aW9uKQorCWlmICghZHJtX2ZiZGV2X2VtdWxhdGlvbiB8fCAhZmJfaGVscGVy KQogCQlyZXR1cm4gLUVOT0RFVjsKIAogCWlmIChSRUFEX09OQ0UoZmJfaGVscGVyLT5kZWZlcnJl ZF9zZXR1cCkpCkBAIC04ODMsNyArODg5LDcgQEAgRVhQT1JUX1NZTUJPTChkcm1fZmJfaGVscGVy X2FsbG9jX2ZiaSk7CiAKIC8qKgogICogZHJtX2ZiX2hlbHBlcl91bnJlZ2lzdGVyX2ZiaSAtIHVu cmVnaXN0ZXIgZmJfaW5mbyBmcmFtZWJ1ZmZlciBkZXZpY2UKLSAqIEBmYl9oZWxwZXI6IGRyaXZl ci1hbGxvY2F0ZWQgZmJkZXYgaGVscGVyCisgKiBAZmJfaGVscGVyOiBkcml2ZXItYWxsb2NhdGVk IGZiZGV2IGhlbHBlciwgY2FuIGJlIE5VTEwKICAqCiAgKiBBIHdyYXBwZXIgYXJvdW5kIHVucmVn aXN0ZXJfZnJhbWVidWZmZXIsIHRvIHJlbGVhc2UgdGhlIGZiX2luZm8KICAqIGZyYW1lYnVmZmVy IGRldmljZS4gVGhpcyBtdXN0IGJlIGNhbGxlZCBiZWZvcmUgcmVsZWFzaW5nIGFsbCByZXNvdXJj ZXMgZm9yCkBAIC04OTgsNyArOTA0LDcgQEAgRVhQT1JUX1NZTUJPTChkcm1fZmJfaGVscGVyX3Vu cmVnaXN0ZXJfZmJpKTsKIAogLyoqCiAgKiBkcm1fZmJfaGVscGVyX2ZpbmkgLSBmaW5pYWxpemUg YSAmc3RydWN0IGRybV9mYl9oZWxwZXIKLSAqIEBmYl9oZWxwZXI6IGRyaXZlci1hbGxvY2F0ZWQg ZmJkZXYgaGVscGVyCisgKiBAZmJfaGVscGVyOiBkcml2ZXItYWxsb2NhdGVkIGZiZGV2IGhlbHBl ciwgY2FuIGJlIE5VTEwKICAqCiAgKiBUaGlzIGNsZWFucyB1cCBhbGwgcmVtYWluaW5nIHJlc291 cmNlcyBhc3NvY2lhdGVkIHdpdGggQGZiX2hlbHBlci4gTXVzdCBiZQogICogY2FsbGVkIGFmdGVy IGRybV9mYl9oZWxwZXJfdW5saW5rX2ZiaSgpIHdhcyBjYWxsZWQuCkBAIC05MzcsNyArOTQzLDcg QEAgRVhQT1JUX1NZTUJPTChkcm1fZmJfaGVscGVyX2ZpbmkpOwogCiAvKioKICAqIGRybV9mYl9o ZWxwZXJfdW5saW5rX2ZiaSAtIHdyYXBwZXIgYXJvdW5kIHVubGlua19mcmFtZWJ1ZmZlcgotICog QGZiX2hlbHBlcjogZHJpdmVyLWFsbG9jYXRlZCBmYmRldiBoZWxwZXIKKyAqIEBmYl9oZWxwZXI6 IGRyaXZlci1hbGxvY2F0ZWQgZmJkZXYgaGVscGVyLCBjYW4gYmUgTlVMTAogICoKICAqIEEgd3Jh cHBlciBhcm91bmQgdW5saW5rX2ZyYW1lYnVmZmVyIGltcGxlbWVudGVkIGJ5IGZiZGV2IGNvcmUK ICAqLwpAQCAtMTEzOCw3ICsxMTQ0LDcgQEAgRVhQT1JUX1NZTUJPTChkcm1fZmJfaGVscGVyX2Nm Yl9pbWFnZWJsaXQpOwogCiAvKioKICAqIGRybV9mYl9oZWxwZXJfc2V0X3N1c3BlbmQgLSB3cmFw cGVyIGFyb3VuZCBmYl9zZXRfc3VzcGVuZAotICogQGZiX2hlbHBlcjogZHJpdmVyLWFsbG9jYXRl ZCBmYmRldiBoZWxwZXIKKyAqIEBmYl9oZWxwZXI6IGRyaXZlci1hbGxvY2F0ZWQgZmJkZXYgaGVs cGVyLCBjYW4gYmUgTlVMTAogICogQHN1c3BlbmQ6IHdoZXRoZXIgdG8gc3VzcGVuZCBvciByZXN1 bWUKICAqCiAgKiBBIHdyYXBwZXIgYXJvdW5kIGZiX3NldF9zdXNwZW5kIGltcGxlbWVudGVkIGJ5 IGZiZGV2IGNvcmUuCkBAIC0xMTU1LDcgKzExNjEsNyBAQCBFWFBPUlRfU1lNQk9MKGRybV9mYl9o ZWxwZXJfc2V0X3N1c3BlbmQpOwogLyoqCiAgKiBkcm1fZmJfaGVscGVyX3NldF9zdXNwZW5kX3Vu bG9ja2VkIC0gd3JhcHBlciBhcm91bmQgZmJfc2V0X3N1c3BlbmQgdGhhdCBhbHNvCiAgKiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdGFrZXMgdGhlIGNvbnNvbGUgbG9jawot ICogQGZiX2hlbHBlcjogZHJpdmVyLWFsbG9jYXRlZCBmYmRldiBoZWxwZXIKKyAqIEBmYl9oZWxw ZXI6IGRyaXZlci1hbGxvY2F0ZWQgZmJkZXYgaGVscGVyLCBjYW4gYmUgTlVMTAogICogQHN1c3Bl bmQ6IHdoZXRoZXIgdG8gc3VzcGVuZCBvciByZXN1bWUKICAqCiAgKiBBIHdyYXBwZXIgYXJvdW5k IGZiX3NldF9zdXNwZW5kKCkgdGhhdCB0YWtlcyB0aGUgY29uc29sZSBsb2NrLiBJZiB0aGUgbG9j awpAQCAtMjU2OCw3ICsyNTc0LDcgQEAgRVhQT1JUX1NZTUJPTChkcm1fZmJfaGVscGVyX2luaXRp YWxfY29uZmlnKTsKIC8qKgogICogZHJtX2ZiX2hlbHBlcl9ob3RwbHVnX2V2ZW50IC0gcmVzcG9u ZCB0byBhIGhvdHBsdWcgbm90aWZpY2F0aW9uIGJ5CiAgKiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBwcm9iaW5nIGFsbCB0aGUgb3V0cHV0cyBhdHRhY2hlZCB0byB0aGUgZmIKLSAqIEBm Yl9oZWxwZXI6IHRoZSBkcm1fZmJfaGVscGVyCisgKiBAZmJfaGVscGVyOiBkcml2ZXItYWxsb2Nh dGVkIGZiZGV2IGhlbHBlciwgY2FuIGJlIE5VTEwKICAqCiAgKiBTY2FuIHRoZSBjb25uZWN0b3Jz IGF0dGFjaGVkIHRvIHRoZSBmYl9oZWxwZXIgYW5kIHRyeSB0byBwdXQgdG9nZXRoZXIgYQogICog c2V0dXAgYWZ0ZXIgbm90aWZpY2F0aW9uIG9mIGEgY2hhbmdlIGluIG91dHB1dCBjb25maWd1cmF0 aW9uLgpAQCAtMjU5MCw3ICsyNTk2LDcgQEAgaW50IGRybV9mYl9oZWxwZXJfaG90cGx1Z19ldmVu dChzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyKQogewogCWludCBlcnIgPSAwOwogCi0J aWYgKCFkcm1fZmJkZXZfZW11bGF0aW9uKQorCWlmICghZHJtX2ZiZGV2X2VtdWxhdGlvbiB8fCAh ZmJfaGVscGVyKQogCQlyZXR1cm4gMDsKIAogCW11dGV4X2xvY2soJmZiX2hlbHBlci0+bG9jayk7 Ci0tIAoyLjE0LjIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=