Date: Tue, 31 Oct 2017 13:00:05 +1100 From: "Tobin C. Harding" Message-ID: <20171031020005.GC12341@eros> References: <1508986436-31966-1-git-send-email-me@tobin.cc> <1508986436-31966-3-git-send-email-me@tobin.cc> <20171026025838.GG12341@eros> <20171030173322.6ebed7db@gandalf.local.home> <20171030224102.GY12341@eros> <20171030200046.1f40a9dc@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171030200046.1f40a9dc@gandalf.local.home> Subject: [kernel-hardening] Re: [PATCH V8 2/2] printk: hash addresses printed with %p To: Steven Rostedt Cc: kernel-hardening@lists.openwall.com, "Jason A. Donenfeld" , Theodore Ts'o , Linus Torvalds , Kees Cook , Paolo Bonzini , Tycho Andersen , "Roberts, William C" , Tejun Heo , Jordan Glover , Greg KH , Petr Mladek , Joe Perches , Ian Campbell , Sergey Senozhatsky , Catalin Marinas , Will Deacon , Chris Fries , Dave Weinstein , Daniel Micay , Djalal Harouni , linux-kernel@vger.kernel.org List-ID: On Mon, Oct 30, 2017 at 08:00:46PM -0400, Steven Rostedt wrote: > On Tue, 31 Oct 2017 09:41:02 +1100 > "Tobin C. Harding" wrote: > > > > Cool. So I think we need > > > > get_random_bytes(&ptr_key, sizeof(ptr_key)); > > You'll need to add a comment here to describe what ordering the memory > barrier is used against. That is, somewhere else there's something that > needs to see the "true" after the "get_random_bytes" update. Describe > it here. Got it, thanks Tobin.