From: Ingo Molnar Subject: Re: [PATCH v5 2/2] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset() Date: Tue, 31 Oct 2017 10:50:06 +0100 Message-ID: <20171031095006.vq2oawbutnpqn37l@gmail.com> References: <20171019111620.26761-1-hdegoede@redhat.com> <20171019111620.26761-3-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20171019111620.26761-3-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hans de Goede , Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Hans de Goede , Ingo Molnar , dri-devel@lists.freedesktop.org, "H . Peter Anvin" , Daniel Vetter , Thomas Gleixner , intel-gfx List-Id: dri-devel@lists.freedesktop.org CiogSGFucyBkZSBHb2VkZSA8ai53LnIuZGVnb2VkZUBnbWFpbC5jb20+IHdyb3RlOgoKPiBpbnRl bF91bmNvcmVfZm9yY2V3YWtlX3Jlc2V0KCkgZG9lcyBmb3JjZXdha2UgcHV0cyBhbmQgZ2V0cyBh cyBzdWNoCj4gd2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCBuby1vbmUgdHJpZXMgdG8gYWNjZXNz IHRoZSBQVU5JVC0+UE1JQyBidXMKPiAob24gc3lzdGVtcyB3aGVyZSB0aGlzIGJ1cyBpcyBzaGFy ZWQpIHdoaWxlIGl0IHJ1bnMsIG90aGVyd2lzZSBiYWQKPiB0aGluZ3MgaGFwcGVuLgo+IAo+IE5v cm1hbGx5IHRoaXMgaXMgdGFrZW4gY2FyZSBvZiBieSB0aGUgaTkxNV9wbWljX2J1c19hY2Nlc3Nf bm90aWZpZXIoKQo+IHdoaWNoIGRvZXMgYW4gaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9nZXQoRk9S Q0VXQUtFX0FMTCkgd2hlbiBzb21lIG90aGVyCj4gZHJpdmVyIHRyaWVzIHRvIGFjY2VzcyB0aGUg UE1JQyBidXMsIHNvIHRoYXQgbGF0ZXIgZm9yY2V3YWtlIGdldHMgYXJlCj4gbm8tb3BzIChmb3Ig dGhlIGR1cmF0aW9uIG9mIHRoZSBidXMgYWNjZXNzKS4KPiAKPiBCdXQgaW50ZWxfdW5jb3JlX2Zv cmNld2FrZV9yZXNldCBnZXRzIGNhbGxlZCBpbiAzIGNhc2VzOgo+IDEpIEJlZm9yZSByZWdpc3Rl cmluZyB0aGUgcG1pY19idXNfYWNjZXNzX25vdGlmaWVyCj4gMikgQWZ0ZXIgdW5yZWdpc3Rlcmlu ZyB0aGUgcG1pY19idXNfYWNjZXNzX25vdGlmaWVyCj4gMykgVG8gcmVzZXQgZm9yY2V3YWtlIHN0 YXRlIG9uIGEgR1BVIHJlc2V0Cj4gCj4gSW4gYWxsIDMgY2FzZXMgdGhlIGk5MTVfcG1pY19idXNf YWNjZXNzX25vdGlmaWVyKCkgcHJvdGVjdGlvbiBpcwo+IGluc3VmZmljaWVudC4KPiAKPiBUaGlz IGNvbW1pdCBmaXhlcyB0aGlzIHJhY2UgYnkgY2FsbGluZyBpb3NmX21iaV9wdW5pdF9hY3F1aXJl KCkgYmVmb3JlCj4gY2FsbGluZyBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jlc2V0KCkuIEluIHRo ZSBjYXNlIHdoZXJlIGl0IGlzIGNhbGxlZAo+IGRpcmVjdGx5IGFmdGVyIHVucmVnaXN0ZXJpbmcg dGhlIHBtaWNfYnVzX2FjY2Vzc19ub3RpZmllciwgd2UgbmVlZCB0bwo+IGhvbGQgdGhlIHB1bml0 LWxvY2sgb3ZlciBib3RoIGNhbGxzIHRvIGF2b2lkIGEgcmFjZSB3aGVyZQo+IGludGVsX3VuY29y ZV9md19yZWxlYXNlX3RpbWVyKCkgbWF5IGV4ZWN1dGUgYmV0d2VlbiB0aGUgMiBjYWxscy4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUByZWRoYXQuY29tPgo+IFJl dmlld2VkLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gLS0tCj4gQ2hhbmdl cyBpbiB2MjoKPiAtUmViYXNlIG9uIGN1cnJlbnQgKEp1bHkgNnRoIDIwMTcpIGRybS1uZXh0Cj4g Cj4gQ2hhbmdlcyBpbiB2MzoKPiAtS2VlcCBwdW5pdCBhY3F1aXJlZCAvIGxvY2tlZCBvdmVyIHRo ZSB1bnJlZ2lzdGVyICsgZm9yY2V3YWtlX3Jlc2V0Cj4gIGNhbGwgY29tYm8gdG8gYXZvaWQgYSBy YWNlIGhpdHRpbmcgYmV0d2VlbiB0aGUgMiBjYWxscwo+IC1UaGlzIHJlcXVpcmVzIG1vZGlmeWlu ZyBpb3NmX21iaV91bnJlZ2lzdGVyX3BtaWNfYnVzX2FjY2Vzc19ub3RpZmllcgo+ICB0byBub3Qg dGFrZSB0aGUgbG9jayBpdHNlbGYsIHNpbmNlIHdlIGFyZSB0aGUgb25seSB1c2VycyB0aGlzIGlz IGRvbmUKPiAgaW4gdGhpcyBzYW1lIGNvbW1pdAo+IAo+IENoYW5nZXMgaW4gdjQ6Cj4gLUZpeCBt aXNzaW5nIHJlbmFtZSBpbiBkb2MtY29tbWVudAo+IC1BZGQgYW5kIHVzZSBpb3NmX21iaV9hc3Nl cnRfcHVuaXRfYWNxdWlyZWQoKSBoZWxwZXIKPiAtQWRkIG1pc3NpbmcgYWNxdWlyZSBzdXJyb3Vu ZGluZyBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jlc2V0KCkgaW5zaWRlCj4gIGludGVsX3VuY29y ZV9jaGVja19mb3JjZXdha2VfZG9tYWlucygpCj4gLUFkZCBJbXJlJ3MgUmV2aWV3ZWQtYnkKPiAK PiBDaGFuZ2VzIGluIHY1Ogo+IC1TZXBhcmF0ZSBvdXQgYXJjaC94ODYgaW9zZl9tYmkgY2hhbmdl cyBpbnRvIGEgc2VwYXJhdGUgcGF0Y2gKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfdW5jb3JlLmMgICAgICAgICAgIHwgMTcgKysrKysrKysrKysrKy0tLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvc2VsZnRlc3RzL2ludGVsX3VuY29yZS5jIHwgIDMgKysrCj4gIDIgZmlsZXMg Y2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF91bmNvcmUuYwo+IGluZGV4IDhjMmNlODFmMDFjMi4uMGRhODFmYWYzOTgxIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPiBAQCAtMjI5LDYgKzIyOSw3IEBA IGludGVsX3VuY29yZV9md19yZWxlYXNlX3RpbWVyKHN0cnVjdCBocnRpbWVyICp0aW1lcikKPiAg CXJldHVybiBIUlRJTUVSX05PUkVTVEFSVDsKPiAgfQo+ICAKPiArLyogTm90ZSBjYWxsZXJzIG11 c3QgaGF2ZSBhY3F1aXJlZCB0aGUgUFVOSVQtPlBNSUMgYnVzLCBiZWZvcmUgY2FsbGluZyB0aGlz LiAqLwo+ICBzdGF0aWMgdm9pZCBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jlc2V0KHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJCQkgYm9vbCByZXN0b3JlKQo+ICB7Cj4g QEAgLTIzNyw2ICsyMzgsOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jl c2V0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCWludCByZXRyeV9jb3Vu dCA9IDEwMDsKPiAgCWVudW0gZm9yY2V3YWtlX2RvbWFpbnMgZncsIGFjdGl2ZV9kb21haW5zOwo+ ICAKPiArCWlvc2ZfbWJpX2Fzc2VydF9wdW5pdF9hY3F1aXJlZCgpOwo+ICsKPiAgCS8qIEhvbGQg dW5jb3JlLmxvY2sgYWNyb3NzIHJlc2V0IHRvIHByZXZlbnQgYW55IHJlZ2lzdGVyIGFjY2Vzcwo+ ICAJICogd2l0aCBmb3JjZXdha2Ugbm90IHNldCBjb3JyZWN0bHkuIFdhaXQgdW50aWwgYWxsIHBl bmRpbmcKPiAgCSAqIHRpbWVycyBhcmUgcnVuIGJlZm9yZSBob2xkaW5nLgo+IEBAIC00MTYsMTQg KzQxOSwxOCBAQCBzdGF0aWMgdm9pZCBfX2ludGVsX3VuY29yZV9lYXJseV9zYW5pdGl6ZShzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCQkgICBHVF9GSUZPX0NUTF9SQzZf UE9MSUNZX1NUQUxMKTsKPiAgCX0KPiAgCj4gKwlpb3NmX21iaV9wdW5pdF9hY3F1aXJlKCk7Cj4g IAlpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jlc2V0KGRldl9wcml2LCByZXN0b3JlX2ZvcmNld2Fr ZSk7Cj4gKwlpb3NmX21iaV9wdW5pdF9yZWxlYXNlKCk7Cj4gIH0KPiAgCj4gIHZvaWQgaW50ZWxf dW5jb3JlX3N1c3BlbmQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4g LQlpb3NmX21iaV91bnJlZ2lzdGVyX3BtaWNfYnVzX2FjY2Vzc19ub3RpZmllcigKPiArCWlvc2Zf bWJpX3B1bml0X2FjcXVpcmUoKTsKPiArCWlvc2ZfbWJpX3VucmVnaXN0ZXJfcG1pY19idXNfYWNj ZXNzX25vdGlmaWVyX3VubG9ja2VkKAo+ICAJCSZkZXZfcHJpdi0+dW5jb3JlLnBtaWNfYnVzX2Fj Y2Vzc19uYik7Cj4gIAlpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jlc2V0KGRldl9wcml2LCBmYWxz ZSk7Cj4gKwlpb3NmX21iaV9wdW5pdF9yZWxlYXNlKCk7Cj4gIH0KPiAgCj4gIHZvaWQgaW50ZWxf dW5jb3JlX3Jlc3VtZV9lYXJseShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g QEAgLTEzMTUsMTIgKzEzMjIsMTQgQEAgdm9pZCBpbnRlbF91bmNvcmVfaW5pdChzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAo+ICB2b2lkIGludGVsX3VuY29yZV9maW5pKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+IC0JaW9zZl9tYmlfdW5yZWdp c3Rlcl9wbWljX2J1c19hY2Nlc3Nfbm90aWZpZXIoCj4gLQkJJmRldl9wcml2LT51bmNvcmUucG1p Y19idXNfYWNjZXNzX25iKTsKPiAtCj4gIAkvKiBQYXJhbm9pYTogbWFrZSBzdXJlIHdlIGhhdmUg ZGlzYWJsZWQgZXZlcnl0aGluZyBiZWZvcmUgd2UgZXhpdC4gKi8KPiAgCWludGVsX3VuY29yZV9z YW5pdGl6ZShkZXZfcHJpdik7Cj4gKwo+ICsJaW9zZl9tYmlfcHVuaXRfYWNxdWlyZSgpOwo+ICsJ aW9zZl9tYmlfdW5yZWdpc3Rlcl9wbWljX2J1c19hY2Nlc3Nfbm90aWZpZXJfdW5sb2NrZWQoCj4g KwkJJmRldl9wcml2LT51bmNvcmUucG1pY19idXNfYWNjZXNzX25iKTsKPiAgCWludGVsX3VuY29y ZV9mb3JjZXdha2VfcmVzZXQoZGV2X3ByaXYsIGZhbHNlKTsKPiArCWlvc2ZfbWJpX3B1bml0X3Jl bGVhc2UoKTsKPiAgfQo+ICAKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCByZWdfd2hpdGVsaXN0IHsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2ludGVsX3VuY29y ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2ludGVsX3VuY29yZS5jCj4gaW5k ZXggM2NhYzIyZWI0N2NlLi43MzNkODdmZTc3MzcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvc2VsZnRlc3RzL2ludGVsX3VuY29yZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvc2VsZnRlc3RzL2ludGVsX3VuY29yZS5jCj4gQEAgLTE0OCw3ICsxNDgsMTAgQEAgc3Rh dGljIGludCBpbnRlbF91bmNvcmVfY2hlY2tfZm9yY2V3YWtlX2RvbWFpbnMoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcmkKPiAgCWZvcl9lYWNoX3NldF9iaXQob2Zmc2V0LCB2YWxpZCwg RldfUkFOR0UpIHsKPiAgCQlpOTE1X3JlZ190IHJlZyA9IHsgb2Zmc2V0IH07Cj4gIAo+ICsJCWlv c2ZfbWJpX3B1bml0X2FjcXVpcmUoKTsKPiAgCQlpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jlc2V0 KGRldl9wcml2LCBmYWxzZSk7Cj4gKwkJaW9zZl9tYmlfcHVuaXRfcmVsZWFzZSgpOwo+ICsKPiAg CQljaGVja19mb3JfdW5jbGFpbWVkX21taW8oZGV2X3ByaXYpOwo+ICAKPiAgCQkodm9pZClJOTE1 X1JFQUQocmVnKTsKClRoaXMgcGF0Y2ggbG9va3MgbGlrZSBvbmUgbWFzc2l2ZSBsYXllcmluZyB2 aW9sYXRpb24uIFdoeSBkb2VzIHRoZSBHUFUgY29kZSBtdWNrIAp3aXRoIHRoZSB1bmNvcmUgaGFy ZHdhcmU/CgpUaGFua3MsCgoJSW5nbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK