From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915: Don't try to use negative pll_id. Date: Wed, 1 Nov 2017 12:13:42 -0700 Message-ID: <20171101191342.o2lquxgy24rlskob@intel.com> References: <20171101184458.31698-1-rodrigo.vivi@intel.com> <20171101185655.GH10981@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 54A416E005 for ; Wed, 1 Nov 2017 19:13:43 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171101185655.GH10981@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMDEsIDIwMTcgYXQgMDY6NTY6NTVQTSArMDAwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFdlZCwgTm92IDAxLCAyMDE3IGF0IDExOjQ0OjU4QU0gLTA3MDAsIFJvZHJp Z28gVml2aSB3cm90ZToKPiA+IEl0IGlzIHVubGlrZWx5IHdlIGFyZSBnZXR0aW5nIHRoZSAtMSBo ZXJlLgo+ID4gQnV0IGlmIHdlIHByb3BhZ2F0ZSB0aGF0IHBsbF9pZCAtMSB0byB0aGUgcmVzdCBv ZiB0aGUgY29kZQo+ID4gd2UgbWlnaHQgaGF2ZSBmdW5ueSBjYWxjdWxhdGlvbnMgb24gbGlua19j bG9jayBhbmQgd2hvCj4gPiBrbm93cyB3aGF0IHJlZ2lzdGVycyB3ZSBlbmQgdXAgYWNjZXNzaW5n Lgo+ID4gCj4gPiBCZXR0ZXIgdG8gcHJvdGVjdCB0aGUgY29kZS4KPiA+IAo+ID4gQWxzbyBiZXR0 ZXIgd2l0aCBlcnJubyBudW1iZXIgaW5zdGVhZCBvZiBnZW5lcmljIC0xLgo+ID4gCj4gPiBDYzog TWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYt Ynk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jICAgICAgfCAxMCArKysrKysrKysrCj4gPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyB8ICAyICstCj4gPiAgMiBmaWxl cyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RkaS5jCj4gPiBpbmRleCBhY2U2NzRjZDc5YjkuLjJjNmFiZGJmMzNlYSAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gQEAgLTEyODMsNiArMTI4Mywx MSBAQCBzdGF0aWMgdm9pZCBjbmxfZGRpX2Nsb2NrX2dldChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAq ZW5jb2RlciwKPiA+ICAKPiA+ICAJcGxsX2lkID0gaW50ZWxfZ2V0X3NoYXJlZF9kcGxsX2lkKGRl dl9wcml2LCBwaXBlX2NvbmZpZy0+c2hhcmVkX2RwbGwpOwo+ID4gIAo+ID4gKwlpZiAocGxsX2lk IDwgMCkgewo+ID4gKwkJRFJNX0VSUk9SKCJQTEwgbm90IGZvdW5kXG4iKTsKPiA+ICsJCXJldHVy bjsKPiA+ICsJfQo+ID4gKwo+ID4gIAljZmdjcjAgPSBJOTE1X1JFQUQoQ05MX0RQTExfQ0ZHQ1Iw KHBsbF9pZCkpOwo+IAo+IERvbid0IHdlIGhhdmUgdGhlIGRwbGwgc3RhdGUgYWxyZWFkeSByZWFk IG91dD8KPiAKPiBjcnRjX3N0YXRlLT5kbGxfaHdfc3RhdGUuY2ZnY3IwIGV0Yy4/CgpvaCEgd2Ug ZG8hCkFsc28gZHVyaW5nIGNhbGNfd3JwbGxfbGluayB3ZSBzaG91bGQgYmUgdXNpbmcgdGhpcywK c2hvdWxkbid0IHdlPyEKClByb2JhYmx5IG15IGJhZCB3aGVuIGRvaW5nIHRoaXMgY29kZSBsb29r aW5nIHRvIHNrbCBjb2RlLi4uCgpTYW1lIHRoaW5nIG9uIHNrbCBjYXNlLCByaWdodD8hCgo+IAo+ ID4gIAo+ID4gIAlpZiAoY2ZnY3IwICYgRFBMTF9DRkdDUjBfSERNSV9NT0RFKSB7Cj4gPiBAQCAt MTMzNyw2ICsxMzQyLDExIEBAIHN0YXRpYyB2b2lkIHNrbF9kZGlfY2xvY2tfZ2V0KHN0cnVjdCBp bnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4gIAo+ID4gIAlwbGxfaWQgPSBpbnRlbF9nZXRfc2hh cmVkX2RwbGxfaWQoZGV2X3ByaXYsIHBpcGVfY29uZmlnLT5zaGFyZWRfZHBsbCk7Cj4gPiAgCj4g PiArCWlmIChwbGxfaWQgPCAwKSB7Cj4gPiArCQlEUk1fRVJST1IoIlBMTCBub3QgZm91bmRcbiIp Owo+ID4gKwkJcmV0dXJuOwo+ID4gKwl9Cj4gPiArCj4gPiAgCWRwbGxfY3RsMSA9IEk5MTVfUkVB RChEUExMX0NUUkwxKTsKPiA+ICAKPiA+ICAJaWYgKGRwbGxfY3RsMSAmIERQTExfQ1RSTDFfSERN SV9NT0RFKHBsbF9pZCkpIHsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcGxsX21nci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+ ID4gaW5kZXggYTgzYmYxYzM4ZTA1Li5jNGE3ZjM5ZTE3M2EgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gPiBAQCAtMTAyLDcgKzEwMiw3IEBAIGludGVsX2dl dF9zaGFyZWRfZHBsbF9pZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAg ewo+ID4gIAlpZiAoV0FSTl9PTihwbGwgPCBkZXZfcHJpdi0+c2hhcmVkX2RwbGxzfHwKPiA+ICAJ CSAgICBwbGwgPiAmZGV2X3ByaXYtPnNoYXJlZF9kcGxsc1tkZXZfcHJpdi0+bnVtX3NoYXJlZF9k cGxsXSkpCj4gPiAtCQlyZXR1cm4gLTE7Cj4gPiArCQlyZXR1cm4gLUVOT0VOVDsKPiA+ICAKPiA+ ICAJcmV0dXJuIChlbnVtIGludGVsX2RwbGxfaWQpIChwbGwgLSBkZXZfcHJpdi0+c2hhcmVkX2Rw bGxzKTsKPiA+ICB9Cj4gPiAtLSAKPiA+IDIuMTMuNgo+ID4gCj4gPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiAKPiAtLSAKPiBWaWxs ZSBTeXJqw6Rsw6QKPiBJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==