Return-Path: Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:57309 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbdKEPLq (ORCPT ); Sun, 5 Nov 2017 10:11:46 -0500 Date: Sun, 5 Nov 2017 07:11:44 -0800 From: Guenter Roeck To: "Gustavo A. R. Silva" Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v2] watchdog: pcwd_pci: mark expected switch fall-through Message-ID: <20171105151144.GA26894@roeck-us.net> References: <20171103160230.GA9298@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171103160230.GA9298@embeddedor.com> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Fri, Nov 03, 2017 at 11:02:30AM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I replaced "Fall" with a proper > "fall through" comment, which is what GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Guenter Roeck > --- > Changes in v2: > Place the "fall through" comment outside the unconditional code block. > > drivers/watchdog/pcwd_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/pcwd_pci.c b/drivers/watchdog/pcwd_pci.c > index c0d07ee..1f78f09 100644 > --- a/drivers/watchdog/pcwd_pci.c > +++ b/drivers/watchdog/pcwd_pci.c > @@ -545,8 +545,8 @@ static long pcipcwd_ioctl(struct file *file, unsigned int cmd, > return -EINVAL; > > pcipcwd_keepalive(); > - /* Fall */ > } > + /* fall through */ > > case WDIOC_GETTIMEOUT: > return put_user(heartbeat, p);