From: Thomas Petazzoni Date: Mon, 6 Nov 2017 15:46:44 +0100 Subject: [Buildroot] [PATCH 2/2] squid: Add libkrb5 dependency check In-Reply-To: <20171105164235.i5i36g545t3xri7m@tarshish> References: <1509898955-17124-1-git-send-email-nerv@dawncrow.de> <1509898955-17124-2-git-send-email-nerv@dawncrow.de> <20171105164235.i5i36g545t3xri7m@tarshish> Message-ID: <20171106154644.68d6bbea@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Sun, 5 Nov 2017 18:42:35 +0200, Baruch Siach wrote: > On Sun, Nov 05, 2017 at 05:22:35PM +0100, Andr? Hentschel wrote: > > Signed-off-by: Andr? Hentschel > > --- > > package/squid/squid.mk | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/package/squid/squid.mk b/package/squid/squid.mk > > index d334d14..3b3649a 100644 > > --- a/package/squid/squid.mk > > +++ b/package/squid/squid.mk > > @@ -29,7 +29,6 @@ SQUID_CONF_OPTS = \ > > --enable-removal-policies="lru,heap" \ > > --with-filedescriptors=1024 \ > > --disable-ident-lookups \ > > - --without-mit-krb5 \ > > --enable-auth-basic="fake getpwnam" \ > > --enable-auth-digest="file" \ > > --enable-auth-negotiate="wrapper" \ > > @@ -50,6 +49,13 @@ else > > SQUID_CONF_ENV += squid_cv_gnu_atomics=no > > endif > > > > +ifeq ($(BR2_PACKAGE_LIBKRB5),y) > > +SQUID_CONF_OPTS += --without-krb5 > > without? Are you sure this is correct? If so, it needs an explanation comment. > > > +SQUID_DEPENDENCIES += libkrb5 > > +else > > +SQUID_CONF_OPTS += --without-mit-krb5 > > +endif Since a respin is needed, I want to suggest a better commit title too: squid: add optional dependency on libkrb5 Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com