From: Karol Herbst Subject: [PATCH 04/32] hwmon: Properly check for errors Date: Fri, 17 Nov 2017 01:04:08 +0100 Message-ID: <20171117000436.2432-5-karolherbst@gmail.com> References: <20171117000436.2432-1-karolherbst@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171117000436.2432-1-karolherbst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org T3RoZXJ3aXNlIGh3bW9uIGludGVycHJldHMgZXJyb3IgY29kZXMgYXMgcmVhbCB2YWx1ZXMuCgpT aWduZWQtb2ZmLWJ5OiBLYXJvbCBIZXJic3QgPGthcm9saGVyYnN0QGdtYWlsLmNvbT4KUmV2aWV3 ZWQtYnk6IFBpZXJyZSBNb3JlYXUgPHBpZXJyZS5tb3Jyb3dAZnJlZS5mcj4KLS0tCiBkcm0vbm91 dmVhdS9ub3V2ZWF1X2h3bW9uLmMgfCAzMyArKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2RybS9ub3V2ZWF1L25vdXZlYXVfaHdtb24uYyBiL2RybS9ub3V2ZWF1L25vdXZl YXVfaHdtb24uYwppbmRleCA3NDg2ZTRhZi4uNjgzNGUwZmQgMTAwNjQ0Ci0tLSBhL2RybS9ub3V2 ZWF1L25vdXZlYXVfaHdtb24uYworKysgYi9kcm0vbm91dmVhdS9ub3V2ZWF1X2h3bW9uLmMKQEAg LTQ3MCwxOCArNDcwLDIzIEBAIG5vdXZlYXVfZmFuX3JlYWQoc3RydWN0IGRldmljZSAqZGV2LCB1 MzIgYXR0ciwgaW50IGNoYW5uZWwsIGxvbmcgKnZhbCkKIAlzdHJ1Y3QgZHJtX2RldmljZSAqZHJt X2RldiA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwogCXN0cnVjdCBub3V2ZWF1X2RybSAqZHJtID0g bm91dmVhdV9kcm0oZHJtX2Rldik7CiAJc3RydWN0IG52a21fdGhlcm0gKnRoZXJtID0gbnZ4eF90 aGVybSgmZHJtLT5jbGllbnQuZGV2aWNlKTsKKwlpbnQgcmV0OwogCiAJaWYgKCF0aGVybSkKIAkJ cmV0dXJuIC1FT1BOT1RTVVBQOwogCiAJc3dpdGNoIChhdHRyKSB7CiAJY2FzZSBod21vbl9mYW5f aW5wdXQ6Ci0JCSp2YWwgPSBudmttX3RoZXJtX2Zhbl9zZW5zZSh0aGVybSk7CisJCXJldCA9IG52 a21fdGhlcm1fZmFuX3NlbnNlKHRoZXJtKTsKIAkJYnJlYWs7CiAJZGVmYXVsdDoKIAkJcmV0dXJu IC1FT1BOT1RTVVBQOwogCX0KIAorCWlmIChyZXQgPCAwKQorCQlyZXR1cm4gcmV0OworCisJKnZh bCA9IHJldDsKIAlyZXR1cm4gMDsKIH0KIApAQCAtNDkxLDcgKzQ5Niw3IEBAIG5vdXZlYXVfaW5f cmVhZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHUzMiBhdHRyLCBpbnQgY2hhbm5lbCwgbG9uZyAqdmFs KQogCXN0cnVjdCBkcm1fZGV2aWNlICpkcm1fZGV2ID0gZGV2X2dldF9kcnZkYXRhKGRldik7CiAJ c3RydWN0IG5vdXZlYXVfZHJtICpkcm0gPSBub3V2ZWF1X2RybShkcm1fZGV2KTsKIAlzdHJ1Y3Qg bnZrbV92b2x0ICp2b2x0ID0gbnZ4eF92b2x0KCZkcm0tPmNsaWVudC5kZXZpY2UpOwotCWludCBy ZXQ7CisJaW50IHJldCA9IDA7CiAKIAlpZiAoIXZvbHQpCiAJCXJldHVybiAtRU9QTk9UU1VQUDsK QEAgLTQ5OSw3ICs1MDQsOCBAQCBub3V2ZWF1X2luX3JlYWQoc3RydWN0IGRldmljZSAqZGV2LCB1 MzIgYXR0ciwgaW50IGNoYW5uZWwsIGxvbmcgKnZhbCkKIAlzd2l0Y2ggKGF0dHIpIHsKIAljYXNl IGh3bW9uX2luX2lucHV0OgogCQlyZXQgPSBudmttX3ZvbHRfZ2V0KHZvbHQpOwotCQkqdmFsID0g cmV0IDwgMCA/IHJldCA6IChyZXQgLyAxMDAwKTsKKwkJaWYgKHJldCA+PSAwKQorCQkJKnZhbCA9 IHJldCAvIDEwMDA7CiAJCWJyZWFrOwogCWNhc2UgaHdtb25faW5fbWluOgogCQkqdmFsID0gdm9s dC0+bWluX3V2ID4gMCA/ICh2b2x0LT5taW5fdXYgLyAxMDAwKSA6IC1FTk9ERVY7CkBAIC01MTEs NyArNTE3LDcgQEAgbm91dmVhdV9pbl9yZWFkKHN0cnVjdCBkZXZpY2UgKmRldiwgdTMyIGF0dHIs IGludCBjaGFubmVsLCBsb25nICp2YWwpCiAJCXJldHVybiAtRU9QTk9UU1VQUDsKIAl9CiAKLQly ZXR1cm4gMDsKKwlyZXR1cm4gcmV0OwogfQogCiBzdGF0aWMgaW50CkBAIC01MjAsMjEgKzUyNiwy NiBAQCBub3V2ZWF1X3B3bV9yZWFkKHN0cnVjdCBkZXZpY2UgKmRldiwgdTMyIGF0dHIsIGludCBj aGFubmVsLCBsb25nICp2YWwpCiAJc3RydWN0IGRybV9kZXZpY2UgKmRybV9kZXYgPSBkZXZfZ2V0 X2RydmRhdGEoZGV2KTsKIAlzdHJ1Y3Qgbm91dmVhdV9kcm0gKmRybSA9IG5vdXZlYXVfZHJtKGRy bV9kZXYpOwogCXN0cnVjdCBudmttX3RoZXJtICp0aGVybSA9IG52eHhfdGhlcm0oJmRybS0+Y2xp ZW50LmRldmljZSk7CisJaW50IHJldDsKIAogCWlmICghdGhlcm0gfHwgIXRoZXJtLT5hdHRyX2dl dCB8fCAhdGhlcm0tPmZhbl9nZXQpCiAJCXJldHVybiAtRU9QTk9UU1VQUDsKIAogCXN3aXRjaCAo YXR0cikgewogCWNhc2UgaHdtb25fcHdtX2VuYWJsZToKLQkJKnZhbCA9IHRoZXJtLT5hdHRyX2dl dCh0aGVybSwgTlZLTV9USEVSTV9BVFRSX0ZBTl9NT0RFKTsKKwkJcmV0ID0gdGhlcm0tPmF0dHJf Z2V0KHRoZXJtLCBOVktNX1RIRVJNX0FUVFJfRkFOX01PREUpOwogCQlicmVhazsKIAljYXNlIGh3 bW9uX3B3bV9pbnB1dDoKLQkJKnZhbCA9IHRoZXJtLT5mYW5fZ2V0KHRoZXJtKTsKKwkJcmV0ID0g dGhlcm0tPmZhbl9nZXQodGhlcm0pOwogCQlicmVhazsKIAlkZWZhdWx0OgogCQlyZXR1cm4gLUVP UE5PVFNVUFA7CiAJfQogCisJaWYgKHJldCA8IDApCisJCXJldHVybiByZXQ7CisKKwkqdmFsID0g cmV0OwogCXJldHVybiAwOwogfQogCkBAIC01NDQsMTggKzU1NSwyNiBAQCBub3V2ZWF1X3Bvd2Vy X3JlYWQoc3RydWN0IGRldmljZSAqZGV2LCB1MzIgYXR0ciwgaW50IGNoYW5uZWwsIGxvbmcgKnZh bCkKIAlzdHJ1Y3QgZHJtX2RldmljZSAqZHJtX2RldiA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwog CXN0cnVjdCBub3V2ZWF1X2RybSAqZHJtID0gbm91dmVhdV9kcm0oZHJtX2Rldik7CiAJc3RydWN0 IG52a21faWNjc2Vuc2UgKmljY3NlbnNlID0gbnZ4eF9pY2NzZW5zZSgmZHJtLT5jbGllbnQuZGV2 aWNlKTsKKwlpbnQgcmV0OwogCiAJaWYgKCFpY2NzZW5zZSkKIAkJcmV0dXJuIC1FT1BOT1RTVVBQ OwogCiAJc3dpdGNoIChhdHRyKSB7CiAJY2FzZSBod21vbl9wb3dlcl9pbnB1dDoKLQkJKnZhbCA9 IG52a21faWNjc2Vuc2VfcmVhZF9hbGwoaWNjc2Vuc2UpOworCQlyZXQgPSBudmttX2ljY3NlbnNl X3JlYWRfYWxsKGljY3NlbnNlKTsKKwkJaWYgKHJldCA8IDApCisJCQlyZXR1cm4gcmV0OworCQkq dmFsID0gcmV0OwogCQlicmVhazsKIAljYXNlIGh3bW9uX3Bvd2VyX21heDoKKwkJaWYgKGljY3Nl bnNlLT5wb3dlcl93X21heCA8PSAwKQorCQkJcmV0dXJuIC1FTk9ERVY7CiAJCSp2YWwgPSBpY2Nz ZW5zZS0+cG93ZXJfd19tYXg7CiAJCWJyZWFrOwogCWNhc2UgaHdtb25fcG93ZXJfY3JpdDoKKwkJ aWYgKGljY3NlbnNlLT5wb3dlcl93X2NyaXQgPD0gMCkKKwkJCXJldHVybiAtRU5PREVWOwogCQkq dmFsID0gaWNjc2Vuc2UtPnBvd2VyX3dfY3JpdDsKIAkJYnJlYWs7CiAJZGVmYXVsdDoKLS0gCjIu MTUuMAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTm91 dmVhdSBtYWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9ub3V2ZWF1Cg==