From: David Weinehall Subject: Re: [PATCH] drm/i915: add support for specifying DMC firmware override by module param Date: Wed, 22 Nov 2017 18:06:56 +0200 Message-ID: <20171122160655.GA12856@dweineha-mobl3> References: <20171121115129.5182-1-jani.nikula@intel.com> <20171121134307.GA5826@dweineha-mobl3> <873757uwl3.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23FE16E382 for ; Wed, 22 Nov 2017 16:06:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <873757uwl3.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBOb3YgMjEsIDIwMTcgYXQgMTE6NTQ6MTZQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAyMSBOb3YgMjAxNywgRGF2aWQgV2VpbmVoYWxsIDxkYXZpZC53ZWluZWhh bGxAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+IE9uIFR1ZSwgTm92IDIxLCAyMDE3IGF0IDAx OjUxOjI5UE0gKzAyMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+ID4+IFVzZSBpOTE1LmRtY19maXJt d2FyZV9wYXRoIHRvIG92ZXJyaWRlIGRlZmF1bHQgZmlybXdhcmUgZm9yIHRoZSBwbGF0Zm9ybQo+ ID4+IGFuZCBieXBhc3NpbmcgdmVyc2lvbiBjaGVja3MuCj4gPj4gCj4gPj4gU2lnbmVkLW9mZi1i eTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiA+PiAKPiA+PiAtLS0KPiA+ PiAKPiA+PiBVbnRlc3RlZC4KPiA+Cj4gPiBZZWFoLCBpdCBraW5kIG9mIHNob3dzLiAgSXQgZmFp bHMgdG8gY29tcGlsZSA6RAo+IAo+IE9vcHMuIEkgd2FzIGFueGlvdXMgdG8gZ2V0IHRoZSBwYXRj aCBvbiB0aGUgbGlzdCBpbiB0aGUgaGVhdCBvZiBJUkMKPiBkaXNjdXNzaW9uLCBhbmQganVzdCBh ZGRlZCB0aGUgZGlzY2xhaW1lciBpbnN0ZWFkIG9mIGRvaW5nIHRoaXMKPiBwcm9wZXJseS4uLiAq Ymx1c2gqCj4gCj4gPgo+ID4gQnV0IGlmIHlvdSBjaHVjayBpbjoKPiA+Cj4gPiAgICAgICAgIHBh cmFtKGNoYXIgKiwgZG1jX2Zpcm13YXJlX3BhdGgsIE5VTEwpIFwKPiA+Cj4gPiBpbiBpOTE1X3Bh cmFtcy5oCj4gPgo+ID4gVGhpbmdzIHdvcmsgY29ycmVjdGx5IGFuZCB5b3UgY2FuIHVzZToKPiA+ Cj4gPiBUZXN0ZWQtYnk6IERhdmlkIFdlaW5laGFsbCA8ZGF2aWQud2VpbmVoYWxsQGxpbnV4Lmlu dGVsLmNvbT4KPiA+IFJldmlld2VkLWJ5OiBEYXZpZCBXZWluZWhhbGwgPGRhdmlkLndlaW5laGFs bEBsaW51eC5pbnRlbC5jb20+Cj4gCj4gVGhhbmtzLiBCdXQgbGV0J3Mgd2FpdCBmb3IgbW9yZSBp bnB1dCBvbiB3aGV0aGVyIHRoaXMgaXMgcmVhbGx5IHdoYXQKPiBwZW9wbGUgd2FudC4gUGVyaGFw cyB0aGlzIGlzIHVzZWZ1bCAqcmVnYXJkbGVzcyogb2YgdGhlIG91dGNvbWUgb2YgdGhlCj4gb3Ro ZXIgZGlzY3Vzc2lvbnMuCgpGaW5lIGJ5IG1lLiBGV0lXICp3ZSogKGFzIGluIHRoZSBQblAgdGVz dGluZyB0ZWFtKSB3b3VsZCBkZWZpbml0ZWx5CmJlbmVmaXQgaWYgdGhpcyBwYXRjaCBnb3QgbWVy Z2VkLCBzaW5jZSB3ZSdkIGJlIGFibGUgdG8gc2ltcGxpZnkKYXV0b21hdGVkIHRlc3Rpbmcgb2Yg ZGlmZmVyZW50IHZlcnNpb25zIG9mIERNQy4KCj4gQlIsCj4gSmFuaS4KPiAKPiAKPiA+Cj4gPj4g LS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGFyYW1zLmMgfCAzICsrKwo+ID4+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYyAgIHwgOSArKysrKysrLS0KPiA+PiAg MiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4+IAo+ ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BhcmFtcy5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wYXJhbXMuYwo+ID4+IGluZGV4IDMzMjgxNDdiNDg2My4u YzExYWQ2ZDY3ZmE5IDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cGFyYW1zLmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BhcmFtcy5jCj4g Pj4gQEAgLTE3MSw2ICsxNzEsOSBAQCBpOTE1X3BhcmFtX25hbWVkX3Vuc2FmZShndWNfZmlybXdh cmVfcGF0aCwgY2hhcnAsIDA0MDAsCj4gPj4gIGk5MTVfcGFyYW1fbmFtZWRfdW5zYWZlKGh1Y19m aXJtd2FyZV9wYXRoLCBjaGFycCwgMDQwMCwKPiA+PiAgCSJIdUMgZmlybXdhcmUgcGF0aCB0byB1 c2UgaW5zdGVhZCBvZiB0aGUgZGVmYXVsdCBvbmUiKTsKPiA+PiAgCj4gPj4gK2k5MTVfcGFyYW1f bmFtZWRfdW5zYWZlKGRtY19maXJtd2FyZV9wYXRoLCBjaGFycCwgMDQwMCwKPiA+PiArCSJETUMg ZmlybXdhcmUgcGF0aCB0byB1c2UgaW5zdGVhZCBvZiB0aGUgZGVmYXVsdCBvbmUiKTsKPiA+PiAr Cj4gPj4gIGk5MTVfcGFyYW1fbmFtZWRfdW5zYWZlKGVuYWJsZV9kcF9tc3QsIGJvb2wsIDA2MDAs Cj4gPj4gIAkiRW5hYmxlIG11bHRpLXN0cmVhbSB0cmFuc3BvcnQgKE1TVCkgZm9yIG5ldyBEaXNw bGF5UG9ydCBzaW5rcy4gKGRlZmF1bHQ6IHRydWUpIik7Cj4gPj4gIAo+ID4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Nzci5jCj4gPj4gaW5kZXggNzdkOGIzZDQ4M2NhLi44MmRiMzc2ZWM3ZTEgMTAwNjQ0 Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3NyLmMKPiA+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYwo+ID4+IEBAIC0yOTYsNyArMjk2LDEwIEBA IHN0YXRpYyB1aW50MzJfdCAqcGFyc2VfY3NyX2Z3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwKPiA+PiAgCj4gPj4gIAljc3ItPnZlcnNpb24gPSBjc3NfaGVhZGVyLT52ZXJzaW9u Owo+ID4+ICAKPiA+PiAtCWlmIChJU19DQU5OT05MQUtFKGRldl9wcml2KSkgewo+ID4+ICsJaWYg KGNzci0+ZndfcGF0aCA9PSBpOTE1X21vZHBhcmFtcy5kbWNfZmlybXdhcmVfcGF0aCkgewo+ID4+ ICsJCS8qIEJ5cGFzcyB2ZXJzaW9uIGNoZWNrIGZvciBmaXJtd2FyZSBvdmVycmlkZS4gKi8KPiA+ PiArCQlyZXF1aXJlZF92ZXJzaW9uID0gY3NyLT52ZXJzaW9uOwo+ID4+ICsJfSBlbHNlIGlmIChJ U19DQU5OT05MQUtFKGRldl9wcml2KSkgewo+ID4+ICAJCXJlcXVpcmVkX3ZlcnNpb24gPSBDTkxf Q1NSX1ZFUlNJT05fUkVRVUlSRUQ7Cj4gPj4gIAl9IGVsc2UgaWYgKElTX0dFTUlOSUxBS0UoZGV2 X3ByaXYpKSB7Cj4gPj4gIAkJcmVxdWlyZWRfdmVyc2lvbiA9IEdMS19DU1JfVkVSU0lPTl9SRVFV SVJFRDsKPiA+PiBAQCAtNDUxLDcgKzQ1NCw5IEBAIHZvaWQgaW50ZWxfY3NyX3Vjb2RlX2luaXQo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4+ICAJaWYgKCFIQVNfQ1NSKGRl dl9wcml2KSkKPiA+PiAgCQlyZXR1cm47Cj4gPj4gIAo+ID4+IC0JaWYgKElTX0NBTk5PTkxBS0Uo ZGV2X3ByaXYpKQo+ID4+ICsJaWYgKGk5MTVfbW9kcGFyYW1zLmRtY19maXJtd2FyZV9wYXRoKQo+ ID4+ICsJCWNzci0+ZndfcGF0aCA9IGk5MTVfbW9kcGFyYW1zLmRtY19maXJtd2FyZV9wYXRoOwo+ ID4+ICsJZWxzZSBpZiAoSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpCj4gPj4gIAkJY3NyLT5md19w YXRoID0gSTkxNV9DU1JfQ05MOwo+ID4+ICAJZWxzZSBpZiAoSVNfR0VNSU5JTEFLRShkZXZfcHJp dikpCj4gPj4gIAkJY3NyLT5md19wYXRoID0gSTkxNV9DU1JfR0xLOwo+ID4+IC0tIAo+ID4+IDIu MTEuMAo+ID4+IAo+ID4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCj4gPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4+IEludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiA+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNv dXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK