From: Hangbin Liu Subject: Re: [PATCH net] geneve: only configure or fill UDP_ZERO_CSUM6_RX/TX info when CONFIG_IPV6 Date: Thu, 23 Nov 2017 21:01:56 +0800 Message-ID: <20171123130155.GB13972@leo.usersys.redhat.com> References: <1511407644-27357-1-git-send-email-liuhangbin@gmail.com> <20171123133526.393b5aa5@elisabeth> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Eric Garver , Pravin B Shelar , "David S. Miller" To: Stefano Brivio Return-path: Received: from mail-pg0-f53.google.com ([74.125.83.53]:45422 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbdKWNCH (ORCPT ); Thu, 23 Nov 2017 08:02:07 -0500 Received: by mail-pg0-f53.google.com with SMTP id 207so13994834pgc.12 for ; Thu, 23 Nov 2017 05:02:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171123133526.393b5aa5@elisabeth> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Nov 23, 2017 at 01:35:26PM +0100, Stefano Brivio wrote: > On Thu, 23 Nov 2017 11:27:24 +0800 > Hangbin Liu wrote: > > > Stefano pointed that configure or show UDP_ZERO_CSUM6_RX/TX info doesn't > > make sense if we haven't enabled CONFIG_IPV6. Fix it by adding > > if IS_ENABLED(CONFIG_IPV6) check. > > Thanks for fixing this. I would add: > > Suggested-by: Stefano Brivio > Fixes: abe492b4f50c ("geneve: UDP checksum configuration via netlink") > Fixes: fd7eafd02121 ("geneve: fix fill_info when link down") Thanks Stefano for help adding these. > > > Signed-off-by: Hangbin Liu > > Reviewed-by: Stefano Brivio > Regards Hangbin