Return-Path: Received: from 9pmail.ess.barracuda.com ([64.235.150.225]:47862 "EHLO 9pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbdK0MlB (ORCPT ); Mon, 27 Nov 2017 07:41:01 -0500 Date: Mon, 27 Nov 2017 12:40:36 +0000 From: James Hogan To: CC: , , Subject: Re: WTF: patch "[PATCH] MIPS: pci: Remove KERN_WARN instance inside the mt7620 driver" was seriously submitted to be applied to the 4.9-stable tree? Message-ID: <20171127124036.GA11276@jhogan-linux.mipstec.com> References: <1511786146225230@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x+6KMIRAuhnl3hBn" Content-Disposition: inline In-Reply-To: <1511786146225230@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Greg, On Mon, Nov 27, 2017 at 01:35:46PM +0100, gregkh@linuxfoundation.org wrote: > The patch below was submitted to be applied to the 4.9-stable tree. >=20 > I fail to see how this patch meets the stable kernel rules as found at > Documentation/process/stable-kernel-rules.rst. >=20 > I could be totally wrong, and if so, please respond to=20 > and let me know why this patch should be > applied. Otherwise, it is now dropped from my patch queues, never to be > seen again. I should have adjusted the commit message. KERN_WARN doesn't exist so it actually fixes a build error as well as switching to pr_warn(). Cheers James >=20 > thanks, >=20 > greg k-h >=20 > ------------------ original commit in Linus's tree ------------------ >=20 > From 8593b18ad348733b5d5ddfa0c79dcabf51dff308 Mon Sep 17 00:00:00 2001 > From: John Crispin > Date: Mon, 20 Feb 2017 10:29:43 +0100 > Subject: [PATCH] MIPS: pci: Remove KERN_WARN instance inside the mt7620 d= river >=20 > Switch the printk() call to the prefered pr_warn() api. >=20 > Fixes: 7e5873d3755c ("MIPS: pci: Add MT7620a PCIE driver") > Signed-off-by: John Crispin > Cc: Ralf Baechle > Cc: linux-mips@linux-mips.org > Cc: # 4.5+ > Patchwork: https://patchwork.linux-mips.org/patch/15321/ > Signed-off-by: James Hogan >=20 > diff --git a/arch/mips/pci/pci-mt7620.c b/arch/mips/pci/pci-mt7620.c > index 22e4c22e750b..1a0b80a1cc4a 100644 > --- a/arch/mips/pci/pci-mt7620.c > +++ b/arch/mips/pci/pci-mt7620.c > @@ -120,7 +120,7 @@ static int wait_pciephy_busy(void) > else > break; > if (retry++ > WAITRETRY_MAX) { > - printk(KERN_WARN "PCIE-PHY retry failed.\n"); > + pr_warn("PCIE-PHY retry failed.\n"); > return -1; > } > } >=20 --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEd80NauSabkiESfLYbAtpk944dnoFAlocB8QACgkQbAtpk944 dnrkHg//RwejTqBBGOQ3nXWO+BVMuHOcmGnVnxwBXrBfNPX+TbhYASJqNkD2Qiak /ikdwC/jfIsiUUAHLmUfj5YHg2pazsybhYFP2MTgA1+D1TXkVMNfIoZBi8x/Z/ru zMzJVeFpFBIJn1xRhcgSOQh+XTG/T4QIIF1QSL7427XkU1Zv/TuCFpQMziaLaMdk 62mFt6v7MdvHymWw7h45SaiZwjaBlSGo5lswXYdSS26LTYjhbMojoD2Rc7Waujpi 2RhSOwczrYM8ntlTJr7lekFg+pXWWOA79/4AcVefTXWvdn2R2ClNMAEkFO/EJxJ4 L3jv9zQRcph2BvBZ+PkhQcZd+VgLIws8Ip5LLpl+S5V5G48yaDHmb4lhs6yqQDBI g0Lj90y9siwBk2WuPVUsK7XSVzemhWhIOEgc6v2NNWnaFTYF/kYqwQj9pYqE7/CF d9gW9GgaA9qygPcSDaJqHlvbn+1wyq33GBwEecIlJ0x1qSeFBKJ+d0oMLbPVAcIL ZlSw1qGpW8y7/JdOf8FFS44HMRFSWaSUubB6KC/6iStsJvBtc7vfAKGwMbZk3uJF Nl+p5Ev3dJ4WBX5U078KRUdJVx5GXlag0aiaeFrrJbM8k+1kxQEKZvSZnnrSrQDF EAlmnNNPbF8gxpnplXsKo6EH6aAnjqwt6IX5tc1GDuW0OUYRHnA= =ffdo -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn--