Return-Path: <linux-kernel-owner@vger.kernel.org>
Date: Mon, 27 Nov 2017 16:56:47 +0100
From: Jan Kara <jack@suse.cz>
To: Chao Yu <chao@kernel.org>
Cc: jack@suse.com, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, Chao Yu <yuchao0@huawei.com>
Subject: Re: [PATCH v2] quota: propagate error from __dquot_initialize
Message-ID: <20171127155647.GD5977@quack2.suse.cz>
References: <20171123152101.5864-1-chao@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171123152101.5864-1-chao@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu 23-11-17 23:21:01, Chao Yu wrote:
> @@ -2364,10 +2370,11 @@ static int vfs_load_quota_inode(struct inode *inode, int type, int format_id,
>  	dqopt->flags |= dquot_state_flag(flags, type);
>  	spin_unlock(&dq_state_lock);
>  
> -	add_dquot_ref(sb, type);
> -
> -	return 0;
> +	error = add_dquot_ref(sb, type);
> +	if (error)
> +		dquot_disable(sb, type, dqopt->flags);

Why dqopt->flags? If anything these flags are shifted by user/group/project
shift and combined together for all the types. You need to just pass
'flags' here. Other than that the patch looks good.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR