Received: from eggs.gnu.org ([2001:4830:134:3::10]:39904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJdF5-0006z4-L2 for qemu-devel@nongnu.org; Tue, 28 Nov 2017 05:35:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJdF1-0003n5-PX for qemu-devel@nongnu.org; Tue, 28 Nov 2017 05:35:55 -0500 Date: Tue, 28 Nov 2017 11:35:46 +0100 From: Cornelia Huck Message-ID: <20171128113546.7f3f2b38.cohuck@redhat.com> In-Reply-To: <1511816136-30068-1-git-send-email-walling@linux.vnet.ibm.com> References: <1511816136-30068-1-git-send-email-walling@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 0/5] (FIXED) Interactive Boot Menu for DASD and SCSI Guests on s390x List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Collin L. Walling" Cc: borntraeger@de.ibm.com, frankja@linux.vnet.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org On Mon, 27 Nov 2017 15:55:31 -0500 "Collin L. Walling" wrote: > These patches implement a boot menu for ECKD DASD and SCSI guests on s390x. > The menu will only appear if the disk has been configured for IPL with the > zIPL tool and with the following QEMU command line options: > > -boot menu=on[,splash-time=X] and/or -machine loadparm='prompt' > > or via the following libvirt domain xml: > > > > > > or > > > ... > > > > Where X is some positive integer representing time in milliseconds. > > Loadparm will override all boot options. I have a bit of trouble parsing that last sentence: Do you mean a loadparm other than 'prompt' will disable the menu and just boot the specified entry, without any delay? (That's what would make most sense to me.) > > Collin L. Walling (5): > s390-ccw: update libc.h > s390-ccw: ipl structs for eckd cdl/ldl > s390-ccw: parse and set boot menu options > s390-ccw: interactive boot menu for eckd dasd > s390-ccw: interactive boot menu for scsi > > hw/s390x/ipl.c | 23 +++++++ > hw/s390x/ipl.h | 8 ++- > pc-bios/s390-ccw/Makefile | 2 +- > pc-bios/s390-ccw/bootmap.c | 110 ++++++++++++++++++++++++++++------ > pc-bios/s390-ccw/bootmap.h | 73 +++++++++++++---------- > pc-bios/s390-ccw/iplb.h | 8 ++- > pc-bios/s390-ccw/libc.h | 94 +++++++++++++++++++++++++++++ > pc-bios/s390-ccw/main.c | 35 +++++------ > pc-bios/s390-ccw/menu.c | 122 +++++++++++++++++++++++++++++++++++++ > pc-bios/s390-ccw/s390-ccw.h | 7 +++ > pc-bios/s390-ccw/sclp.c | 142 +++++++++++++++++++++++++++++++++++++++++--- > 11 files changed, 546 insertions(+), 78 deletions(-) > create mode 100644 pc-bios/s390-ccw/menu.c >