Received: from eggs.gnu.org ([2001:4830:134:3::10]:40058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eK3b9-00030J-IF for qemu-devel@nongnu.org; Wed, 29 Nov 2017 09:44:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eK3b6-0002uK-Gy for qemu-devel@nongnu.org; Wed, 29 Nov 2017 09:44:27 -0500 Date: Wed, 29 Nov 2017 15:44:16 +0100 From: Cornelia Huck Message-ID: <20171129154416.0edc2253.cohuck@redhat.com> In-Reply-To: References: <20171128203326.6062-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.12 00/15] s390x/tcg: cleanup and fix program interrupts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: Thomas Huth , qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Christian Borntraeger , Alexander Graf , Richard Henderson On Wed, 29 Nov 2017 15:06:33 +0100 David Hildenbrand wrote: > On 29.11.2017 14:51, Thomas Huth wrote: > > On 28.11.2017 21:33, David Hildenbrand wrote: > >> I have quite some patches on my queue for 2.12. (booting Fedora 26/27 > >> guests, floating interrupts, machine checks, missing instructions ...) > >> > >> So let's start slowly :) This series gets rid of program_interrupt() and > >> potential_page_fault(). We now always properly restore the cpu state when > >> injecting/delivering a program interrupt. So there is no need to update > >> the state via potential_page_fault() anymore. > > > > I think this series is basically a very good idea! But... > > OK, this is kind of bike-shed-painting now, but since we're currently in > > hard freeze anyway and got plenty of time for discussion: > > Something that bothers me a little bit is the name of the new function > > "program_interrupt_ra()" ... that would IMHO be OK if the old function > > "program_interrupt" would still stay, but since that is removed and the > > _ra function is the only generic way that is left to inject a program > > interrupt, could we maybe name the new function somewhat nicer right > > from the start? Something like "s390_program_interrupt" maybe (which is > > similar to tcg_s390_program_interrupt and kvm_s390_program_interrupt > > that we have already)? > > Sure I can do that, other opinions? Fine with me as well.