Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:43730 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754242AbdLDOBo (ORCPT ); Mon, 4 Dec 2017 09:01:44 -0500 Date: Mon, 4 Dec 2017 15:01:46 +0100 From: Greg KH To: Andy Lutomirski Cc: Andy Lutomirski , Borislav Petkov , Brian Gerst , Dave Hansen , Josh Poimboeuf , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Linus Torvalds , stable , stable-commits@vger.kernel.org Subject: Re: Patch "x86/entry/64: Add missing irqflags tracing to native_load_gs_index()" has been added to the 4.9-stable tree Message-ID: <20171204140146.GB8744@kroah.com> References: <1511786461176251@kroah.com> <20171130084456.GA31634@kroah.com> <4758E7DE-0249-482B-9EDC-0B33EF864805@amacapital.net> <20171204120215.GA12773@kroah.com> <8F07AA65-5620-4B6C-B077-1F291984A587@amacapital.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8F07AA65-5620-4B6C-B077-1F291984A587@amacapital.net> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Dec 04, 2017 at 05:52:55AM -0800, Andy Lutomirski wrote: > > > > On Dec 4, 2017, at 4:02 AM, Greg KH wrote: > > > >> On Thu, Nov 30, 2017 at 10:50:22AM -0800, Andy Lutomirski wrote: > >>> On Thu, Nov 30, 2017 at 6:29 AM, Andy Lutomirski wrote: > >>> > >>> > >>>>> On Nov 30, 2017, at 12:44 AM, Greg KH wrote: > >>>>> > >>>>> On Wed, Nov 29, 2017 at 08:23:10AM -0800, Andy Lutomirski wrote: > >>>>> If this hasn't been released yet, please hold off. It's buggy. > >>>> > >>>> Ah crap, I missed this and just released it. Is there a fix for this in > >>>> Linus's tree? How "buggy" is it? > >>> > >>> It breaks suspend/resume on some configuration that I haven't quite figured out. I think it only happens if (lockdep is on and some other unknown condition occurs) or (ftrace is actively tracing irq flags). I have a fix, but I was waiting to for the OP to test it. > >>> > >>> I'll send the fix Linusward later today without the Tested-by if I don't hear anything. > >> > >> I think the thing to do is to revert the patch from -stable. The bug > >> it fixes is very minor, and the regression is that it made a > >> pre-existing bug in some nearly-undebuggable core resume code much > >> easier to hit. I don't feel comfortable with a backport of the latter > >> fix until it has a good long soak in Linus' tree. > > > > Ok, now reverted. Should I do the same thing for the patch in > > 4.14-stable as well? > > Yes please. Great, now done. greg k-h