From: Roman Kagan Subject: Re: [PATCH v2 1/2] kvm:x86: factor out kvm.arch.hyperv (de)init Date: Thu, 7 Dec 2017 19:47:58 +0300 Message-ID: <20171207164757.GA22294@rkaganb.sw.ru> References: <20171207141816.1890-1-rkagan@virtuozzo.com> <20171207141816.1890-2-rkagan@virtuozzo.com> <62d62181-3162-f526-738b-fb7651786b74@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , "Denis V. Lunev" , Konrad Rzeszutek Wilk , Vitaly Kuznetsov To: David Hildenbrand Return-path: Received: from mail-he1eur01hn0237.outbound.protection.outlook.com ([104.47.0.237]:16000 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754051AbdLGQsQ (ORCPT ); Thu, 7 Dec 2017 11:48:16 -0500 Content-Disposition: inline In-Reply-To: <62d62181-3162-f526-738b-fb7651786b74@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Dec 07, 2017 at 04:50:52PM +0100, David Hildenbrand wrote: > On 07.12.2017 15:18, Roman Kagan wrote: > > Move kvm.arch.hyperv initialization and cleanup to separate functions. > > > > For now only a mutex is inited in the former, and the latter is empty; > > more stuff will go in there in a followup patch. > > > > Signed-off-by: Roman Kagan > > --- > > v1 -> v2: > > - fix subject prefix > > should be "kvm: x86: " ;) > > > @@ -8158,6 +8157,8 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) > > INIT_DELAYED_WORK(&kvm->arch.kvmclock_update_work, kvmclock_update_fn); > > INIT_DELAYED_WORK(&kvm->arch.kvmclock_sync_work, kvmclock_sync_fn); > > > > + kvm_hv_init_vm(kvm); > > + > > wonder if that empty line is really needed. Compensating for the missing space in the subject prefix ;) I'll kill it when respinning (to take into account your comments to patch 2/2). Thanks, Roman.