From: Daniel Vetter Subject: Re: [PATCH] drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers Date: Fri, 8 Dec 2017 11:09:42 +0100 Message-ID: <20171208100942.65fmirggukebsacs@phenom.ffwll.local> References: <20171208095436.63626-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20171208095436.63626-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBEZWMgMDgsIDIwMTcgYXQgMTA6NTQ6MzZBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gbG9ja19hbGxfY3R4IGluIHNldHBsYW5lX2ludGVybmFsIG1heSByZXR1cm4g LUVJTlRSLCBhbmQKPiBfX3NldHBsYW5lX2ludGVybmFsIGNvdWxkIHJldHVybiAtRURFQURMSy4g TWFraW5nIG1vcmUKPiBzcGVjaWFsIGNhc2VzIGZvciBmYiB3b3VsZCBtYWtlIHRoZSBjb2RlIGV2 ZW4gaGFyZGVyIHRvCj4gcmVhZCwgc28gdGhlIGVhc2llc3Qgc29sdXRpb24gaXMgbm90IHRha2lu ZyBvdmVyIHRoZSBmYgo+IHJlZmNvdW50LCBhbmQgbWFraW5nIGNhbGxlcnMgcmVzcG9uc2libGUg Zm9yIGRyb3BwaW5nCj4gdGhlIHJlZi4KPiAKPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVk ZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNzA3Cj4gRml4ZXM6IDEzNzM2YmEzYjM4YiAo ImRybS9sZWdhY3k6IENvbnZlcnQgc2V0cGxhbmUgaW9jdGwgbG9ja2luZyB0byBpbnRlcnJ1cHRp YmxlLiIpCj4gVGVzdGNhc2U6IGttc19hdG9taWNfaW50ZXJydXB0aWJsZQo+IFNpZ25lZC1vZmYt Ynk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+ CgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KClBs ZWFzZSBwdXNoIHRvIGRybS1taXNjLWZpeGVzIGFzIHNvb24gYXMgQ0kgYXBwcm92ZXMgaXQgZnVs bHkgKHdoaWNoIGlzCnByb2JhYmx5IG5leHQgTW9uZGF5LCBubyBydXNoKS4KLURhbmllbAoKPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jIHwgNDIgKysrKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25z KCspLCAyMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9wbGFuZS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jCj4gaW5kZXggMzdhOTNjZGZm YjRhLi4yYzkwNTE5NTc2YTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFu ZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jCj4gQEAgLTU1OCwxMSArNTU4 LDEwIEBAIGludCBkcm1fcGxhbmVfY2hlY2tfcGl4ZWxfZm9ybWF0KGNvbnN0IHN0cnVjdCBkcm1f cGxhbmUgKnBsYW5lLCB1MzIgZm9ybWF0KQo+ICB9Cj4gIAo+ICAvKgo+IC0gKiBzZXRwbGFuZV9p bnRlcm5hbCAtIHNldHBsYW5lIGhhbmRsZXIgZm9yIGludGVybmFsIGNhbGxlcnMKPiArICogX19z ZXRwbGFuZV9pbnRlcm5hbCAtIHNldHBsYW5lIGhhbmRsZXIgZm9yIGludGVybmFsIGNhbGxlcnMK PiAgICoKPiAtICogTm90ZSB0aGF0IHdlIGFzc3VtZSBhbiBleHRyYSByZWZlcmVuY2UgaGFzIGFs cmVhZHkgYmVlbiB0YWtlbiBvbiBmYi4gIElmIHRoZQo+IC0gKiB1cGRhdGUgZmFpbHMsIHRoaXMg cmVmZXJlbmNlIHdpbGwgYmUgZHJvcHBlZCBiZWZvcmUgcmV0dXJuOyBpZiBpdCBzdWNjZWVkcywK PiAtICogdGhlIHByZXZpb3VzIGZyYW1lYnVmZmVyIChpZiBhbnkpIHdpbGwgYmUgdW5yZWZlcmVu Y2VkIGluc3RlYWQuCj4gKyAqIFRoaXMgZnVuY3Rpb24gd2lsbCB0YWtlIGEgcmVmZXJlbmNlIG9u IHRoZSBuZXcgZmIgZm9yIHRoZSBwbGFuZQo+ICsgKiBvbiBzdWNjZXNzLgo+ICAgKgo+ICAgKiBz cmNfe3gseSx3LGh9IGFyZSBwcm92aWRlZCBpbiAxNi4xNiBmaXhlZCBwb2ludCBmb3JtYXQKPiAg ICovCj4gQEAgLTYzMCwxNCArNjI5LDEyIEBAIHN0YXRpYyBpbnQgX19zZXRwbGFuZV9pbnRlcm5h bChzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgCWlmICghcmV0KSB7Cj4gIAkJcGxhbmUtPmNy dGMgPSBjcnRjOwo+ICAJCXBsYW5lLT5mYiA9IGZiOwo+IC0JCWZiID0gTlVMTDsKPiArCQlkcm1f ZnJhbWVidWZmZXJfZ2V0KHBsYW5lLT5mYik7Cj4gIAl9IGVsc2Ugewo+ICAJCXBsYW5lLT5vbGRf ZmIgPSBOVUxMOwo+ICAJfQo+ICAKPiAgb3V0Ogo+IC0JaWYgKGZiKQo+IC0JCWRybV9mcmFtZWJ1 ZmZlcl9wdXQoZmIpOwo+ICAJaWYgKHBsYW5lLT5vbGRfZmIpCj4gIAkJZHJtX2ZyYW1lYnVmZmVy X3B1dChwbGFuZS0+b2xkX2ZiKTsKPiAgCXBsYW5lLT5vbGRfZmIgPSBOVUxMOwo+IEBAIC02ODUs NiArNjgyLDcgQEAgaW50IGRybV9tb2RlX3NldHBsYW5lKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHZvaWQgKmRhdGEsCj4gIAlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZTsKPiAgCXN0cnVjdCBkcm1f Y3J0YyAqY3J0YyA9IE5VTEw7Cj4gIAlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IE5VTEw7 Cj4gKwlpbnQgcmV0Owo+ICAKPiAgCWlmICghZHJtX2NvcmVfY2hlY2tfZmVhdHVyZShkZXYsIERS SVZFUl9NT0RFU0VUKSkKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiBAQCAtNzE3LDE1ICs3MTUsMTYg QEAgaW50IGRybV9tb2RlX3NldHBsYW5lKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRh dGEsCj4gIAkJfQo+ICAJfQo+ICAKPiAtCS8qCj4gLQkgKiBzZXRwbGFuZV9pbnRlcm5hbCB3aWxs IHRha2UgY2FyZSBvZiBkZXJlZidpbmcgZWl0aGVyIHRoZSBvbGQgb3IgbmV3Cj4gLQkgKiBmcmFt ZWJ1ZmZlciBkZXBlbmRpbmcgb24gc3VjY2Vzcy4KPiAtCSAqLwo+IC0JcmV0dXJuIHNldHBsYW5l X2ludGVybmFsKHBsYW5lLCBjcnRjLCBmYiwKPiAtCQkJCSBwbGFuZV9yZXEtPmNydGNfeCwgcGxh bmVfcmVxLT5jcnRjX3ksCj4gLQkJCQkgcGxhbmVfcmVxLT5jcnRjX3csIHBsYW5lX3JlcS0+Y3J0 Y19oLAo+IC0JCQkJIHBsYW5lX3JlcS0+c3JjX3gsIHBsYW5lX3JlcS0+c3JjX3ksCj4gLQkJCQkg cGxhbmVfcmVxLT5zcmNfdywgcGxhbmVfcmVxLT5zcmNfaCk7Cj4gKwlyZXQgPSBzZXRwbGFuZV9p bnRlcm5hbChwbGFuZSwgY3J0YywgZmIsCj4gKwkJCQlwbGFuZV9yZXEtPmNydGNfeCwgcGxhbmVf cmVxLT5jcnRjX3ksCj4gKwkJCQlwbGFuZV9yZXEtPmNydGNfdywgcGxhbmVfcmVxLT5jcnRjX2gs Cj4gKwkJCQlwbGFuZV9yZXEtPnNyY194LCBwbGFuZV9yZXEtPnNyY195LAo+ICsJCQkJcGxhbmVf cmVxLT5zcmNfdywgcGxhbmVfcmVxLT5zcmNfaCk7Cj4gKwo+ICsJaWYgKGZiKQo+ICsJCWRybV9m cmFtZWJ1ZmZlcl9wdXQoZmIpOwo+ICsKPiArCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gIHN0YXRp YyBpbnQgZHJtX21vZGVfY3Vyc29yX3VuaXZlcnNhbChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4g QEAgLTc4OCwxMyArNzg3LDEyIEBAIHN0YXRpYyBpbnQgZHJtX21vZGVfY3Vyc29yX3VuaXZlcnNh bChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJc3JjX2ggPSBmYi0+aGVpZ2h0IDw8IDE2Owo+ ICAJfQo+ICAKPiAtCS8qCj4gLQkgKiBzZXRwbGFuZV9pbnRlcm5hbCB3aWxsIHRha2UgY2FyZSBv ZiBkZXJlZidpbmcgZWl0aGVyIHRoZSBvbGQgb3IgbmV3Cj4gLQkgKiBmcmFtZWJ1ZmZlciBkZXBl bmRpbmcgb24gc3VjY2Vzcy4KPiAtCSAqLwo+ICAJcmV0ID0gX19zZXRwbGFuZV9pbnRlcm5hbChj cnRjLT5jdXJzb3IsIGNydGMsIGZiLAo+IC0JCQkJY3J0Y194LCBjcnRjX3ksIGNydGNfdywgY3J0 Y19oLAo+IC0JCQkJMCwgMCwgc3JjX3csIHNyY19oLCBjdHgpOwo+ICsJCQkJICBjcnRjX3gsIGNy dGNfeSwgY3J0Y193LCBjcnRjX2gsCj4gKwkJCQkgIDAsIDAsIHNyY193LCBzcmNfaCwgY3R4KTsK PiArCj4gKwlpZiAoZmIpCj4gKwkJZHJtX2ZyYW1lYnVmZmVyX3B1dChmYik7Cj4gIAo+ICAJLyog VXBkYXRlIHN1Y2Nlc3NmdWw7IHNhdmUgbmV3IGN1cnNvciBwb3NpdGlvbiwgaWYgbmVjZXNzYXJ5 ICovCj4gIAlpZiAocmV0ID09IDAgJiYgcmVxLT5mbGFncyAmIERSTV9NT0RFX0NVUlNPUl9NT1ZF KSB7Cj4gLS0gCj4gMi4xNS4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwg SW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==