From: Roman Kagan Subject: Re: [PATCH v5 2/2] kvm: x86: hyperv: guest->host event signaling via eventfd Date: Tue, 12 Dec 2017 20:03:49 +0300 Message-ID: <20171212170349.GC19468@rkaganb.sw.ru> References: <20171212160742.793-1-rkagan@virtuozzo.com> <20171212160742.793-3-rkagan@virtuozzo.com> <938118d0-9296-0c0c-3251-275778c71c05@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , "Denis V. Lunev" , Konrad Rzeszutek Wilk , Vitaly Kuznetsov , David Hildenbrand To: Paolo Bonzini Return-path: Received: from mail-ve1eur02hn0213.outbound.protection.outlook.com ([104.47.6.213]:60716 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751274AbdLLREE (ORCPT ); Tue, 12 Dec 2017 12:04:04 -0500 Content-Disposition: inline In-Reply-To: <938118d0-9296-0c0c-3251-275778c71c05@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Dec 12, 2017 at 05:22:20PM +0100, Paolo Bonzini wrote: > On 12/12/2017 17:07, Roman Kagan wrote: > > + idx = srcu_read_lock(&vcpu->kvm->srcu); > > + ret = kvm_vcpu_read_guest(vcpu, gpa, ¶m, sizeof(param)); > > + srcu_read_unlock(&vcpu->kvm->srcu, idx); > > + > > The lock/unlock is not needed (vcpu_enter_guest -> vmx_handle_exit -> > handle_vmcall -> kvm_emulate_hypercall -> kvm_hv_hypercall -> > kvm_hvcall_signal_event). I'll drop it. Oh crap, indeed. I'll respin soonish. Thanks, Roman.