From: Brian Norris Subject: Re: [RESEND PATCH v3 1/3] drm/panel: refactor INNOLUX P079ZCA panel driver Date: Wed, 13 Dec 2017 12:46:29 -0800 Message-ID: <20171213204628.GA237314@google.com> References: <1512371870-15350-1-git-send-email-hl@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4DFF76E5CD for ; Wed, 13 Dec 2017 20:46:34 +0000 (UTC) Received: by mail-it0-x242.google.com with SMTP id d137so5927405itc.2 for ; Wed, 13 Dec 2017 12:46:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <1512371870-15350-1-git-send-email-hl@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lin Huang Cc: airlied@linux.ie, emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, nickey.yang@rock-chips.com, thierry.reding@gmail.com, dri-devel@lists.freedesktop.org, zyw@rock-chips.com, Guenter Roeck List-Id: dri-devel@lists.freedesktop.org SGkgSEwsCgpPbiBNb24sIERlYyAwNCwgMjAxNyBhdCAwMzoxNzo0OFBNICswODAwLCBMaW4gSHVh bmcgd3JvdGU6Cj4gUmVmYWN0b3IgSW5ub2x1eCBQMDc5WkNBIHBhbmVsIGRyaXZlciwgbGV0IGl0 IHN1cHBvcnQKPiBtdWx0aSBwYW5lbC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBMaW4gSHVhbmcgPGhs QHJvY2stY2hpcHMuY29tPgo+IC0tLQo+IENoYW5nZXMgaW4gdjI6Cj4gLSBDaGFuZ2UgcmVndWxh dG9yIHByb3BlcnR5IG5hbWUgdG8gbWVldCB0aGUgcGFuZWwgZGF0YXNoZWV0IAo+IENoYW5nZXMg aW4gdjM6Cj4gLSB0aGlzIHBhdGNoIG9ubHkgcmVmYWN0b3IgUDA3OVpDQSBwYW5lbCB0byBzdXBw b3J0IG11bHRpIHBhbmVsLCBzdXBwb3J0IFAwOTdQRkcgcGFuZWwgaW4gYW5vdGhlciBwYXRjaCAK PiAKPiAgZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLWlubm9sdXgtcDA3OXpjYS5jIHwgMTQ3 ICsrKysrKysrKysrKysrKysrKy0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMDUgaW5zZXJ0 aW9ucygrKSwgNDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9wYW5lbC9wYW5lbC1pbm5vbHV4LXAwNzl6Y2EuYyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9w YW5lbC1pbm5vbHV4LXAwNzl6Y2EuYwo+IGluZGV4IDZiYTkzNDQuLjE1OTc3NDQgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLWlubm9sdXgtcDA3OXpjYS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLWlubm9sdXgtcDA3OXpjYS5jCi4uLgoKPiBA QCAtMTM0LDEyICsxNjIsMTMgQEAgc3RhdGljIGludCBpbm5vbHV4X3BhbmVsX3ByZXBhcmUoc3Ry dWN0IGRybV9wYW5lbCAqcGFuZWwpCj4gIAlyZXR1cm4gMDsKPiAgCj4gIHBvd2Vyb2ZmOgo+IC0J cmVndWxhdG9yX2VyciA9IHJlZ3VsYXRvcl9kaXNhYmxlKGlubm9sdXgtPnN1cHBseSk7CgpJIHRo aW5rICdyZWd1bGF0b3JfZXJyJyBpcyB1bnVzZWQgYWZ0ZXIgdGhpcyBwYXRjaC4gUGxlYXNlIHJl bW92ZSBpdC4KCj4gLQlpZiAocmVndWxhdG9yX2VycikKPiAtCQlEUk1fREVWX0VSUk9SKHBhbmVs LT5kZXYsICJmYWlsZWQgdG8gZGlzYWJsZSByZWd1bGF0b3I6ICVkXG4iLAo+IC0JCQkgICAgICBy ZWd1bGF0b3JfZXJyKTsKPiAtCj4gIAlncGlvZF9zZXRfdmFsdWVfY2Fuc2xlZXAoaW5ub2x1eC0+ ZW5hYmxlX2dwaW8sIDApOwo+ICsJcmVndWxhdG9yX2Rpc2FibGUoaW5ub2x1eC0+YXZlZSk7Cj4g K2Rpc2FibGVfYXZkZDoKPiArCXJlZ3VsYXRvcl9kaXNhYmxlKGlubm9sdXgtPmF2ZGQpOwo+ICtk aXNhYmxlX3ZkZGk6Cj4gKwlyZWd1bGF0b3JfZGlzYWJsZShpbm5vbHV4LT52ZGRpKTsKPiArCj4g IAlyZXR1cm4gZXJyOwo+ICB9Cj4gIAoKLi4uCgo+IEBAIC0yMDksMjAgKzI1NiwzNiBAQCBzdGF0 aWMgY29uc3Qgc3RydWN0IGRybV9wYW5lbF9mdW5jcyBpbm5vbHV4X3BhbmVsX2Z1bmNzID0gewo+ ICB9Owo+ICAKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgaW5ub2x1eF9vZl9t YXRjaFtdID0gewo+IC0JeyAuY29tcGF0aWJsZSA9ICJpbm5vbHV4LHAwNzl6Y2EiLCB9LAo+IC0J eyB9CgpZb3UncmUgZGVsZXRpbmcgdGhpcyB0ZXJtaW5hdG9yLiBQbGVhc2UgZG9uJ3QuCgo+ICsJ eyAuY29tcGF0aWJsZSA9ICJpbm5vbHV4LHAwNzl6Y2EiLAo+ICsJICAuZGF0YSA9ICZpbm5vbHV4 X3AwNzl6Y2FfcGFuZWxfZGVzYwo+ICsJfSwKPiAgfTsKPiAgTU9EVUxFX0RFVklDRV9UQUJMRShv ZiwgaW5ub2x1eF9vZl9tYXRjaCk7Cj4gIAoKLi4uCgpCcmlhbgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK