From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915/psr: Don't name status or debug registers like control registers. Date: Wed, 20 Dec 2017 14:11:01 -0800 Message-ID: <20171220221101.w7ibzxfhsntncf7s@intel.com> References: <20171220201021.17619-1-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 495916E54C for ; Wed, 20 Dec 2017 22:11:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171220201021.17619-1-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBEZWMgMjAsIDIwMTcgYXQgMDg6MTA6MjFQTSArMDAwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBBdm9pZHMgc29tZSB0eXBvIHBpdGZhbGxzLgo+IAo+IENjOiBDaHJpcyBX aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2Ry aWdvLnZpdmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IERoaW5ha2FyYW4gUGFuZGl5YW4g PGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2 aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZGVidWdmcy5jIHwgIDQgKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jl Zy5oICAgICB8ICA2ICsrKy0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyAg ICB8IDI0ICsrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDE3IGlu c2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVi dWdmcy5jCj4gaW5kZXggYzQ3ODBmMDg1NDI4Li44MWNhOTQzM2ZjOWUgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IEBAIC0yNTc4LDkgKzI1NzgsOSBAQCBzdGF0aWMgaW50 IGk5MTVfZWRwX3Bzcl9zdGF0dXMoc3RydWN0IHNlcV9maWxlICptLCB2b2lkICpkYXRhKQo+ICAJ CXNlcV9wcmludGYobSwgIlBlcmZvcm1hbmNlX0NvdW50ZXI6ICV1XG4iLCBwc3JwZXJmKTsKPiAg CX0KPiAgCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfc3VwcG9ydCkgewo+IC0JCXUzMiBwc3IyID0g STkxNV9SRUFEKEVEUF9QU1IyX1NUQVRVU19DVEwpOwo+ICsJCXUzMiBwc3IyID0gSTkxNV9SRUFE KEVEUF9QU1IyX1NUQVRVUyk7Cj4gIAo+IC0JCXNlcV9wcmludGYobSwgIkVEUF9QU1IyX1NUQVRV U19DVEw6ICV4IFslc11cbiIsCj4gKwkJc2VxX3ByaW50ZihtLCAiRURQX1BTUjJfU1RBVFVTOiAl eCBbJXNdXG4iLAo+ICAJCQkgICBwc3IyLCBwc3IyX2xpdmVfc3RhdHVzKHBzcjIpKTsKPiAgCX0K PiAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPnBzci5sb2NrKTsKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cmVnLmgKPiBpbmRleCAyNjhiYmQwZWFhYTQuLmRiNzc1N2EwNDcyMCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9yZWcuaAo+IEBAIC00MDYwLDcgKzQwNjAsNyBAQCBlbnVtIHsKPiAgI2RlZmluZSBF RFBfUFNSX0FVWF9DVEwJCQkJX01NSU8oZGV2X3ByaXYtPnBzcl9tbWlvX2Jhc2UgKyAweDEwKQo+ ICAjZGVmaW5lIEVEUF9QU1JfQVVYX0RBVEEoaSkJCQlfTU1JTyhkZXZfcHJpdi0+cHNyX21taW9f YmFzZSArIDB4MTQgKyAoaSkgKiA0KSAvKiA1IHJlZ2lzdGVycyAqLwo+ICAKPiAtI2RlZmluZSBF RFBfUFNSX1NUQVRVU19DVEwJCQlfTU1JTyhkZXZfcHJpdi0+cHNyX21taW9fYmFzZSArIDB4NDAp Cj4gKyNkZWZpbmUgRURQX1BTUl9TVEFUVVMJCQkJX01NSU8oZGV2X3ByaXYtPnBzcl9tbWlvX2Jh c2UgKyAweDQwKQo+ICAjZGVmaW5lICAgRURQX1BTUl9TVEFUVVNfU1RBVEVfTUFTSwkJKDc8PDI5 KQo+ICAjZGVmaW5lICAgRURQX1BTUl9TVEFUVVNfU1RBVEVfSURMRQkJKDA8PDI5KQo+ICAjZGVm aW5lICAgRURQX1BTUl9TVEFUVVNfU1RBVEVfU1JET05BQ0sJCSgxPDwyOSkKPiBAQCAtNDA4Nyw3 ICs0MDg3LDcgQEAgZW51bSB7Cj4gICNkZWZpbmUgRURQX1BTUl9QRVJGX0NOVAkJX01NSU8oZGV2 X3ByaXYtPnBzcl9tbWlvX2Jhc2UgKyAweDQ0KQo+ICAjZGVmaW5lICAgRURQX1BTUl9QRVJGX0NO VF9NQVNLCQkweGZmZmZmZgo+ICAKPiAtI2RlZmluZSBFRFBfUFNSX0RFQlVHX0NUTAkJX01NSU8o ZGV2X3ByaXYtPnBzcl9tbWlvX2Jhc2UgKyAweDYwKQo+ICsjZGVmaW5lIEVEUF9QU1JfREVCVUcJ CQkJX01NSU8oZGV2X3ByaXYtPnBzcl9tbWlvX2Jhc2UgKyAweDYwKQo+ICAjZGVmaW5lICAgRURQ X1BTUl9ERUJVR19NQVNLX01BWF9TTEVFUCAgICAgICAgICgxPDwyOCkKPiAgI2RlZmluZSAgIEVE UF9QU1JfREVCVUdfTUFTS19MUFNQICAgICAgICAgICAgICAoMTw8MjcpCj4gICNkZWZpbmUgICBF RFBfUFNSX0RFQlVHX01BU0tfTUVNVVAgICAgICAgICAgICAgKDE8PDI2KQo+IEBAIC00MTEwLDcg KzQxMTAsNyBAQCBlbnVtIHsKPiAgI2RlZmluZSAgIEVEUF9QU1IyX0lETEVfTUFTSwkJMHhmCj4g ICNkZWZpbmUgICBFRFBfUFNSMl9GUkFNRV9CRUZPUkVfU1UoYSkJKChhKTw8NCkKPiAgCj4gLSNk ZWZpbmUgRURQX1BTUjJfU1RBVFVTX0NUTCAgICAgICAgICAgIF9NTUlPKDB4NmY5NDApCj4gKyNk ZWZpbmUgRURQX1BTUjJfU1RBVFVTCQkJX01NSU8oMHg2Zjk0MCkKPiAgI2RlZmluZSBFRFBfUFNS Ml9TVEFUVVNfU1RBVEVfTUFTSyAgICAgKDB4Zjw8MjgpCj4gICNkZWZpbmUgRURQX1BTUjJfU1RB VFVTX1NUQVRFX1NISUZUICAgIDI4Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9wc3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gaW5k ZXggMmUzMjYxNWVlYWRhLi40MDMyNTZhZDg3MWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9w c3IuYwo+IEBAIC00NzYsNyArNDc2LDcgQEAgc3RhdGljIHZvaWQgaHN3X3Bzcl9lbmFibGVfc291 cmNlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gIAkJCWNoaWNrZW4gfD0gUFNSMl9BRERf VkVSVElDQUxfTElORV9DT1VOVDsKPiAgCQlJOTE1X1dSSVRFKENISUNLRU5fVFJBTlMoY3B1X3Ry YW5zY29kZXIpLCBjaGlja2VuKTsKPiAgCj4gLQkJSTkxNV9XUklURShFRFBfUFNSX0RFQlVHX0NU TCwKPiArCQlJOTE1X1dSSVRFKEVEUF9QU1JfREVCVUcsCj4gIAkJCSAgIEVEUF9QU1JfREVCVUdf TUFTS19NRU1VUCB8Cj4gIAkJCSAgIEVEUF9QU1JfREVCVUdfTUFTS19IUEQgfAo+ICAJCQkgICBF RFBfUFNSX0RFQlVHX01BU0tfTFBTUCB8Cj4gQEAgLTQ5MCw3ICs0OTAsNyBAQCBzdGF0aWMgdm9p ZCBoc3dfcHNyX2VuYWJsZV9zb3VyY2Uoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgCQkg KiBwcmV2ZW50aW5nICBvdGhlciBodyB0cmFja2luZyBpc3N1ZXMgbm93IHdlIGNhbiByZWx5Cj4g IAkJICogb24gZnJvbnRidWZmZXIgdHJhY2tpbmcuCj4gIAkJICovCj4gLQkJSTkxNV9XUklURShF RFBfUFNSX0RFQlVHX0NUTCwKPiArCQlJOTE1X1dSSVRFKEVEUF9QU1JfREVCVUcsCj4gIAkJCSAg IEVEUF9QU1JfREVCVUdfTUFTS19NRU1VUCB8Cj4gIAkJCSAgIEVEUF9QU1JfREVCVUdfTUFTS19I UEQgfAo+ICAJCQkgICBFRFBfUFNSX0RFQlVHX01BU0tfTFBTUCk7Cj4gQEAgLTU5OSw3ICs1OTks NyBAQCBzdGF0aWMgdm9pZCBoc3dfcHNyX2Rpc2FibGUoc3RydWN0IGludGVsX2RwICppbnRlbF9k cCwKPiAgCQkJCQkwKTsKPiAgCj4gIAkJaWYgKGRldl9wcml2LT5wc3IucHNyMl9zdXBwb3J0KSB7 Cj4gLQkJCXBzcl9zdGF0dXMgPSBFRFBfUFNSMl9TVEFUVVNfQ1RMOwo+ICsJCQlwc3Jfc3RhdHVz ID0gRURQX1BTUjJfU1RBVFVTOwo+ICAJCQlwc3Jfc3RhdHVzX21hc2sgPSBFRFBfUFNSMl9TVEFU VVNfU1RBVEVfTUFTSzsKPiAgCj4gIAkJCUk5MTVfV1JJVEUoRURQX1BTUjJfQ1RMLAo+IEBAIC02 MDcsNyArNjA3LDcgQEAgc3RhdGljIHZvaWQgaHN3X3Bzcl9kaXNhYmxlKHN0cnVjdCBpbnRlbF9k cCAqaW50ZWxfZHAsCj4gIAkJCQkgICB+KEVEUF9QU1IyX0VOQUJMRSB8IEVEUF9TVV9UUkFDS19F TkFCTEUpKTsKPiAgCj4gIAkJfSBlbHNlIHsKPiAtCQkJcHNyX3N0YXR1cyA9IEVEUF9QU1JfU1RB VFVTX0NUTDsKPiArCQkJcHNyX3N0YXR1cyA9IEVEUF9QU1JfU1RBVFVTOwo+ICAJCQlwc3Jfc3Rh dHVzX21hc2sgPSBFRFBfUFNSX1NUQVRVU19TVEFURV9NQVNLOwo+ICAKPiAgCQkJSTkxNV9XUklU RShFRFBfUFNSX0NUTCwKPiBAQCAtNjc5LDE5ICs2NzksMTkgQEAgc3RhdGljIHZvaWQgaW50ZWxf cHNyX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAJaWYgKEhBU19EREkoZGV2X3By aXYpKSB7Cj4gIAkJaWYgKGRldl9wcml2LT5wc3IucHNyMl9zdXBwb3J0KSB7Cj4gIAkJCWlmIChp bnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwKPiAtCQkJCQkJRURQX1BTUjJfU1RBVFVT X0NUTCwKPiAtCQkJCQkJRURQX1BTUjJfU1RBVFVTX1NUQVRFX01BU0ssCj4gLQkJCQkJCTAsCj4g LQkJCQkJCTUwKSkgewo+ICsJCQkJCQkgICAgRURQX1BTUjJfU1RBVFVTLAo+ICsJCQkJCQkgICAg RURQX1BTUjJfU1RBVFVTX1NUQVRFX01BU0ssCj4gKwkJCQkJCSAgICAwLAo+ICsJCQkJCQkgICAg NTApKSB7Cj4gIAkJCQlEUk1fRVJST1IoIlRpbWVkIG91dCB3YWl0aW5nIGZvciBQU1IyIElkbGUg Zm9yIHJlLWVuYWJsZVxuIik7Cj4gIAkJCQlyZXR1cm47Cj4gIAkJCX0KPiAgCQl9IGVsc2Ugewo+ ICAJCQlpZiAoaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsCj4gLQkJCQkJCUVEUF9Q U1JfU1RBVFVTX0NUTCwKPiAtCQkJCQkJRURQX1BTUl9TVEFUVVNfU1RBVEVfTUFTSywKPiAtCQkJ CQkJMCwKPiAtCQkJCQkJNTApKSB7Cj4gKwkJCQkJCSAgICBFRFBfUFNSX1NUQVRVUywKPiArCQkJ CQkJICAgIEVEUF9QU1JfU1RBVFVTX1NUQVRFX01BU0ssCj4gKwkJCQkJCSAgICAwLAo+ICsJCQkJ CQkgICAgNTApKSB7Cj4gIAkJCQlEUk1fRVJST1IoIlRpbWVkIG91dCB3YWl0aW5nIGZvciBQU1Ig SWRsZSBmb3IgcmUtZW5hYmxlXG4iKTsKPiAgCQkJCXJldHVybjsKPiAgCQkJfQo+IC0tIAo+IDIu MTEuMAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK