Received: from smtp.codeaurora.org ([198.145.29.96]:38788 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23994630AbeAPPWlOamEf (ORCPT ); Tue, 16 Jan 2018 16:22:41 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC From: Kalle Valo In-Reply-To: <20180115211714.24009-1-jhogan@kernel.org> References: <20180115211714.24009-1-jhogan@kernel.org> Message-ID: <20180116152238.837E46083C@smtp.codeaurora.org> Date: Tue, 16 Jan 2018 15:22:38 +0000 (UTC) Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: James Hogan Cc: Michael Buesch , linux-wireless@vger.kernel.org, linux-mips@linux-mips.org, Ralf Baechle , Paul Burton , Matt Redfearn , Guenter Roeck Message-ID: <20180116152238.tjOEDDgisN8R4_XLMhoQIV5Py1cmEf0HDXTXY4Etb74@z> James Hogan wrote: > Since commit d41e6858ba58 ("MIPS: Kconfig: Set default MIPS system type > as generic") changed the default MIPS platform to the "generic" > platform, which uses PCI_DRIVERS_GENERIC instead of PCI_DRIVERS_LEGACY, > various files in drivers/ssb/ have failed to build. > > This is particularly due to the existence of struct pci_controller being > dependent on PCI_DRIVERS_LEGACY since commit c5611df96804 ("MIPS: PCI: > Introduce CONFIG_PCI_DRIVERS_LEGACY"), so add that dependency to Kconfig > to prevent these files being built for the "generic" platform including > all{yes,mod}config builds. > > Fixes: c5611df96804 ("MIPS: PCI: Introduce CONFIG_PCI_DRIVERS_LEGACY") > Signed-off-by: James Hogan > Cc: Michael Buesch > Cc: Ralf Baechle > Cc: Paul Burton > Cc: Matt Redfearn > Cc: Guenter Roeck > Cc: linux-wireless@vger.kernel.org > Cc: linux-mips@linux-mips.org > Tested-by: Guenter Roeck I'm planning to push this to 4.15 but not sure if there's enough time. -- https://patchwork.kernel.org/patch/10165371/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches