From: Daniel Schwierzeck Date: Thu, 25 Jan 2018 18:21:26 +0100 Subject: [U-Boot] [PATCH 3/4] travis.yml: fix 'set +e' in build script In-Reply-To: <20180125172127.17825-1-daniel.schwierzeck@gmail.com> References: <20180125172127.17825-1-daniel.schwierzeck@gmail.com> Message-ID: <20180125172127.17825-4-daniel.schwierzeck@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de The build script should not manipulate shell flags (especially '-e'). A non-zero exit value can also be catched with 'cmd || ret=$?'. Signed-off-by: Daniel Schwierzeck --- .travis.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 2a98c4bb11..1e55e1b7f1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -101,9 +101,8 @@ script: # # Exit code 129 means warnings only. - if [[ "${BUILDMAN}" != "" ]]; then - set +e; - tools/buildman/buildman -P ${BUILDMAN}; - ret=$?; + ret=0; + tools/buildman/buildman -P ${BUILDMAN} || ret=$?; if [[ $ret -ne 0 && $ret -ne 129 ]]; then tools/buildman/buildman -sdeP ${BUILDMAN}; exit $ret; -- 2.16.1