From: Jordan Crouse Subject: Re: [PATCH] drm/msm/adreno/a5xx_debugfs: fix potential NULL pointer dereference Date: Fri, 2 Feb 2018 09:30:06 -0700 Message-ID: <20180202163006.GA878@jcrouse-lnx.qualcomm.com> References: <20180202123223.GA4410@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180202123223.GA4410@embeddedor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" Cc: David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBGZWIgMDIsIDIwMTggYXQgMDY6MzI6MjNBTSAtMDYwMCwgR3VzdGF2byBBLiBSLiBT aWx2YSB3cm90ZToKPiBfbWlub3JfIGlzIGJlaW5nIGRlcmVmZXJlbmNlZCBiZWZvcmUgaXQgaXMg bnVsbCBjaGVja2VkLCBoZW5jZSB0aGVyZQo+IGlzIGEgcG90ZW50aWFsIG51bGwgcG9pbnRlciBk ZXJlZmVyZW5jZS4gRml4IHRoaXMgYnkgbW92aW5nIHRoZSBwb2ludGVyCj4gZGVyZWZlcmVuY2Ug YWZ0ZXIgX21pbm9yXyBoYXMgYmVlbiBudWxsIGNoZWNrZWQuCj4gCj4gRml4ZXM6IDAyNGFkOGRm NzYzZiAoImRybS9tc206IGFkZCBhNXh4IHNwZWNpZmljIGRlYnVnZnMiKQo+IFNpZ25lZC1vZmYt Ynk6IEd1c3Rhdm8gQS4gUi4gU2lsdmEgPGdhcnNpbHZhQGVtYmVkZGVkb3IuY29tPgo+IC0tLQo+ IAo+IEkgd29uZGVyIGlmIGEgYmV0dGVyIHNvbHV0aW9uIGZvciB0aGlzIHdvdWxkIGJlIHRvIFdB Uk5fT04gaW4gY2FzZSBfbWlub3JfCj4gaGFwcGVucyB0byBiZSBOVUxMIGFuZCByZXR1cm4gLUVJ TlZBTCwgaW5zdGVhZCBvZiBqdXN0IHJldHVybmluZyB6ZXJvLgo+IAo+IFNvbWV0aGluZyBsaWtl Ogo+IAo+IHN0cnVjdCBkcm1fZGV2aWNlICpkZXY7Cj4gCj4gaWYgKFdBUk5fT04oIW1pbm9yKQo+ IAlyZXR1cm4gLUVJTlZBTDsKPiAKPiBkZXYgPSBtaW5vci0+ZGV2Owo+IAo+IFdoYXQgZG8geW91 IHRoaW5rPwoKSW4gbXkgb3BpbmlvbiBldmVyeXRoaW5nIGluIGRlYnVnZnMgaXMgb3B0aW9uYWwu IEknbSBub3Qgc3VyZSBpZiBpdCBpcyBldmVuCnBvc3NpYmxlIGZvciBkZXYtPnByaW1hcnksIGRl di0+cmVuZGVyIG9yIGRldi0+Y29udHJvbCB0byBiZSBOVUxMIGZyb20gdGhlIERSTQpjb3JlIGJ1 dCBpZiBzbyBJIHRoaW5rIHRoZSBmYWlsdXJlIHNob3VsZCBiZSBzaWxlbnQuCgpKb3JkYW4KPiAK PiAgZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYTV4eF9kZWJ1Z2ZzLmMgfCA0ICsrKy0KPiAg MSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hNXh4X2RlYnVnZnMuYyBiL2RyaXZl cnMvZ3B1L2RybS9tc20vYWRyZW5vL2E1eHhfZGVidWdmcy5jCj4gaW5kZXggNmIyNzk0MS4uMDU5 ZWM3ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hNXh4X2RlYnVn ZnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2E1eHhfZGVidWdmcy5jCj4g QEAgLTE1OSwxMyArMTU5LDE1IEBAIERFRklORV9TSU1QTEVfQVRUUklCVVRFKHJlc2V0X2ZvcHMs IE5VTEwsIHJlc2V0X3NldCwgIiVsbHhcbiIpOwo+ICAKPiAgaW50IGE1eHhfZGVidWdmc19pbml0 KHN0cnVjdCBtc21fZ3B1ICpncHUsIHN0cnVjdCBkcm1fbWlub3IgKm1pbm9yKQo+ICB7Cj4gLQlz dHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gbWlub3ItPmRldjsKPiArCXN0cnVjdCBkcm1fZGV2aWNl ICpkZXY7Cj4gIAlzdHJ1Y3QgZGVudHJ5ICplbnQ7Cj4gIAlpbnQgcmV0Owo+ICAKPiAgCWlmICgh bWlub3IpCj4gIAkJcmV0dXJuIDA7Cj4gIAo+ICsJZGV2ID0gbWlub3ItPmRldjsKPiArCj4gIAly ZXQgPSBkcm1fZGVidWdmc19jcmVhdGVfZmlsZXMoYTV4eF9kZWJ1Z2ZzX2xpc3QsCj4gIAkJCUFS UkFZX1NJWkUoYTV4eF9kZWJ1Z2ZzX2xpc3QpLAo+ICAJCQltaW5vci0+ZGVidWdmc19yb290LCBt aW5vcik7Cj4gLS0gCj4gMi43LjQKPiAKPiAtLQo+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBs aXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC1hcm0tbXNtIiBpbgo+IHRoZSBi b2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCj4gTW9yZSBtYWpv cmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1s CgotLSAKVGhlIFF1YWxjb21tIElubm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9m IENvZGUgQXVyb3JhIEZvcnVtLAphIExpbnV4IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9q ZWN0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=