From: Tom Rini Date: Mon, 5 Feb 2018 17:45:22 -0500 Subject: [U-Boot] [PATCH 2/2] Remove config_distro_defaults.h In-Reply-To: <1517603831-20872-2-git-send-email-aford173@gmail.com> References: <1517603831-20872-1-git-send-email-aford173@gmail.com> <1517603831-20872-2-git-send-email-aford173@gmail.com> Message-ID: <20180205224522.GN4297@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Feb 02, 2018 at 02:37:11PM -0600, Adam Ford wrote: > With the contents of config_distro_defaults.h migrated to Kconfig, > we can remove this header file completely > > Signed-off-by: Adam Ford > --- > include/config_distro_defaults.h | 16 ---------------- So, I have a problem. In 1/2, and sadly, oops!, in other cases, we've not been good about enforcing config_distro_defaults.h -> select X under DISTRO_DEFAULTS entry in the top-level Kconfig. Can you please re-do 1/2 so that it adds a select line during migration? I think in general there's likely been no functional loss (as I'd have noticed size differences) but there is an ease of use loss (DISTRO_DEFAULTS should get X/Y/Z for a new board). Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: