Received: from eggs.gnu.org ([2001:4830:134:3::10]:51641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ej0rK-0007jH-VA for qemu-devel@nongnu.org; Tue, 06 Feb 2018 05:52:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ej0rK-0000Y9-3l for qemu-devel@nongnu.org; Tue, 06 Feb 2018 05:52:19 -0500 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Tue, 6 Feb 2018 10:52:04 +0000 Message-Id: <20180206105204.14817-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] block: include original filename when reporting invalid URIs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Jeff Cody , Kevin Wolf , Max Reitz , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Consider passing a JSON based block driver to "qemu-img commit" $ qemu-img commit 'json:{"driver":"qcow2","file":{"driver":"gluster",\ "volume":"gv0","path":"sn1.qcow2", "server":[{"type":\ "tcp","host":"10.73.199.197","port":"24007"}]},}' Currently it will commit the content and then report an incredibly useless error message when trying to re-open the committed image: qemu-img: invalid URI Usage: file=3Dgluster[+transport]://[host[:port]]volume/path[?socket=3D= ...][,file.debug=3DN][,file.logfile=3D/path/filename.log] With this fix we get: qemu-img: invalid URI json:{"server.0.host": "10.73.199.197", "driver": "gluster", "path": "luks.qcow2", "server.0.type": "tcp", "server.0.port": "24007", "volume": "gv0"} Of course the root cause problem still exists, but now we know what actually needs fixing. Signed-off-by: Daniel P. Berrang=C3=A9 --- block/gluster.c | 2 +- block/sheepdog.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index 0f4265a3a4..0215e19087 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -660,7 +660,7 @@ static struct glfs *qemu_gluster_init(BlockdevOptions= Gluster *gconf, if (filename) { ret =3D qemu_gluster_parse_uri(gconf, filename); if (ret < 0) { - error_setg(errp, "invalid URI"); + error_setg(errp, "invalid URI %s", filename); error_append_hint(errp, "Usage: file=3Dgluster[+transport]:/= /" "[host[:port]]volume/path[?socket=3D= ...]" "[,file.debug=3DN]" diff --git a/block/sheepdog.c b/block/sheepdog.c index f684477328..c847ab6c98 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -1050,7 +1050,7 @@ static void sd_parse_uri(SheepdogConfig *cfg, const= char *filename, =20 cfg->uri =3D uri =3D uri_parse(filename); if (!uri) { - error_setg(&err, "invalid URI"); + error_setg(&err, "invalid URI '%s'", filename); goto out; } =20 --=20 2.14.3