From: Pablo Neira Ayuso Subject: Re: [PATCH nf 2/7] netfilter: x_tables: prefer pr_debug where possible Date: Wed, 7 Feb 2018 18:02:22 +0100 Message-ID: <20180207170222.klnth4yebivljirc@salvia> References: <20180207134828.18691-1-fw@strlen.de> <20180207134828.18691-3-fw@strlen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Florian Westphal Return-path: Received: from mail.us.es ([193.147.175.20]:59364 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754392AbeBGRDF (ORCPT ); Wed, 7 Feb 2018 12:03:05 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 4014D3066AC for ; Wed, 7 Feb 2018 18:03:04 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 0B732C21BF for ; Wed, 7 Feb 2018 18:03:04 +0100 (CET) Content-Disposition: inline In-Reply-To: <20180207134828.18691-3-fw@strlen.de> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Feb 07, 2018 at 02:48:23PM +0100, Florian Westphal wrote: > prefer pr_debug for cases where error is usually not seen by users. > checkpatch complains due to lines > 80 but adding a newline doesn't > make things any more readable. > > Signed-off-by: Florian Westphal > --- > net/ipv4/netfilter/ipt_rpfilter.c | 2 +- > net/ipv6/netfilter/ip6t_rpfilter.c | 2 +- > net/netfilter/xt_SECMARK.c | 2 +- > net/netfilter/xt_bpf.c | 2 +- > net/netfilter/xt_connlabel.c | 2 +- > net/netfilter/xt_ipcomp.c | 2 +- > net/netfilter/xt_ipvs.c | 2 +- > net/netfilter/xt_l2tp.c | 2 +- > net/netfilter/xt_recent.c | 4 ++-- > net/netfilter/xt_socket.c | 8 ++++---- > net/netfilter/xt_time.c | 2 +- > 11 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/net/ipv4/netfilter/ipt_rpfilter.c b/net/ipv4/netfilter/ipt_rpfilter.c > index 37fb9552e858..ffd1cf65af3a 100644 > --- a/net/ipv4/netfilter/ipt_rpfilter.c > +++ b/net/ipv4/netfilter/ipt_rpfilter.c > @@ -105,7 +105,7 @@ static int rpfilter_check(const struct xt_mtchk_param *par) > const struct xt_rpfilter_info *info = par->matchinfo; > unsigned int options = ~XT_RPFILTER_OPTION_MASK; > if (info->flags & options) { > - pr_info("unknown options encountered"); > + pr_debug("unknown options"); OK, so the idea is to use pr_debug() when it is unlikely to hit an error via iptables, right?