Return-Path: Received: from hosting.pavoucek.net (hosting.pavoucek.net [46.28.107.168]) by mail.openembedded.org (Postfix) with ESMTP id 2C85571993 for ; Thu, 8 Feb 2018 09:57:41 +0000 (UTC) Received: from tomas-nb (nat8.vcit.vutbr.net [185.62.108.74]) (Authenticated sender: tomas@novotny.cz) by hosting.pavoucek.net (Postfix) with ESMTPSA id 21AFE104A9A; Thu, 8 Feb 2018 10:57:42 +0100 (CET) Date: Thu, 8 Feb 2018 10:57:41 +0100 From: Tomas Novotny To: Joshua Watt Message-ID: <20180208105741.6bbe99c0@tomas-nb> In-Reply-To: <1518038352.3509.18.camel@gmail.com> References: <20180207215913.1efc2300@tomas.local.tbs-biometrics.cz> <1518038352.3509.18.camel@gmail.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Cc: OE-core Subject: Re: [PATCH 00/14] Fix support for Icecream X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 09:57:42 -0000 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hi Joshua, On Wed, 07 Feb 2018 15:19:12 -0600 Joshua Watt wrote: > On Wed, 2018-02-07 at 21:59 +0100, Tomas Novotny wrote: > > Hi Joshua, > > > > On Tue, 6 Feb 2018 16:01:19 -0600 > > Joshua Watt wrote: > > > > > Fix up support for using Icecream to do distributed builds, which > > > appears to have been broken for some time. > > > > we were using icecream a year ago and we set ICECC_CARET_WORKAROUND > > env > > variable to 0 (in set_icecc_env() in icecc.bbclass). The default is 1 > > and it > > causes a local rebuild when any warning is emitted. > > > > I don't have exact numbers, but the extreme case was opencv. There > > was so > > many warnings that distributed build on ~10 threads was slower than > > local > > build on 4 threads. > > Ok, that make sense. I'll add a patch to default to > ICECC_CARET_WORKAROUND to my patch series. Thanks for the heads up! thanks a lot. Please note one smaller consequence. The warning message is retained, but the second line of warning containing "^" pointing to the exact position is not printed. I guess that this is ok for OE. Tomas > > I know that it is some kind of configuration, but I would set the > > default to > > 0. Or do it at least configurable. > > > > > In addition, Icecream support can now be enabled in the SDK. When > > > enabled, the SDK install process will check if the host supports > > > icecc > > > and if so will construct a proper environment tarball and use it > > > when > > > compiling. > > > > Thanks for work on that, I'm keen to use it in our environment. > > > > Tomas > > > > > Most of the changes should be straightforward. icecc-create-env has > > > been almost completely re-written but the changes were broken up > > > into > > > hopefully logical chunks. > > > > > > The following changes since commit > > > 385944254d0ef88bd6450a221a54cbcb40020b42: > > > > > > tcmode-default.inc: drop preferred version of gzip-native (2018- > > > 01-31 17:01:20 +0000) > > > > > > are available in the Git repository at: > > > > > > git://push.yoctoproject.org/poky-contrib jpew/icecream > > > > > > Joshua Watt (14): > > > icecc.bbclass: Move to shared work directory > > > icecc.bbclass: Fix STAGING_BINDIR_TOOLCHAIN usage > > > icecc.bbclass: Skip canadian-cross compiles > > > icecc-create-env: Reformat > > > icecc-create-env: Add /bin/true to environment > > > icecc-create-env: Use program interpreter for deps > > > icecc-create-env: Symlink alternate names > > > icecc-create-env: Archive directory > > > icecc-create-env: Fix executable rpaths > > > icecc-create-env: Add support for nativesdk > > > icecc-create-env: Allow multiple tool aliases > > > toolchain-shar-extract: Add post-relocate scripts > > > icecc-toolchain: Add SDK icecream setup > > > icecc.bbclass: Add IceCream support to SDK > > > > > > meta/classes/icecc.bbclass | 37 ++- > > > meta/classes/toolchain-scripts.bbclass | 15 + > > > meta/files/toolchain-shar-extract.sh | 8 + > > > meta/recipes-core/meta/meta-environment.bb | 2 + > > > .../icecc-create-env/icecc-create-env | 328 > > > ++++++++++++++------- > > > ...e-env-native_0.1.bb => icecc-create-env_0.1.bb} | 4 +- > > > .../icecc-toolchain/icecc-toolchain/icecc-env.sh | 37 +++ > > > .../icecc-toolchain/icecc-toolchain/icecc-setup.sh | 43 +++ > > > .../nativesdk-icecc-toolchain_0.1.bb | 38 +++ > > > 9 files changed, 390 insertions(+), 122 deletions(-) > > > rename meta/recipes-devtools/icecc-create-env/{icecc-create-env- > > > native_0.1.bb => icecc-create-env_0.1.bb} (98%) > > > create mode 100644 meta/recipes-devtools/icecc-toolchain/icecc- > > > toolchain/icecc-env.sh > > > create mode 100644 meta/recipes-devtools/icecc-toolchain/icecc- > > > toolchain/icecc-setup.sh > > > create mode 100644 meta/recipes-devtools/icecc- > > > toolchain/nativesdk-icecc-toolchain_0.1.bb > > > >