Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39568 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbeBIAS1 (ORCPT ); Thu, 8 Feb 2018 19:18:27 -0500 Date: Thu, 8 Feb 2018 16:18:25 -0800 From: Andrew Morton To: Andrei Vagin Cc: Alexey Dobriyan , Andrei Vagin , linux-fsdevel@vger.kernel.org, KAMEZAWA Hiroyuki Subject: Re: [PATCH 1/4] proc: add seq_put_decimal_ull_align to speed up /proc/pid/smaps Message-Id: <20180208161825.bc129ccf769b6c1147efb062@linux-foundation.org> In-Reply-To: <20180129210906.GA30738@outlook.office365.com> References: <20180129080043.14191-1-avagin@openvz.org> <20180129191041.GA6186@avx2> <20180129210906.GA30738@outlook.office365.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 29 Jan 2018 13:09:07 -0800 Andrei Vagin wrote: > On Mon, Jan 29, 2018 at 10:10:42PM +0300, Alexey Dobriyan wrote: > > On Mon, Jan 29, 2018 at 12:00:40AM -0800, Andrei Vagin wrote: > > > seq_put_decimal_ull_align(m, str, val, width) is equivalent of > > > seq_printf(m, "%s%*d", str, width, val), but it works much faster. > > > > It is called "minimum width", not alignment. > > Yes, you are right. And it's used to align numbers in output files. > > Maybe you could suggest a better name for this function? > _width? _min_width_? _pad?