From: Jonathan Gray Date: Sat, 10 Feb 2018 09:52:09 +1100 Subject: [U-Boot] [PATCH v1 1/2] mmc: Fix bug in sd_set_card_speed() In-Reply-To: <1518174568-12404-2-git-send-email-jjhiblot@ti.com> References: <1518174568-12404-1-git-send-email-jjhiblot@ti.com> <1518174568-12404-2-git-send-email-jjhiblot@ti.com> Message-ID: <20180209225209.GD9245@largo.jsg.id.au> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Feb 09, 2018 at 12:09:27PM +0100, Jean-Jacques Hiblot wrote: > After settings the speed of the sd with the switch command, a check is > done to make sure that the new speed has been set. The current check has a > masking error: speed are encoded on 4 bits only. > Fix it by masking the upper bits. > > This fixes a problem seen with QEmu emulating a vexpress-a15. > > Reported-by: Jonathan Gray > Signed-off-by: Jean-Jacques Hiblot With this change the emulated mmc controller can be accessed again here. Tested-by: Jonathan Gray > > --- > > drivers/mmc/mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > index 255310a..31614dd 100644 > --- a/drivers/mmc/mmc.c > +++ b/drivers/mmc/mmc.c > @@ -1333,7 +1333,7 @@ static int sd_set_card_speed(struct mmc *mmc, enum bus_mode mode) > if (err) > return err; > > - if ((__be32_to_cpu(switch_status[4]) >> 24) != speed) > + if (((__be32_to_cpu(switch_status[4]) >> 24) & 0xF) != speed) > return -ENOTSUPP; > > return 0; > -- > 1.9.1 >