Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:44928 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934415AbeBMPsI (ORCPT ); Tue, 13 Feb 2018 10:48:08 -0500 Date: Tue, 13 Feb 2018 16:46:38 +0100 From: Greg Kroah-Hartman To: Hugh Dickins Cc: Eric Biggers , stable@vger.kernel.org, Alexander Potapenko , Dave Hansen , x86@kernel.org Subject: Re: [PATCH 4.4] x86/kaiser: fix build error with KASAN && !FUNCTION_GRAPH_TRACER Message-ID: <20180213154638.GB14300@kroah.com> References: <20180209232131.60555-1-ebiggers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Sat, Feb 10, 2018 at 04:08:16PM -0800, Hugh Dickins wrote: > On Fri, 9 Feb 2018, Eric Biggers wrote: > > > This is a build fix for the 4.4 PTI backport. 4.4 kernels do not have > > commit be7635e7287e ("arch, ftrace: for KASAN put hard/soft IRQ entries > > into separate sections") which went into 4.6. Consequently, the > > irqentry sections are only created when CONFIG_FUNCTION_GRAPH_TRACER is > > enabled, not also when CONFIG_KASAN is enabled. Therefore, fix the > > condition for trying to add a user mapping for this section. > > > > This fixes the following build error: > > > > arch/x86/mm/kaiser.c: In function ‘kaiser_init’: > > arch/x86/mm/kaiser.c:367:33: error: ‘__irqentry_text_start’ undeclared (first use in this function) > > kaiser_add_user_map_ptrs_early(__irqentry_text_start, > > [...] > > > > Signed-off-by: Eric Biggers > > Yep, sorry about that, thanks Eric: > Acked-by: Hugh Dickins Thanks, now queued up. greg k-h